From: Mimi Zohar Date: Tue, 12 Nov 2019 17:05:16 +0000 Subject: Re: [PATCH v5 04/10] IMA: Updated IMA policy functions to return keyrings option read from the polic Message-Id: <1573578316.17949.43.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="maccentraleurope" Content-Transfer-Encoding: base64 List-Id: References: <20191111193303.12781-1-nramas@linux.microsoft.com> <20191111193303.12781-5-nramas@linux.microsoft.com> In-Reply-To: <20191111193303.12781-5-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gTW9uLCAyMDE5LTExLTExIGF0IDExOjMyIC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBkaWZmIC0tZ2l0IGEvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfcG9saWN5 LmMgYi9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYwo+IGluZGV4IDFhZWUzYzhi OWNmNi4uZDE4ODllZWU5Mjg3IDEwMDY0NAo+IC0tLSBhL3NlY3VyaXR5L2ludGVncml0eS9pbWEv aW1hX3BvbGljeS5jCj4gKysrIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfcG9saWN5LmMK PiBAQCAtNDgxLDYgKzQ4MSw3IEBAIHN0YXRpYyBpbnQgZ2V0X3N1YmFjdGlvbihzdHJ1Y3QgaW1h X3J1bGVfZW50cnkgKnJ1bGUsIGVudW0gaW1hX2hvb2tzIGZ1bmMpCj4gICAqIEBtYXNrOiByZXF1 ZXN0ZWQgYWN0aW9uIChNQVlfUkVBRCB8IE1BWV9XUklURSB8IE1BWV9BUFBFTkQgfCBNQVlfRVhF QykKPiAgICogQHBjcjogc2V0IHRoZSBwY3IgdG8gZXh0ZW5kCj4gICAqIEB0ZW1wbGF0ZV9kZXNj OiB0aGUgdGVtcGxhdGUgdGhhdCBzaG91bGQgYmUgdXNlZCBmb3IgdGhpcyBydWxlCj4gKyAqIEBr ZXlyaW5nczogc2V0IHRoZSBrZXlyaW5ncyBmb3IgdGhpcyBydWxlLCBpZiBzcGVjaWZpZWQKPiAg ICoKPiAgICogTWVhc3VyZSBkZWNpc2lvbiBiYXNlZCBvbiBmdW5jL21hc2svZnNtYWdpYyBhbmQg TFNNKHN1Ymovb2JqL3R5cGUpCj4gICAqIGNvbmRpdGlvbnMuCj4gQEAgLTQ5MSw3ICs0OTIsOCBA QCBzdGF0aWMgaW50IGdldF9zdWJhY3Rpb24oc3RydWN0IGltYV9ydWxlX2VudHJ5ICpydWxlLCBl bnVtIGltYV9ob29rcyBmdW5jKQo+ICAgKi8KPiAgaW50IGltYV9tYXRjaF9wb2xpY3koc3RydWN0 IGlub2RlICppbm9kZSwgY29uc3Qgc3RydWN0IGNyZWQgKmNyZWQsIHUzMiBzZWNpZCwKPiAgCQkg ICAgIGVudW0gaW1hX2hvb2tzIGZ1bmMsIGludCBtYXNrLCBpbnQgZmxhZ3MsIGludCAqcGNyLAo+ IC0JCSAgICAgc3RydWN0IGltYV90ZW1wbGF0ZV9kZXNjICoqdGVtcGxhdGVfZGVzYykKPiArCQkg ICAgIHN0cnVjdCBpbWFfdGVtcGxhdGVfZGVzYyAqKnRlbXBsYXRlX2Rlc2MsCj4gKwkJICAgICBj aGFyICoqa2V5cmluZ3MpCj4gIHsKPiAgCXN0cnVjdCBpbWFfcnVsZV9lbnRyeSAqZW50cnk7Cj4g IAlpbnQgYWN0aW9uID0gMCwgYWN0bWFzayA9IGZsYWdzIHwgKGZsYWdzIDw8IDEpOwo+IEBAIC01 MjcsNiArNTI5LDkgQEAgaW50IGltYV9tYXRjaF9wb2xpY3koc3RydWN0IGlub2RlICppbm9kZSwg Y29uc3Qgc3RydWN0IGNyZWQgKmNyZWQsIHUzMiBzZWNpZCwKPiAgCQlpZiAoKHBjcikgJiYgKGVu dHJ5LT5mbGFncyAmIElNQV9QQ1IpKQo+ICAJCQkqcGNyID0gZW50cnktPnBjcjsKPiAgCj4gKwkJ aWYgKChrZXlyaW5ncykgJiYgKGVudHJ5LT5mbGFncyAmIElNQV9LRVlSSU5HUykpCj4gKwkJCSpr ZXlyaW5ncyA9IGVudHJ5LT5rZXlyaW5nczsKCmltYV9tYXRjaF9ydWxlcygpIGRldGVybWluZXMg d2hldGhlciB0aGUgcnVsZSBpcyBpbiBwb2xpY3kgb3Igbm90LiBJdApyZXR1cm5zIHRydWUgb24g cnVsZSBtYXRjaCwgZmFsc2Ugb24gZmFpbHVyZS4gwqBUaGVyZSdzIG5vIG5lZWQgdG8KcmV0dXJu IHRoZSBsaXN0IG9mIGtleXJpbmdzLgoKTWltacKgCgo+ICsKPiAgCQlpZiAodGVtcGxhdGVfZGVz YyAmJiBlbnRyeS0+dGVtcGxhdGUpCj4gIAkJCSp0ZW1wbGF0ZV9kZXNjID0gZW50cnktPnRlbXBs YXRlOwo+ICAK