From: Mimi Zohar Date: Wed, 13 Nov 2019 20:09:24 +0000 Subject: Re: [PATCH v6 3/3] KEYS: Call the IMA hook to measure keys Message-Id: <1573675764.4843.14.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20191113184658.2862-1-nramas@linux.microsoft.com> <20191113184658.2862-4-nramas@linux.microsoft.com> In-Reply-To: <20191113184658.2862-4-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gV2VkLCAyMDE5LTExLTEzIGF0IDEwOjQ2IC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBDYWxsIHRoZSBJTUEgaG9vayBmcm9tIGtleV9jcmVhdGVfb3JfdXBkYXRlIGZ1 bmN0aW9uIHRvIG1lYXN1cmUKPiB0aGUga2V5IHdoZW4gYSBuZXcga2V5IGlzIGNyZWF0ZWQgb3Ig YW4gZXhpc3Rpbmcga2V5IGlzIHVwZGF0ZWQuCj4gCj4gVGhpcyBwYXRjaCBhZGRzIHRoZSBjYWxs IHRvIHRoZSBJTUEgaG9vayBmcm9tIGtleV9jcmVhdGVfb3JfdXBkYXRlCj4gZnVuY3Rpb24gdG8g bWVhc3VyZSB0aGUga2V5IG9uIGtleSBjcmVhdGUgb3IgdXBkYXRlLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IExha3NobWkgUmFtYXN1YnJhbWFuaWFuIDxucmFtYXNAbGludXgubWljcm9zb2Z0LmNvbT4K PiAtLS0KPiAgaW5jbHVkZS9saW51eC9pbWEuaCB8IDEzICsrKysrKysrKysrKysKPiAgc2VjdXJp dHkva2V5cy9rZXkuYyB8ICA5ICsrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9pbWEuaCBiL2luY2x1ZGUv bGludXgvaW1hLmgKPiBpbmRleCA2ZDkwNDc1NGQ4NTguLmVjNWFmZTMxOWFiNyAxMDA2NDQKPiAt LS0gYS9pbmNsdWRlL2xpbnV4L2ltYS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9pbWEuaAo+IEBA IC0yNSw2ICsyNSwxMiBAQCBleHRlcm4gaW50IGltYV9wb3N0X3JlYWRfZmlsZShzdHJ1Y3QgZmls ZSAqZmlsZSwgdm9pZCAqYnVmLCBsb2ZmX3Qgc2l6ZSwKPiAgZXh0ZXJuIHZvaWQgaW1hX3Bvc3Rf cGF0aF9ta25vZChzdHJ1Y3QgZGVudHJ5ICpkZW50cnkpOwo+ICBleHRlcm4gdm9pZCBpbWFfa2V4 ZWNfY21kbGluZShjb25zdCB2b2lkICpidWYsIGludCBzaXplKTsKPiAgCj4gKyNpZmRlZiBDT05G SUdfSU1BX01FQVNVUkVfQVNZTU1FVFJJQ19LRVlTCj4gK2V4dGVybiB2b2lkIGltYV9wb3N0X2tl eV9jcmVhdGVfb3JfdXBkYXRlKHN0cnVjdCBrZXkgKmtleXJpbmcsCj4gKwkJCQkJICBzdHJ1Y3Qg a2V5ICprZXksCj4gKwkJCQkJICB1bnNpZ25lZCBsb25nIGZsYWdzLCBib29sIGNyZWF0ZSk7Cj4g KyNlbmRpZgo+ICsKPiAgI2lmZGVmIENPTkZJR19JTUFfS0VYRUMKPiAgZXh0ZXJuIHZvaWQgaW1h X2FkZF9rZXhlY19idWZmZXIoc3RydWN0IGtpbWFnZSAqaW1hZ2UpOwo+ICAjZW5kaWYKPiBAQCAt MTAxLDYgKzEwNywxMyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW1hX2FkZF9rZXhlY19idWZmZXIo c3RydWN0IGtpbWFnZSAqaW1hZ2UpCj4gIHt9Cj4gICNlbmRpZgo+ICAKPiArI2lmbmRlZiBDT05G SUdfSU1BX01FQVNVUkVfQVNZTU1FVFJJQ19LRVlTCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBpbWFf cG9zdF9rZXlfY3JlYXRlX29yX3VwZGF0ZShzdHJ1Y3Qga2V5ICprZXlyaW5nLAo+ICsJCQkJCQkg c3RydWN0IGtleSAqa2V5LAo+ICsJCQkJCQkgdW5zaWduZWQgbG9uZyBmbGFncywKPiArCQkJCQkJ IGJvb2wgY3JlYXRlKSB7fQo+ICsjZW5kaWYKPiArCj4gICNpZmRlZiBDT05GSUdfSU1BX0FQUFJB SVNFCj4gIGV4dGVybiBib29sIGlzX2ltYV9hcHByYWlzZV9lbmFibGVkKHZvaWQpOwo+ICBleHRl cm4gdm9pZCBpbWFfaW5vZGVfcG9zdF9zZXRhdHRyKHN0cnVjdCBkZW50cnkgKmRlbnRyeSk7Cj4g ZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2tleXMva2V5LmMgYi9zZWN1cml0eS9rZXlzL2tleS5jCj4g aW5kZXggNzY0ZjRjNTc5MTNlLi45NzgyZDRkMDQ2ZmQgMTAwNjQ0Cj4gLS0tIGEvc2VjdXJpdHkv a2V5cy9rZXkuYwo+ICsrKyBiL3NlY3VyaXR5L2tleXMva2V5LmMKPiBAQCAtMTMsNiArMTMsNyBA QAo+ICAjaW5jbHVkZSA8bGludXgvc2VjdXJpdHkuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3dvcmtx dWV1ZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvcmFuZG9tLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9p bWEuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2Vyci5oPgo+ICAjaW5jbHVkZSAiaW50ZXJuYWwuaCIK PiAgCj4gQEAgLTkzNiw2ICs5MzcsOSBAQCBrZXlfcmVmX3Qga2V5X2NyZWF0ZV9vcl91cGRhdGUo a2V5X3JlZl90IGtleXJpbmdfcmVmLAo+ICAJCWdvdG8gZXJyb3JfbGlua19lbmQ7Cj4gIAl9Cj4g IAo+ICsJLyogbGV0IHRoZSBpbWEgbW9kdWxlIGtub3cgYWJvdXQgdGhlIGNyZWF0ZWQga2V5LiAq LwoKVGhpcyBjb21tZW50IGFuZCB0aGUgb25lIGJlbG93IGRvZXNuJ3QgcHJvdmlkZSBhbnkgYWRk aXRpb25hbAppbmZvcm1hdGlvbi4gwqBQbGVhc2UgcmVtb3ZlIHRoZW0uCgo+ICsJaW1hX3Bvc3Rf a2V5X2NyZWF0ZV9vcl91cGRhdGUoa2V5cmluZywga2V5LCBmbGFncywgdHJ1ZSk7Cj4gKwo+ICAJ a2V5X3JlZiA9IG1ha2Vfa2V5X3JlZihrZXksIGlzX2tleV9wb3NzZXNzZWQoa2V5cmluZ19yZWYp KTsKPiAgCj4gIGVycm9yX2xpbmtfZW5kOgo+IEBAIC05NjUsNiArOTY5LDExIEBAIGtleV9yZWZf dCBrZXlfY3JlYXRlX29yX3VwZGF0ZShrZXlfcmVmX3Qga2V5cmluZ19yZWYsCj4gIAl9Cj4gIAo+ ICAJa2V5X3JlZiA9IF9fa2V5X3VwZGF0ZShrZXlfcmVmLCAmcHJlcCk7Cj4gKwo+ICsJLyogbGV0 IHRoZSBpbWEgbW9kdWxlIGtub3cgYWJvdXQgdGhlIHVwZGF0ZWQga2V5LiAqLwo+ICsJaWYgKCFJ U19FUlIoa2V5X3JlZikpCj4gKwkJaW1hX3Bvc3Rfa2V5X2NyZWF0ZV9vcl91cGRhdGUoa2V5cmlu Zywga2V5LCBmbGFncywgZmFsc2UpOwo+ICsKPiAgCWdvdG8gZXJyb3JfZnJlZV9wcmVwOwo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woa2V5X2NyZWF0ZV9vcl91cGRhdGUpOwo=