From: Mimi Zohar Date: Wed, 13 Nov 2019 20:14:26 +0000 Subject: Re: [PATCH v6 1/3] IMA: Add KEY_CHECK func to measure keys Message-Id: <1573676066.4843.18.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20191113184658.2862-1-nramas@linux.microsoft.com> <20191113184658.2862-2-nramas@linux.microsoft.com> In-Reply-To: <20191113184658.2862-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gV2VkLCAyMDE5LTExLTEzIGF0IDEwOjQ2IC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBNZWFzdXJlIGtleXMgbG9hZGVkIG9udG8gYW55IGtleXJpbmcuCj4gCj4gVGhp cyBwYXRjaCBkZWZpbmVzIGEgbmV3IElNQSBwb2xpY3kgZnVuYyBuYW1lbHkgS0VZX0NIRUNLIHRv Cj4gbWVhc3VyZSBrZXlzLiBVcGRhdGVkIGltYV9tYXRjaF9ydWxlcygpIHRvIGNoZWNrIGZvciBL RVlfQ0hFQ0sKPiBhbmQgaW1hX3BhcnNlX3J1bGUoKSB0byBoYW5kbGUgS0VZX0NIRUNLLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IExha3NobWkgUmFtYXN1YnJhbWFuaWFuIDxucmFtYXNAbGludXgubWlj cm9zb2Z0LmNvbT4KPiAtLS0KPiAgRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9pbWFfcG9saWN5 IHwgNiArKysrKy0KPiAgc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWEuaCAgICAgICAgIHwgMSAr Cj4gIHNlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hX21haW4uYyAgICB8IDcgKysrKysrKwo+ICBz ZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYyAgfCA0ICsrKy0KPiAgNCBmaWxlcyBj aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL2ltYV9wb2xpY3kgYi9Eb2N1bWVudGF0aW9uL0FC SS90ZXN0aW5nL2ltYV9wb2xpY3kKPiBpbmRleCAyOWFhZWRmMzMyNDYuLjA2NmQzMjc5NzUwMCAx MDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL2ltYV9wb2xpY3kKPiArKysg Yi9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL2ltYV9wb2xpY3kKPiBAQCAtMjksNyArMjksNyBA QCBEZXNjcmlwdGlvbjoKPiAgCQliYXNlOiAJZnVuYzo9IFtCUFJNX0NIRUNLXVtNTUFQX0NIRUNL XVtDUkVEU19DSEVDS11bRklMRV9DSEVDS11bTU9EVUxFX0NIRUNLXQo+ICAJCQkJW0ZJUk1XQVJF X0NIRUNLXQo+ICAJCQkJW0tFWEVDX0tFUk5FTF9DSEVDS10gW0tFWEVDX0lOSVRSQU1GU19DSEVD S10KPiAtCQkJCVtLRVhFQ19DTURMSU5FXQo+ICsJCQkJW0tFWEVDX0NNRExJTkVdIFtLRVlfQ0hF Q0tdCj4gIAkJCW1hc2s6PSBbW15dTUFZX1JFQURdIFtbXl1NQVlfV1JJVEVdIFtbXl1NQVlfQVBQ RU5EXQo+ICAJCQkgICAgICAgW1teXU1BWV9FWEVDXQo+ICAJCQlmc21hZ2ljOj0gaGV4IHZhbHVl Cj4gQEAgLTExMywzICsxMTMsNyBAQCBEZXNjcmlwdGlvbjoKPiAgCQlFeGFtcGxlIG9mIGFwcHJh aXNlIHJ1bGUgYWxsb3dpbmcgbW9kc2lnIGFwcGVuZGVkIHNpZ25hdHVyZXM6Cj4gIAo+ICAJCQlh cHByYWlzZSBmdW5jPUtFWEVDX0tFUk5FTF9DSEVDSyBhcHByYWlzZV90eXBlPWltYXNpZ3xtb2Rz aWcKPiArCj4gKwkJRXhhbXBsZSBvZiBtZWFzdXJlIHJ1bGUgdXNpbmcgS0VZX0NIRUNLIHRvIG1l YXN1cmUgYWxsIGtleXM6Cj4gKwo+ICsJCQltZWFzdXJlIGZ1bmM9S0VZX0NIRUNLCj4gZGlmZiAt LWdpdCBhL3NlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hLmggYi9zZWN1cml0eS9pbnRlZ3JpdHkv aW1hL2ltYS5oCj4gaW5kZXggZGY0Y2E0ODJmYjUzLi5mZTZjNjk4NjE3YmQgMTAwNjQ0Cj4gLS0t IGEvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWEuaAo+ICsrKyBiL3NlY3VyaXR5L2ludGVncml0 eS9pbWEvaW1hLmgKPiBAQCAtMTkzLDYgKzE5Myw3IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQg bG9uZyBpbWFfaGFzaF9rZXkodTggKmRpZ2VzdCkKPiAgCWhvb2soS0VYRUNfSU5JVFJBTUZTX0NI RUNLKQlcCj4gIAlob29rKFBPTElDWV9DSEVDSykJCVwKPiAgCWhvb2soS0VYRUNfQ01ETElORSkJ CVwKPiArCWhvb2soS0VZX0NIRUNLKQkJCVwKPiAgCWhvb2soTUFYX0NIRUNLKQo+ICAjZGVmaW5l IF9faW1hX2hvb2tfZW51bWlmeShFTlVNKQlFTlVNLAo+ICAKPiBkaWZmIC0tZ2l0IGEvc2VjdXJp dHkvaW50ZWdyaXR5L2ltYS9pbWFfbWFpbi5jIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFf bWFpbi5jCj4gaW5kZXggZDdlOTg3YmFmMTI3Li4xMjY4NGU4ZDcxMjQgMTAwNjQ0Cj4gLS0tIGEv c2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfbWFpbi5jCj4gKysrIGIvc2VjdXJpdHkvaW50ZWdy aXR5L2ltYS9pbWFfbWFpbi5jCj4gQEAgLTY1NSw2ICs2NTUsMTMgQEAgdm9pZCBwcm9jZXNzX2J1 ZmZlcl9tZWFzdXJlbWVudChjb25zdCB2b2lkICpidWYsIGludCBzaXplLAo+ICAJaW50IGFjdGlv biA9IDA7Cj4gIAl1MzIgc2VjaWQ7Cj4gIAo+ICsJLyoKPiArCSAqIElmIElNQSBpcyBub3QgeWV0 IGluaXRpYWxpemVkIG9yIElNQSBwb2xpY3kgaXMgZW1wdHkKPiArCSAqIHRoZW4gdGhlcmUgaXMg bm8gbmVlZCB0byBtZWFzdXJlLgo+ICsJICovCj4gKwlpZiAoIWltYV9wb2xpY3lfZmxhZykKPiAr CQlyZXR1cm47Cj4gKwoKVGhpcyBhZGRpdGlvbiBoYXMgbm90aGluZyB0byBkbyB3aXRoIGRlZmlu aW5nIGEgbmV3IElNQSBob29rIGFuZApzaG91bGQgYmUgYSBzZXBhcmF0ZSBwYXRjaC4gwqBUaGlz IGNhbiBiZSBwb3N0ZWQgaW5kZXBlbmRlbnRseSBvZiB0aGlzCnBhdGNoIHNldC4KCk1pbWkKCj4g IAkvKgo+ICAJICogQm90aCBMU00gaG9va3MgYW5kIGF1eGlsYXJ5IGJhc2VkIGJ1ZmZlciBtZWFz dXJlbWVudHMgYXJlCj4gIAkgKiBiYXNlZCBvbiBwb2xpY3kuICBUbyBhdm9pZCBjb2RlIGR1cGxp Y2F0aW9uLCBkaWZmZXJlbnRpYXRlCj4gZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2ludGVncml0eS9p bWEvaW1hX3BvbGljeS5jIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfcG9saWN5LmMKPiBp bmRleCBmMTlhODk1YWQ3Y2QuLjE1MjVhMjhmZDcwNSAxMDA2NDQKPiAtLS0gYS9zZWN1cml0eS9p bnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVncml0eS9pbWEv aW1hX3BvbGljeS5jCj4gQEAgLTM3Myw3ICszNzMsNyBAQCBzdGF0aWMgYm9vbCBpbWFfbWF0Y2hf cnVsZXMoc3RydWN0IGltYV9ydWxlX2VudHJ5ICpydWxlLCBzdHJ1Y3QgaW5vZGUgKmlub2RlLAo+ ICB7Cj4gIAlpbnQgaTsKPiAgCj4gLQlpZiAoZnVuYyA9IEtFWEVDX0NNRExJTkUpIHsKPiArCWlm ICgoZnVuYyA9IEtFWEVDX0NNRExJTkUpIHx8IChmdW5jID0gS0VZX0NIRUNLKSkgewo+ICAJCWlm ICgocnVsZS0+ZmxhZ3MgJiBJTUFfRlVOQykgJiYgKHJ1bGUtPmZ1bmMgPSBmdW5jKSkKPiAgCQkJ cmV0dXJuIHRydWU7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+IEBAIC05OTcsNiArOTk3LDggQEAgc3Rh dGljIGludCBpbWFfcGFyc2VfcnVsZShjaGFyICpydWxlLCBzdHJ1Y3QgaW1hX3J1bGVfZW50cnkg KmVudHJ5KQo+ICAJCQkJZW50cnktPmZ1bmMgPSBQT0xJQ1lfQ0hFQ0s7Cj4gIAkJCWVsc2UgaWYg KHN0cmNtcChhcmdzWzBdLmZyb20sICJLRVhFQ19DTURMSU5FIikgPSAwKQo+ICAJCQkJZW50cnkt PmZ1bmMgPSBLRVhFQ19DTURMSU5FOwo+ICsJCQllbHNlIGlmIChzdHJjbXAoYXJnc1swXS5mcm9t LCAiS0VZX0NIRUNLIikgPSAwKQo+ICsJCQkJZW50cnktPmZ1bmMgPSBLRVlfQ0hFQ0s7Cj4gIAkJ CWVsc2UKPiAgCQkJCXJlc3VsdCA9IC1FSU5WQUw7Cj4gIAkJCWlmICghcmVzdWx0KQo=