From: Mimi Zohar Date: Wed, 27 Nov 2019 18:52:21 +0000 Subject: Re: [PATCH v9 5/6] IMA: Add support to limit measuring keys Message-Id: <1574880741.4793.292.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="maccentraleurope" Content-Transfer-Encoding: base64 List-Id: References: <20191127015654.3744-1-nramas@linux.microsoft.com> <20191127015654.3744-6-nramas@linux.microsoft.com> In-Reply-To: <20191127015654.3744-6-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org PiAtLS0gYS9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYwo+ICsrKyBiL3NlY3Vy aXR5L2ludGVncml0eS9pbWEvaW1hX3BvbGljeS5jCj4gQEAgLTc5LDYgKzc5LDcgQEAgc3RydWN0 IGltYV9ydWxlX2VudHJ5IHsKPiAgCQlpbnQgdHlwZTsJLyogYXVkaXQgdHlwZSAqLwo+ICAJfSBs c21bTUFYX0xTTV9SVUxFU107Cj4gIAljaGFyICpmc25hbWU7Cj4gKwljaGFyICprZXlyaW5nczsg LyogTWVhc3VyZSBrZXlzIGFkZGVkIHRvIHRoZXNlIGtleXJpbmdzICovCj4gIAlzdHJ1Y3QgaW1h X3RlbXBsYXRlX2Rlc2MgKnRlbXBsYXRlOwo+ICB9Owo+ICAKPiBAQCAtMzU2LDYgKzM1Nyw1NSBA QCBpbnQgaW1hX2xzbV9wb2xpY3lfY2hhbmdlKHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIsIHVu c2lnbmVkIGxvbmcgZXZlbnQsCj4gIAlyZXR1cm4gTk9USUZZX09LOwo+ICB9Cj4gIAo+ICsvKioK PiArICogaW1hX21hdGNoX2tleXJpbmcgLSBkZXRlcm1pbmUgd2hldGhlciB0aGUga2V5cmluZyBt YXRjaGVzIHRoZSBtZWFzdXJlIHJ1bGUKPiArICogQHJ1bGU6IGEgcG9pbnRlciB0byBhIHJ1bGUK PiArICogQGtleXJpbmc6IG5hbWUgb2YgdGhlIGtleXJpbmcgdG8gbWF0Y2ggYWdhaW5zdCB0aGUg bWVhc3VyZSBydWxlCj4gKyAqCj4gKyAqIElmIHRoZSBtZWFzdXJlIGFjdGlvbiBmb3IgS0VZX0NI RUNLIGRvZXMgbm90IHNwZWNpZnkga2V5cmluZ3M+ICsgKiBvcHRpb24gdGhlbiByZXR1cm4gdHJ1 ZSAoTWVhc3VyZSBhbGwga2V5cykuCj4gKyAqIEVsc2UsIHJldHVybiB0cnVlIGlmIHRoZSBnaXZl biBrZXlyaW5nIG5hbWUgaXMgcHJlc2VudCBpbgo+ICsgKiB0aGUga2V5cmluZ3M9IG9wdGlvbi4g RmFsc2UsIG90aGVyd2lzZS4KClRoaXMgaXMgc3VwcG9zZSB0byBiZSBhIGNvbW1lbnQsIG5vdCBj b2RlIG9yIHBzZXVkbyBjb2RlLiDCoFBsZWFzZQpyZWZlciB0byB0aGUgc2VjdGlvbiAiQ29tbWVu dHMiIGluIERvY3VtZW50YXRpb24vcHJvY2Vzcy9jb2RpbmctCnN0eWxlLnJzdC4KwqAKPiArICov Cj4gK3N0YXRpYyBib29sIGltYV9tYXRjaF9rZXlyaW5nKHN0cnVjdCBpbWFfcnVsZV9lbnRyeSAq cnVsZSwKPiArCQkJICAgICAgY29uc3QgY2hhciAqa2V5cmluZykKPiArewo+ICsJY29uc3QgY2hh ciAqcDsKPiArCj4gKwkvKiBJZiAia2V5cmluZ3M9IiBpcyBub3Qgc3BlY2lmaWVkIGFsbCBrZXlz IGFyZSBtZWFzdXJlZC4gKi8KPiArCWlmICghcnVsZS0+a2V5cmluZ3MpCj4gKwkJcmV0dXJuIHRy dWU7Cj4gKwo+ICsJaWYgKCFrZXlyaW5nKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwkvKgo+ ICsJICogImtleXJpbmdzPSIgaXMgc3BlY2lmaWVkIGluIHRoZSBwb2xpY3kgaW4gdGhlIGZvcm1h dCBiZWxvdzoKPiArCSAqICAga2V5cmluZ3M9LmJ1aWx0aW5fdHJ1c3RlZF9rZXlzfC5pbWF8LmV2 bQo+ICsJICoKPiArCSAqIEVhY2gga2V5cmluZyBuYW1lIGluIHRoZSBvcHRpb24gaXMgc2VwYXJh dGVkIGJ5IGEgJ3wnIGFuZAo+ICsJICogdGhlIGxhc3Qga2V5cmluZyBuYW1lIGlzIG51bGwgdGVy bWluYXRlZC4KPiArCSAqCj4gKwkgKiBUaGUgZ2l2ZW4ga2V5cmluZyBpcyBjb25zaWRlcmVkIG1h dGNoZWQgb25seSBpZgo+ICsJICogdGhlIHdob2xlIGtleXJpbmcgbmFtZSBtYXRjaGVkIGEga2V5 cmluZyBuYW1lIHNwZWNpZmllZAo+ICsJICogaW4gdGhlICJrZXlyaW5ncz0iIG9wdGlvbi4KPiAr CSAqLwo+ICsJcCA9IHN0cnN0cihydWxlLT5rZXlyaW5ncywga2V5cmluZyk7Cj4gKwlpZiAocCkg ewo+ICsJCS8qCj4gKwkJICogRm91bmQgYSBzdWJzdHJpbmcgbWF0Y2guIENoZWNrIGlmIHRoZSBj aGFyYWN0ZXIKPiArCQkgKiBhdCB0aGUgZW5kIG9mIHRoZSBrZXlyaW5nIG5hbWUgaXMgfCAoa2V5 cmluZyBuYW1lCj4gKwkJICogc2VwYXJhdG9yKSBvciBpcyB0aGUgdGVybWluYXRpbmcgbnVsbCBj aGFyYWN0ZXIuCj4gKwkJICogSWYgeWVzLCB3ZSBoYXZlIGEgd2hvbGUgc3RyaW5nIG1hdGNoLgo+ ICsJCSAqLwo+ICsJCXAgKz0gc3RybGVuKGtleXJpbmcpOwo+ICsJCWlmICgqcCA9ICd8JyB8fCAq cCA9ICdcMCcpCj4gKwkJCXJldHVybiB0cnVlOwo+ICsJfQo+ICsKClVzaW5nICJ3aGlsZSBzdHJz ZXAoKSIgd291bGQgc2ltcGxpZnkgdGhpcyBjb2RlLCByZW1vdmluZyB0aGUgbmVlZCBmb3IKc3Vj aCBhIGxvbmcgY29tbWVudC4KCk1pbWkKCj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCg==