From: Mimi Zohar Date: Mon, 16 Dec 2019 12:30:00 +0000 Subject: Re: [PATCH v4 1/2] IMA: Define workqueue for early boot "key" measurements Message-Id: <1576499400.4579.305.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20191213171827.28657-1-nramas@linux.microsoft.com> <20191213171827.28657-2-nramas@linux.microsoft.com> In-Reply-To: <20191213171827.28657-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, mathew.j.martineau@linux.intel.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org T24gRnJpLCAyMDE5LTEyLTEzIGF0IDA5OjE4IC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKCj4gKy8qCj4gKyAqIGltYV9wcm9jZXNzX3F1ZXVlZF9rZXlzKCkgLSBwcm9jZXNz IGtleXMgcXVldWVkIGZvciBtZWFzdXJlbWVudAo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHNl dHMgaW1hX3Byb2Nlc3Nfa2V5cyB0byB0cnVlIGFuZCBwcm9jZXNzZXMgcXVldWVkIGtleXMuCj4g KyAqIEZyb20gaGVyZSBvbiBrZXlzIHdpbGwgYmUgcHJvY2Vzc2VkIHJpZ2h0IGF3YXkgKG5vdCBx dWV1ZWQpLgo+ICsgKi8KPiArdm9pZCBpbWFfcHJvY2Vzc19xdWV1ZWRfa2V5cyh2b2lkKQo+ICt7 Cj4gKwlzdHJ1Y3QgaW1hX2tleV9lbnRyeSAqZW50cnksICp0bXA7Cj4gKwlMSVNUX0hFQUQodGVt cF9pbWFfa2V5cyk7Cj4gKwlib29sIHByb2Nlc3MgPSBmYWxzZTsKPiArCj4gKwlpZiAoaW1hX3By b2Nlc3Nfa2V5cykKPiArCQlyZXR1cm47Cj4gKwo+ICsJLyoKPiArCSAqIFRvIGF2b2lkIGhvbGRp bmcgdGhlIG11dGV4IHdoZW4gcHJvY2Vzc2luZyBxdWV1ZWQga2V5cywKPiArCSAqIHRyYW5zZmVy IHRoZSBxdWV1ZWQga2V5cyB3aXRoIHRoZSBtdXRleCBoZWxkIHRvIGEgdGVtcCBsaXN0LAo+ICsJ ICogcmVsZWFzZSB0aGUgbXV0ZXgsIGFuZCB0aGVuIHByb2Nlc3MgdGhlIHF1ZXVlZCBrZXlzIGZy b20KPiArCSAqIHRoZSB0ZW1wIGxpc3QuCj4gKwkgKgo+ICsJICogU2luY2UgaW1hX3Byb2Nlc3Nf a2V5cyBpcyBzZXQgdG8gdHJ1ZSwgYW55IG5ldyBrZXkgd2lsbCBiZQo+ICsJICogcHJvY2Vzc2Vk IGltbWVkaWF0ZWx5IGFuZCBub3QgYmUgcXVldWVkLgo+ICsJICovCj4gKwlJTklUX0xJU1RfSEVB RCgmdGVtcF9pbWFfa2V5cyk7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmaW1hX2tleXNfbXV0ZXgpOwo+ ICsKPiArCWlmICghaW1hX3Byb2Nlc3Nfa2V5cykgewo+ICsJCWltYV9wcm9jZXNzX2tleXMgPSB0 cnVlOwoKVGhhbmsgeW91IGZvciBtb3ZpbmcgdGhlIGluaXRpYWxpemF0aW9uIGhlcmUuIMKgVGhl IGNvbW1lbnQgaXMgbm93CnZhbGlkIGFuZCB0aGUgZm9sbG93aW5nIGNvZGUgaXMgbm93IGd1YXJh bnRlZWQgdG8gZXhlY3V0ZSBqdXN0IG9uY2UuCgo+ICsKPiArCQlpZiAoIWxpc3RfZW1wdHkoJmlt YV9rZXlzKSkgewo+ICsJCQlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUoZW50cnksIHRtcCwgJmlt YV9rZXlzLCBsaXN0KQo+ICsJCQkJbGlzdF9tb3ZlX3RhaWwoJmVudHJ5LT5saXN0LCAmdGVtcF9p bWFfa2V5cyk7Cj4gKwkJCXByb2Nlc3MgPSB0cnVlOwo+ICsJCX0KPiArCX0KPiArCj4gKwltdXRl eF91bmxvY2soJmltYV9rZXlzX211dGV4KTsKPiArCj4gKwlpZiAoIXByb2Nlc3MpCj4gKwkJcmV0 dXJuOwoKVGhlIG5ldyBjaGFuZ2VzIC0gY2hlY2tpbmcgaWYgdGhlIGxpc3QgaXMgZW1wdHkgYW5k IHRoaXMgdGVzdCAtIGFyZQp1bm5lY2Vzc2FyeSwgYXMgeW91IGltcGxpZWQgZWFybGllci4KCk1p bWkKCj4gKwo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKGVudHJ5LCB0bXAsICZ0ZW1wX2lt YV9rZXlzLCBsaXN0KSB7Cj4gKwkJcHJvY2Vzc19idWZmZXJfbWVhc3VyZW1lbnQoZW50cnktPnBh eWxvYWQsIGVudHJ5LT5wYXlsb2FkX2xlbiwKPiArCQkJCQkgICBlbnRyeS0+a2V5cmluZ19uYW1l LCBLRVlfQ0hFQ0ssIDAsCj4gKwkJCQkJICAgZW50cnktPmtleXJpbmdfbmFtZSk7Cj4gKwkJbGlz dF9kZWwoJmVudHJ5LT5saXN0KTsKPiArCQlpbWFfZnJlZV9rZXlfZW50cnkoZW50cnkpOwo+ICsJ fQo+ICt9Cj4gKwo+ICAvKioKPiAgICogaW1hX3Bvc3Rfa2V5X2NyZWF0ZV9vcl91cGRhdGUgLSBt ZWFzdXJlIGFzeW1tZXRyaWMga2V5cwo+ICAgKiBAa2V5cmluZzoga2V5cmluZyB0byB3aGljaCB0 aGUga2V5IGlzIGxpbmtlZCB0bwo=