From: "cron2 (Code Review)" Date: Mon, 6 Apr 2026 10:01:26 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1578c0891c3f49e3c5b4b8ba20bd0cd0b90048d9-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="iY0PYTPYgvU="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: test_packet_id: Add a check after malloc to ensure value is valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --iY0PYTPYgvU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 21?usp=3Demail ) Change subject: test_packet_id: Add a check after malloc to ensure value is= valid ...................................................................... test_packet_id: Add a check after malloc to ensure value is valid cppcheck complains about a potential null pointer dereference in reliable_get_num_output_sequenced_available. That is mostly theoretical, but still add a check. Change-Id: I64da2328591ef2b9ee7502e574c878651cdf356a Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1621 Message-Id: <20260406074729.29903-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 516.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_packet_id.c 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/tests/unit_tests/openvpn/test_packet_id.c b/tests/unit_tests/o= penvpn/test_packet_id.c index b7538bd..5dfd319 100644 --- a/tests/unit_tests/openvpn/test_packet_id.c +++ b/tests/unit_tests/openvpn/test_packet_id.c @@ -164,6 +164,7 @@ test_get_num_output_sequenced_available(void **state) { struct reliable *rel =3D malloc(sizeof(struct reliable)); + assert_non_null(rel); reliable_init(rel, 100, 50, 8, false); rel->array[5].active =3D true; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1621?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I64da2328591ef2b9ee7502e574c878651cdf356a Gerrit-Change-Number: 1621 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --iY0PYTPYgvU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

test_packet_id: Add a check after malloc to ensu=
re value is valid

cppcheck complains about a potential null pointer = dereference
in reliable_get_num_output_sequenced_available. That is most= ly
theoretical, but still add a check.

Change-Id: I64da2328591ef2= b9ee7502e574c878651cdf356a
Signed-off-by: Frank Lichtenheld <frank@...1186...= .2641...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit UR= L: https://gerrit.openvpn.net/c/openvpn/+/1621
Message-Id: <202604060= 74729.29903-1-gert@...1296...>
URL: https://www.mail-archive.com/open= vpn-devel@lists.sourceforge.net/msg36516.html
Signed-off-by: Gert Doerin= g <gert@...1296...>
---
M tests/unit_tests/openvpn/test_packet_= id.c
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/tests/unit_tests/openvpn/test_packet_id.c b/tests/unit_test=
s/openvpn/test_packet_id.c
index b7538bd..5dfd319 100644
--- a/tests/unit_tests/openvpn/test_packet_id.c
+++ b/tests/unit_tests/openvpn/test_packet_id.c

@@ -164,= 6 +164,7 @@
test_get_num_output_sequenced_available(void *= *state)
{
struct reliable *rel =3D ma= lloc(sizeof(struct reliable));
+ assert_non_null(rel);
reliable_init(rel= , 100, 50, 8, false);

rel->array[= 5].active =3D true;

To view, visit change 1621<= /a>. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I64da2328591ef2b9ee7502e574c= 878651cdf356a
Gerrit-Change-Number: 1621
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --iY0PYTPYgvU=--