From: Chunfeng Yun Date: Wed, 19 Aug 2020 16:27:28 +0800 Subject: [PATCH v2 03/11] phy: mtk-tphy: make shared reg optional for v1 In-Reply-To: <20200819080225.4267-4-linux@fw-web.de> References: <20200819080225.4267-1-linux@fw-web.de> <20200819080225.4267-4-linux@fw-web.de> Message-ID: <1597825648.23067.0.camel@mhfsdcap03> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2020-08-19 at 10:02 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > make the shared reg optional when version is v1 for sata > > Suggested-by: Chunfeng Yun > Signed-off-by: Frank Wunderlich > --- > drivers/phy/phy-mtk-tphy.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/phy-mtk-tphy.c b/drivers/phy/phy-mtk-tphy.c > index 326227a30d..3d7b9cd2b1 100644 > --- a/drivers/phy/phy-mtk-tphy.c > +++ b/drivers/phy/phy-mtk-tphy.c > @@ -698,11 +698,10 @@ static int mtk_tphy_probe(struct udevice *dev) > tphy->dev = dev; > tphy->version = dev_get_driver_data(dev); > > - /* v1 has shared banks */ > + /* v1 has shared banks for usb/pcie mode, */ > + /* but not for sata mode */ > if (tphy->version == MTK_TPHY_V1) { > tphy->sif_base = dev_read_addr_ptr(dev); > - if (!tphy->sif_base) > - return -ENOENT; > } Reviewed-by: Chunfeng Yun Thanks > > dev_for_each_subnode(subnode, dev) {