From: David Howells Subject: Re: [PATCH 05/18] [PATCH] BLOCK: Don't call block_sync_page() from AFS [try #4] Date: Tue, 29 Aug 2006 13:25:08 +0100 Message-ID: <15995.1156854308@warthog.cambridge.redhat.com> References: <20060829115737.GB32714@infradead.org> <20060825193658.11384.8349.stgit@warthog.cambridge.redhat.com> <20060825193709.11384.79794.stgit@warthog.cambridge.redhat.com> <20060827212136.GA12710@tuatara.stupidest.org> Cc: Chris Wedgwood , David Howells , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:45205 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751347AbWH2MZY (ORCPT ); Tue, 29 Aug 2006 08:25:24 -0400 In-Reply-To: <20060829115737.GB32714@infradead.org> To: Christoph Hellwig Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > AFS never sets a backing_dev_info on it's own and thus uses > &default_backing_dev_info which sets the unplug_io_fn to > default_unplug_io_fn. default_unplug_io_fn is a no-op, and thus > block_sync_page does nothing for AFS. I'm sure I used to require this for when there was a local cache on disk. Maybe things have changed, or maybe I'm misremembering. David