From: Sagar Arun Kamble Subject: Re: [PATCH] drm/i915/guc: Unify parameters of public CT functions Date: Tue, 20 Mar 2018 12:54:14 +0530 Message-ID: <159b2d9e-c023-fb62-308e-334384886ccd@intel.com> References: <20180319152828.41564-1-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 599FF6E666 for ; Tue, 20 Mar 2018 07:24:19 +0000 (UTC) In-Reply-To: <20180319152828.41564-1-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAzLzE5LzIwMTggODo1OCBQTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBUaGVyZSBp cyBubyBuZWVkIHRvIG1peCBwYXJhbWV0ZXIgdHlwZXMgaW4gcHVibGljIENUIGZ1bmN0aW9ucwo+ IGFzIHdlIGNhbiBhbHdheXMgYWNjZXB0IGludGVsX2d1Y19jdC4KPgo+IFNpZ25lZC1vZmYtYnk6 IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBTYWdh ciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Y19jdC5jIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmggfCAgNiArKy0tLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgICAgIHwgIDQgKystLQo+ICAgMyBmaWxl cyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfY3QuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Y19jdC5jCj4gaW5kZXggMGEwZDNkNS4uN2RkN2RlMCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfY3QuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5jCj4gQEAgLTI4LDEyICsyOCwyMSBAQAo+ICAgCj4g ICBlbnVtIHsgQ1RCX09XTkVSX0hPU1QgPSAwIH07Cj4gICAKPiArLyoqCj4gKyAqIGludGVsX2d1 Y19jdF9pbml0X2Vhcmx5IC0gSW5pdGlhbGl6ZSBDVCBzdGF0ZSB3aXRob3V0IHJlcXVpcmluZyBk ZXZpY2UgYWNjZXNzCj4gKyAqIEBjdDogcG9pbnRlciB0byBDVCBzdHJ1Y3QKPiArICovCj4gICB2 b2lkIGludGVsX2d1Y19jdF9pbml0X2Vhcmx5KHN0cnVjdCBpbnRlbF9ndWNfY3QgKmN0KQo+ICAg ewo+ICAgCS8qIHdlJ3JlIHVzaW5nIHN0YXRpYyBjaGFubmVsIG93bmVycyAqLwo+ICAgCWN0LT5o b3N0X2NoYW5uZWwub3duZXIgPSBDVEJfT1dORVJfSE9TVDsKPiAgIH0KPiAgIAo+ICtzdGF0aWMg aW5saW5lIHN0cnVjdCBpbnRlbF9ndWMgKmN0X3RvX2d1YyhzdHJ1Y3QgaW50ZWxfZ3VjX2N0ICpj dCkKPiArewo+ICsJcmV0dXJuIGNvbnRhaW5lcl9vZihjdCwgc3RydWN0IGludGVsX2d1YywgY3Qp Owo+ICt9Cj4gKwo+ICAgc3RhdGljIGlubGluZSBjb25zdCBjaGFyICpndWNfY3RfYnVmZmVyX3R5 cGVfdG9fc3RyKHUzMiB0eXBlKQo+ICAgewo+ICAgCXN3aXRjaCAodHlwZSkgewo+IEBAIC00MTYs MTYgKzQyNSwxOSBAQCBzdGF0aWMgaW50IGludGVsX2d1Y19zZW5kX2N0KHN0cnVjdCBpbnRlbF9n dWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4pCj4gICB9Cj4gICAKPiAgIC8qKgo+ IC0gKiBFbmFibGUgYnVmZmVyIGJhc2VkIGNvbW1hbmQgdHJhbnNwb3J0Cj4gKyAqIGludGVsX2d1 Y19jdF9lbmFibGUgLSBFbmFibGUgYnVmZmVyIGJhc2VkIGNvbW1hbmQgdHJhbnNwb3J0Lgo+ICsg KiBAY3Q6IHBvaW50ZXIgdG8gQ1Qgc3RydWN0Cj4gKyAqCj4gICAgKiBTaGFsbCBvbmx5IGJlIGNh bGxlZCBmb3IgcGxhdGZvcm1zIHdpdGggSEFTX0dVQ19DVC4KPiAtICogQGd1YzoJdGhlIGd1Ywo+ IC0gKiByZXR1cm46CTAgb24gc3VjY2Vzcwo+IC0gKgkJbm9uLXplcm8gb24gZmFpbHVyZQo+ICsg Kgo+ICsgKiBSZXR1cm5zOgo+ICsgKiAwIG9uIHN1Y2Nlc3MsIGEgbmVnYXRpdmUgZXJybm8gY29k ZSBvbiBmYWlsdXJlLgpTaG91bGQgYmUKIMKgwqDCoMKgICogUmV0dXJuOiAwIG9uIHN1Y2VzcyAu Li4KPiAgICAqLwo+IC1pbnQgaW50ZWxfZ3VjX2VuYWJsZV9jdChzdHJ1Y3QgaW50ZWxfZ3VjICpn dWMpCj4gK2ludCBpbnRlbF9ndWNfY3RfZW5hYmxlKHN0cnVjdCBpbnRlbF9ndWNfY3QgKmN0KQo+ ICAgewo+ICsJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gY3RfdG9fZ3VjKGN0KTsKPiAgIAlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwpjaGFuZ2Ug dG8gKmk5MTUgYXMgcGFydCBvZiB0aGlzIHBhdGNoIGl0c2VsZj8gOikgc2ltaWxhciBmb3IgZGlz YWJsZS4KT3RoZXJ3aXNlIExHVE0KUmV2aWV3ZWQtYnk6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdh ci5hLmthbWJsZUBpbnRlbC5jb20+Cj4gLQlzdHJ1Y3QgaW50ZWxfZ3VjX2N0X2NoYW5uZWwgKmN0 Y2ggPSAmZ3VjLT5jdC5ob3N0X2NoYW5uZWw7Cj4gKwlzdHJ1Y3QgaW50ZWxfZ3VjX2N0X2NoYW5u ZWwgKmN0Y2ggPSAmY3QtPmhvc3RfY2hhbm5lbDsKPiAgIAlpbnQgZXJyOwo+ICAgCj4gICAJR0VN X0JVR19PTighSEFTX0dVQ19DVChkZXZfcHJpdikpOwo+IEBAIC00NDEsMTQgKzQ1MywxNiBAQCBp bnQgaW50ZWxfZ3VjX2VuYWJsZV9jdChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICB9Cj4gICAK PiAgIC8qKgo+IC0gKiBEaXNhYmxlIGJ1ZmZlciBiYXNlZCBjb21tYW5kIHRyYW5zcG9ydC4KPiAr ICogaW50ZWxfZ3VjX2N0X2Rpc2FibGUgLSBEaXNhYmxlIGJ1ZmZlciBiYXNlZCBjb21tYW5kIHRy YW5zcG9ydC4KPiArICogQGN0OiBwb2ludGVyIHRvIENUIHN0cnVjdAo+ICsgKgo+ICAgICogU2hh bGwgb25seSBiZSBjYWxsZWQgZm9yIHBsYXRmb3JtcyB3aXRoIEhBU19HVUNfQ1QuCj4gLSAqIEBn dWM6IHRoZSBndWMKPiAgICAqLwo+IC12b2lkIGludGVsX2d1Y19kaXNhYmxlX2N0KHN0cnVjdCBp bnRlbF9ndWMgKmd1YykKPiArdm9pZCBpbnRlbF9ndWNfY3RfZGlzYWJsZShzdHJ1Y3QgaW50ZWxf Z3VjX2N0ICpjdCkKPiAgIHsKPiArCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGN0X3RvX2d1Yyhj dCk7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUo Z3VjKTsKPiAtCXN0cnVjdCBpbnRlbF9ndWNfY3RfY2hhbm5lbCAqY3RjaCA9ICZndWMtPmN0Lmhv c3RfY2hhbm5lbDsKPiArCXN0cnVjdCBpbnRlbF9ndWNfY3RfY2hhbm5lbCAqY3RjaCA9ICZjdC0+ aG9zdF9jaGFubmVsOwo+ICAgCj4gICAJR0VNX0JVR19PTighSEFTX0dVQ19DVChkZXZfcHJpdikp Owo+ICAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmgKPiBpbmRleCA2ZDk3ZjM2Li41 OTVjOGFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19jdC5o Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2N0LmgKPiBAQCAtNzgsOSAr NzgsNyBAQCBzdHJ1Y3QgaW50ZWxfZ3VjX2N0IHsKPiAgIH07Cj4gICAKPiAgIHZvaWQgaW50ZWxf Z3VjX2N0X2luaXRfZWFybHkoc3RydWN0IGludGVsX2d1Y19jdCAqY3QpOwo+IC0KPiAtLyogWFhY OiBtb3ZlIHRvIGludGVsX3VjLmggPyBkb24ndCBmaXQgdGhlcmUgZWl0aGVyICovCj4gLWludCBp bnRlbF9ndWNfZW5hYmxlX2N0KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gLXZvaWQgaW50ZWxf Z3VjX2Rpc2FibGVfY3Qoc3RydWN0IGludGVsX2d1YyAqZ3VjKTsKPiAraW50IGludGVsX2d1Y19j dF9lbmFibGUoc3RydWN0IGludGVsX2d1Y19jdCAqY3QpOwo+ICt2b2lkIGludGVsX2d1Y19jdF9k aXNhYmxlKHN0cnVjdCBpbnRlbF9ndWNfY3QgKmN0KTsKPiAgIAo+ICAgI2VuZGlmIC8qIF9JTlRF TF9HVUNfQ1RfSF8gKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiBpbmRleCAzNGU4NDdkLi5h NDVjMmNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gQEAgLTIzMiw3ICsyMzIsNyBA QCBzdGF0aWMgaW50IGd1Y19lbmFibGVfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpn dWMpCj4gICAJZ2VuOV9lbmFibGVfZ3VjX2ludGVycnVwdHMoZGV2X3ByaXYpOwo+ICAgCj4gICAJ aWYgKEhBU19HVUNfQ1QoZGV2X3ByaXYpKQo+IC0JCXJldHVybiBpbnRlbF9ndWNfZW5hYmxlX2N0 KGd1Yyk7Cj4gKwkJcmV0dXJuIGludGVsX2d1Y19jdF9lbmFibGUoJmd1Yy0+Y3QpOwo+ICAgCj4g ICAJZ3VjLT5zZW5kID0gaW50ZWxfZ3VjX3NlbmRfbW1pbzsKPiAgIAlyZXR1cm4gMDsKPiBAQCAt MjQzLDcgKzI0Myw3IEBAIHN0YXRpYyB2b2lkIGd1Y19kaXNhYmxlX2NvbW11bmljYXRpb24oc3Ry dWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gICAKPiAgIAlpZiAoSEFTX0dVQ19DVChkZXZfcHJpdikp Cj4gLQkJaW50ZWxfZ3VjX2Rpc2FibGVfY3QoZ3VjKTsKPiArCQlpbnRlbF9ndWNfY3RfZGlzYWJs ZSgmZ3VjLT5jdCk7Cj4gICAKPiAgIAlnZW45X2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoZGV2X3By aXYpOwo+ICAgCgotLSAKVGhhbmtzLApTYWdhcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==