From: David Howells Subject: Re: [PATCH] fscache: check consistency does not decrement refcount Date: Tue, 10 Sep 2013 13:34:33 +0100 Message-ID: <16357.1378816473@warthog.procyon.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cachefs-bounces@redhat.com Errors-To: linux-cachefs-bounces@redhat.com To: Milosz Tanski Cc: sage@inktank.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, zheng.z.yan@intel.com, ceph-devel@vger.kernel.org List-Id: ceph-devel.vger.kernel.org Milosz Tanski wrote: > __fscache_check_consistency() does not decrement the count of operations > active after it finishes in the success case. This leads to a hung tasks on > cookie de-registration (commonly in inode eviction). > > INFO: task kworker/1:2:4214 blocked for more than 120 seconds. > kworker/1:2 D ffff880443513fc0 0 4214 2 0x00000000 > Workqueue: ceph-msgr con_work [libceph] > ... > Call Trace: > [] ? _raw_spin_unlock_irqrestore+0x16/0x20 > [] ? fscache_wait_bit_interruptible+0x30/0x30 [fscache] > [] schedule+0x29/0x70 > [] fscache_wait_atomic_t+0xe/0x20 [fscache] > [] out_of_line_wait_on_atomic_t+0x9f/0xe0 > [] ? autoremove_wake_function+0x40/0x40 > [] __fscache_relinquish_cookie+0x15c/0x310 [fscache] > [] ceph_fscache_unregister_inode_cookie+0x3e/0x50 [ceph] > [] ceph_destroy_inode+0x33/0x200 [ceph] > [] ? __fsnotify_inode_delete+0xe/0x10 > [] destroy_inode+0x3c/0x70 > [] evict+0x119/0x1b0 > > Signed-off-by: Milosz Tanski Acked-by: David Howells