Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 208A2C4332F for ; Tue, 8 Mar 2022 06:42:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63843820AC; Tue, 8 Mar 2022 07:42:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="NP47T+TS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CDBCA830F3; Tue, 8 Mar 2022 07:42:43 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3DCD58309E for ; Tue, 8 Mar 2022 07:42:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ye.li@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwerGhn9xMoi7bqX9UtvyTpNtTW17L03KmsgH63WS8uWomNmJSX/S3uKNjVZ9KCc8/2v7M4/YuNb+nJSqaZvYmzpcSmEamgj1zhUYwa8ZtqD48LMueCNXIipTQtG4zIvod+DOEUOFBLvKARe63CtoIWIFdF6JKUrKCZmPCtMZAeLaZSLRhFkQ2xxjiFA0prfm4cR53lcj8r2wmUIbgEf1iofsIK5HG8m8qvqBGFNWIB6sgKCChHNTMKTamIndQ0Ha/3X7zC5sP3b4n6qfn/lHf1ZLt2qqfGip08fVlrolvNZ2yHa87KCqeL/Jlu7nR1vgK/Lf7IebcJqZNZBSF0ssw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ewCoXjFNcE6EaLiQdPm7QhxLqT+TSylI4mHKZtYJmdI=; b=WufIifZloquUKlyHOTzBxV0NfQ4NSd7WmEkkrkuxm7pH2PPeVGPdAe8Rc9VmQWGSgaye5hnwLc9xPROhQ/axZdEJjwl6uns58oIZ8Ck5SVPE08i/ZvrzC2iaq5cbbhoDBKXVPn9uS42lviepO9U4eBXRHFU2prAC6TYJJWhEwbZJ9BwtqZsi+dYMOU0fPODU0jTQQoqt/O7U9W4RRxgXwSq/IBcWmfTc0o3xVanUVX39UA3dssVl3h5gj1Nk4NEoq9D4eGf1Mp6Mg8GdxpmQdxDS/AvszWoj7RwljyenP5NfsvI2g9v39daTQQPSev/pguHxs074oU1fa5bSrSxfcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewCoXjFNcE6EaLiQdPm7QhxLqT+TSylI4mHKZtYJmdI=; b=NP47T+TSqVca02L7BW64ERc85S57Ab76a1YqotL6Mc2QjSKWpmmgwkjnZWHaM9TLnExARrK/wgZDUWKHbefdgCB8Z3ZMDnD5V4flwq1k2mKbm02muY7ZIBE+8lwEq/rJr1eShzbakBmk5fcFvywzjrv1UsItKdfDzcJPC05FKNg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from GV1PR04MB9136.eurprd04.prod.outlook.com (2603:10a6:150:27::21) by AM5PR0402MB2915.eurprd04.prod.outlook.com (2603:10a6:203:9c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Tue, 8 Mar 2022 06:42:38 +0000 Received: from GV1PR04MB9136.eurprd04.prod.outlook.com ([fe80::e5df:b33:3415:24b0]) by GV1PR04MB9136.eurprd04.prod.outlook.com ([fe80::e5df:b33:3415:24b0%6]) with mapi id 15.20.5038.027; Tue, 8 Mar 2022 06:42:38 +0000 From: Ye Li To: sbabic@denx.de, u-boot@lists.denx.de, festevam@gmail.com Cc: uboot-imx@nxp.com, dario.binacchi@amarulasolutions.com Subject: [PATCH] imx: Revert "imx: mx6ull: fix REFTOP_VBGADJ setting" and fix comments Date: Tue, 8 Mar 2022 14:42:15 +0800 Message-Id: <1646721735-125430-1-git-send-email-ye.li@nxp.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: HK0PR01CA0071.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::35) To GV1PR04MB9136.eurprd04.prod.outlook.com (2603:10a6:150:27::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b8fc540-9984-47e2-5a96-08da00ced5ed X-MS-TrafficTypeDiagnostic: AM5PR0402MB2915:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vazoh1I/NtMfuAGyLbTzypYXdENoskkGX+UVT2CasHHSPwNCpj/oIE3VR/Cv7tU/IoDpcCI79MIrQNQmPBuZftz3S4P4cJygVkBTTsv5bfPx9zPjnD6XVZVk3jkxDWtn+0LXCtHPO633xBjl0+g3y9RY1xTGGruT+ft8XiX89OrKSI8/XZoUyvDzVkjIhVtXhonvMYAMV9dEaaEwiRssBD62bSxzjZhkI8WStVAE4bOBkToeXWo3CbIEiOmV0PYmC93MkllZZB8DbM7lhSMmeX6lSqFrP+O+55vUTOt+2rDPbj4DNS97IFKCnF9jlJGzzEoJYj8d2gkcjnh8amsmfZQjrUG1mmEf3P4MGVh9+Bp/g0vM2xgpuLj4BoHNfQ3i6SXsAjK2lm9bD0HLNfdr16NshWdgpj423hTrV+ZHS5l1xF7ET2lf4PSXjKmvQyKWygEqW3mPkeM9mONknjKL+wss2Li2y2vsuRRwfEFesZdbi6zV0VUNP9+ecvCLusGlX+2Jpi0ddRAgFocCjMb3P3JfIt8psrTbHi3xGWqKT/ZGjvIqxsIzL7aTLtdK5ZSqb3SyF3GFkxyboUJ6XRDTT5wfPk+HjfDfDvifYFgIGJ8VK+0E0owT0Lfy97RQHzfqB4f/9kGaR+I/vsbjcSB3iiwYadf2P/W3yGC/F5RkctU3OgcLQSQgQkCdJF5EK45w/MyD6RFdOCwxSG1EELk4r7kcezxAYrv4d8Pu+hUskt0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR04MB9136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(5660300002)(66946007)(4326008)(66476007)(66556008)(8676002)(316002)(44832011)(508600001)(52116002)(6486002)(6506007)(6666004)(6512007)(83380400001)(36756003)(2906002)(38100700002)(38350700002)(2616005)(186003)(86362001)(26005)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w6huYnGn5tw0roL9UTqVjuEwH027Osz54f2YvWd6EoqqUigRvExD/D9XN8o7?= =?us-ascii?Q?V0hk3Jm8h7yGgIh0bS8qSEmAKcCuEczOaAjlp5p/c+UO8Vaqsejz+/F2fvqN?= =?us-ascii?Q?tRe9c/PvppHJ0H3Yce3Kz5loGvJNcEcTxqVNAVQBFOIxXGvb2+yLc12CJFj0?= =?us-ascii?Q?ucUx0Tn8puibAMLecJV0k9KtmUeR7GsvjeLB4zr1KisNCbUeXL5+aEa4k58F?= =?us-ascii?Q?pPs5VuCsnfCXQ+jRqj38m3olsZFm9NtDVaonRgZBsVePxk4p/z7Mdz4c6KFf?= =?us-ascii?Q?x75RffqA2UoRbjjcREU44zqMwll1vGpwxQ3fSPvBquQGsnP0DibiSG/uqMA+?= =?us-ascii?Q?e/pgZYmhQAn/kAtfE0nbNa8tOTFAQu7ouUjzHg0gRIm5FRJuelFgqVSiysyT?= =?us-ascii?Q?20QXNrZFguuW3qJPXBHz0aY2/Hkie2kcNtfbns/60hs8wqM0wEcpZon4tU1p?= =?us-ascii?Q?bLH2mljP4g+5kR4paA4v2PUdoW9w4SGGzXXS0abdHYz5ZTmUgrArA9defWv5?= =?us-ascii?Q?RdZrr4kz4k/M+KYhkAwerYHpA6pjAIKRj483u0V7SGDtyhkdpaS+8ymANREZ?= =?us-ascii?Q?dmKajfnyBYfG1htZJwEZ9SA/+XusV+IxqlprVC9i6r8mysFpTxSfBMp/wbCD?= =?us-ascii?Q?y3sK8rolDWtf5FndU0MU2fL3fPITlx9G9yFZxEw8r+dYWhV/WVg7tOXXzKdc?= =?us-ascii?Q?iJIvavvD2RaDFiuB4bl4db2nhzYfrLFNgF0l9b+fuxkpMPYemItVr9rZUAhx?= =?us-ascii?Q?r4Nz2Crb6dn3MQ6sTJCOxKjX2UxBS8mLKaA5nvXINCHgUwsE5IVUAJ8mALgJ?= =?us-ascii?Q?UTnkfu//8TaSkqtL8yuVX0SO3yUNMJYV7TarQBgJNvdc50Iua2Ntci+a+PFa?= =?us-ascii?Q?khnJU5MlNrr54lS+8S2PcMErJTZnkfqeZ/jgVMXPxXlD4cdGy9zTjDm3EZ+N?= =?us-ascii?Q?rtUV9vGIvytimdvXOk5iI2v3F6AYXFsdZDrcnafuKQh3HrrVmmwRq79rEeNh?= =?us-ascii?Q?8wZLCy+pswOrjbUb5KFR4xPARPs75IAekL4UmFeCIxM1KJ8PBhCDSpAcAKzj?= =?us-ascii?Q?vwJmaAL+YC9VzrzTyoIMMtWAN8d49sV58m8BLQ4KnO5JaQGggGXQOkzaemS4?= =?us-ascii?Q?cc3ye74A+iI/1AuoDV005dUAaQic6rGIzgL624AHzqqIqX2kjW0Y+JKCuf+v?= =?us-ascii?Q?cA4FcD5Ir43AIG9T03z67vFoYkcMueM2FyOxkw7wZD6pZ6/mZxy/Y8UTQA6g?= =?us-ascii?Q?7O8N//xi3/BpX3/cn6Ctl0MzgMKnGilzBY6YImzrCl0yXfyrT89agujxAn2f?= =?us-ascii?Q?syr182XSR+lN5TaiZz5BS+G8jIlo+JXzfS6DePlA3hEf4xAjEWusrjPTK5Im?= =?us-ascii?Q?K28F1QTa73mJFjw34rhiEGrYBszXfnZInon3gvdS+oAB7DuO2IqSumUQannp?= =?us-ascii?Q?L06qG8YUGv/LtiMf/nCzlu0HXbtXS8dk8uCmNKzUwj3rjiAgfTbyVXdc1aMI?= =?us-ascii?Q?If87GcP03Q1zPUmXapAxwLF9M+e924wyR/Yj/+c7/4anXR9c92NpP05SOiCp?= =?us-ascii?Q?FAzXtaf2/n+YqE4achc=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8fc540-9984-47e2-5a96-08da00ced5ed X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 06:42:38.2617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kkSfr/d/uHeGWVSL7uKcc4qZ1eRvMseXV+rmzhB42H8Mvbq2Le/oGYuMtYI57/pv X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2915 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The change in commit c1af358 (imx: mx6ull: fix REFTOP_VBGADJ setting) is not correct. According to latest i.MX6ULL fuse table, the REFTOP_TRIM[2:0] fuse is defined as below. So the previous codes are correct, only need to fix the comments. Set the REFTOP_VBGADJ field in PMU_MISC0 register based on the REFTOP_TRIM fuse: '000" - set REFTOP_VBGADJ[2:0] to 3'b000 '001" - set REFTOP_VBGADJ[2:0] to 3'b001 '010" - set REFTOP_VBGADJ[2:0] to 3'b010 '011" - set REFTOP_VBGADJ[2:0] to 3'b011 '100" - set REFTOP_VBGADJ[2:0] to 3'b100 '101" - set REFTOP_VBGADJ[2:0] to 3'b101 '110" - set REFTOP_VBGADJ[2:0] to 3'b110 '111" - set REFTOP_VBGADJ[2:0] to 3'b111 Signed-off-by: Ye Li --- arch/arm/mach-imx/mx6/soc.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c index 03d8fd7..bb7dc42 100644 --- a/arch/arm/mach-imx/mx6/soc.c +++ b/arch/arm/mach-imx/mx6/soc.c @@ -394,23 +394,21 @@ static void init_bandgap(void) /* * On i.MX6ULL,we need to set VBGADJ bits according to the * REFTOP_TRIM[3:0] in fuse table - * 000 - set REFTOP_VBGADJ[2:0] to 3b'110, - * 110 - set REFTOP_VBGADJ[2:0] to 3b'000, - * 001 - set REFTOP_VBGADJ[2:0] to 3b'001, - * 010 - set REFTOP_VBGADJ[2:0] to 3b'010, - * 011 - set REFTOP_VBGADJ[2:0] to 3b'011, - * 100 - set REFTOP_VBGADJ[2:0] to 3b'100, - * 101 - set REFTOP_VBGADJ[2:0] to 3b'101, - * 111 - set REFTOP_VBGADJ[2:0] to 3b'111, + * 000 - set REFTOP_VBGADJ[2:0] to 3'b000 + * 001 - set REFTOP_VBGADJ[2:0] to 3'b001 + * 010 - set REFTOP_VBGADJ[2:0] to 3'b010 + * 011 - set REFTOP_VBGADJ[2:0] to 3'b011 + * 100 - set REFTOP_VBGADJ[2:0] to 3'b100 + * 101 - set REFTOP_VBGADJ[2:0] to 3'b101 + * 110 - set REFTOP_VBGADJ[2:0] to 3'b110 + * 111 - set REFTOP_VBGADJ[2:0] to 3'b111 */ if (is_mx6ull()) { - static const u32 map[] = {6, 1, 2, 3, 4, 5, 0, 7}; - val = readl(&fuse->mem0); val >>= OCOTP_MEM0_REFTOP_TRIM_SHIFT; val &= 0x7; - writel(map[val] << BM_ANADIG_ANA_MISC0_REFTOP_VBGADJ_SHIFT, + writel(val << BM_ANADIG_ANA_MISC0_REFTOP_VBGADJ_SHIFT, &anatop->ana_misc0_set); } } -- 2.7.4