Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF14C433F5 for ; Wed, 30 Mar 2022 13:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344108AbiC3NcA (ORCPT ); Wed, 30 Mar 2022 09:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346054AbiC3Nb7 (ORCPT ); Wed, 30 Mar 2022 09:31:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4047B37A94 for ; Wed, 30 Mar 2022 06:30:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB841B81ACC for ; Wed, 30 Mar 2022 13:30:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 8B05CC34111; Wed, 30 Mar 2022 13:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648647011; bh=JktdeNgsCfPOibKWgTTiwnF0tFIIx4KUV9D6KhRuCZA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=NL/VjyvbYnw+SWXY5P7Ws4iNvZfpKnQaRWkcMFGNw4EdcJmhopRiUGgGt7khBiz3I tByRU5Oz6w3MOUSBAi4UjM8Cxgrj1cG8BpiIBKq9V22GRcLTgNed4Nt7aW/mAAkTbF NsQ1ugXmqKKF+a1vr+O9KEytyMLOFZw7hQbwA5kmxrRvaBrw31dnbtglP4SMKAN+b0 kCuAp2x2binX+AeIl8hydabDGHGQVDmi9tZeHwiGM1j/kLxzTprz3CBUzTadJ76GiT bbt5JSwQdk+FxtCH+sBzKndKIicCIrVNNO3xSQi7N7dlRkiDLUnRKhAjjELueZud/Q V3m2/APSxdzFQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 6BD6AE6BBCA; Wed, 30 Mar 2022 13:30:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf-next] bpftool: explicit errno handling in skeletons From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164864701143.1602.9317565462778370541.git-patchwork-notify@kernel.org> Date: Wed, 30 Mar 2022 13:30:11 +0000 References: <3b6bfbb770c79ae64d8de26c1c1bd9d53a4b85f8.camel@fb.com> In-Reply-To: <3b6bfbb770c79ae64d8de26c1c1bd9d53a4b85f8.camel@fb.com> To: Delyan Kratunov Cc: daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org, bpf@vger.kernel.org, yhs@fb.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann : On Mon, 21 Mar 2022 23:29:18 +0000 you wrote: > Andrii noticed that since f97b8b9bd630 (bpftool: Fix a bug in subskeleton code generation) > the subskeleton code allows bpf_object__destroy_subskeleton to overwrite > the errno that subskeleton__open would return with. While this is not > currently an issue, let's make it future-proof. > > This patch explicitly tracks err in subskeleton__open and skeleton__create > (i.e. calloc failure is explicitly ENOMEM) and ensures that errno > is -err on the error return path. The skeleton code had to be changed > since maps and progs codegen is shared with subskeletons. > > [...] Here is the summary with links: - [bpf-next] bpftool: explicit errno handling in skeletons https://git.kernel.org/bpf/bpf/c/522574fd7864 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html