From: Nicholas Piggin Date: Thu, 28 Apr 2022 04:12:30 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Initialize AMOR in nested entry Message-Id: <1651118922.7qh15cf4pc.astroid@bobo.none> List-Id: References: <20220425142151.1495142-1-farosas@linux.ibm.com> In-Reply-To: <20220425142151.1495142-1-farosas@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Fabiano Rosas , linuxppc-dev@lists.ozlabs.org Cc: kvm-ppc@vger.kernel.org Excerpts from Fabiano Rosas's message of April 26, 2022 12:21 am: > The hypervisor always sets AMOR to ~0, but let's ensure we're not > passing stale values around. > Reviewed-by: Nicholas Piggin Looks like our L0 doesn't do anything with hvregs.amor ? Thanks, Nick > Signed-off-by: Fabiano Rosas > --- > arch/powerpc/kvm/book3s_hv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 6fa518f6501d..b5f504576765 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -3967,6 +3967,7 @@ static int kvmhv_vcpu_entry_p9_nested(struct kvm_vcpu *vcpu, u64 time_limit, uns > > kvmhv_save_hv_regs(vcpu, &hvregs); > hvregs.lpcr = lpcr; > + hvregs.amor = ~0; > vcpu->arch.regs.msr = vcpu->arch.shregs.msr; > hvregs.version = HV_GUEST_STATE_VERSION; > if (vcpu->arch.nested) { > -- > 2.35.1 > >