Date: Fri, 29 Apr 2022 15:40:22 +0200 (CEST) From: Frank Lichtenheld Message-ID: <1660158989.694251.1651239622072@...2642...> In-Reply-To: <20220422142953.3805364-13-arne@...1227...> References: <20220422134038.3801239-1-arne@...1227...> <20220422142953.3805364-1-arne@...1227...> <20220422142953.3805364-13-arne@...1227...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 22/28] Implement HMAC based session id for tls-crypt v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net One additional small issue: > Arne Schwabe hat am 22.04.2022 16:29 geschrieben: [...] > diff --git a/src/openvpn/ssl_pkt.h b/src/openvpn/ssl_pkt.h > index 75cdc1c58..48b94e952 100644 > --- a/src/openvpn/ssl_pkt.h > +++ b/src/openvpn/ssl_pkt.h > @@ -218,10 +224,12 @@ read_control_auth(struct buffer *buf, > * The returned buf need to be free with \c free_buf > */ > struct buffer > -tls_reset_standalone(struct tls_auth_standalone *tas, > +tls_reset_standalone(struct tls_wrap_ctx *ctx, > + struct tls_auth_standalone *tas, > struct session_id *own_sid, > struct session_id *remote_sid, > - uint8_t header); > + uint8_t header, > + bool b); "b" -> "tlscryptv2" Regards, -- Frank Lichtenheld