Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8292BC28D13 for ; Thu, 25 Aug 2022 07:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbiHYHPP (ORCPT ); Thu, 25 Aug 2022 03:15:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236593AbiHYHPO (ORCPT ); Thu, 25 Aug 2022 03:15:14 -0400 X-Greylist: delayed 306 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 25 Aug 2022 00:15:13 PDT Received: from out30-54.freemail.mail.aliyun.com (unknown [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5BA7170C for ; Thu, 25 Aug 2022 00:15:12 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=gumi@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VNCKOB0_1661411394; Received: from nu1m11355.sqa.nu8.tbsite.net(mailfrom:gumi@linux.alibaba.com fp:SMTPD_---0VNCKOB0_1661411394) by smtp.aliyun-inc.com; Thu, 25 Aug 2022 15:09:59 +0800 From: Gu Mi To: axboe@kernel.dk, damien.lemoal@opensource.wdc.com, bvanassche@acm.org Cc: linux-block@vger.kernel.org, Gu Mi Subject: [PATCH v2] block: I/O error occurs during SATA disk stress test Date: Thu, 25 Aug 2022 15:09:53 +0800 Message-Id: <1661411393-98514-1-git-send-email-gumi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org The problem occurs in two async processes, One is when a new IO calls the blk_mq_start_request() interface to start sending,The other is that the block layer timer process calls the blk_mq_req_expired interface to check whether there is an IO timeout. When an instruction out of sequence occurs between blk_add_timer and WRITE_ONCE(rq->state,MQ_RQ_IN_FLIGHT) in the interface blk_mq_start_request,at this time, the block timer is checking the new IO timeout, Since the req status has been set to MQ_RQ_IN_FLIGHT and req->deadline is 0 at this time, the new IO will be misjudged as a timeout. Our repair plan is for the deadline to be 0, and we do not think that a timeout occurs. At the same time, because the jiffies of the 32-bit system will be reversed shortly after the system is turned on, we will add 1 jiffies to the deadline at this time. Signed-off-by: Gu Mi --- v1->v2: time_after_eq() can handle the overflow, so remove the change on 32-bit in blk_add_timer(). block/blk-mq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4b90d2d..6defaa1 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1451,6 +1451,8 @@ static bool blk_mq_req_expired(struct request *rq, unsigned long *next) return false; deadline = READ_ONCE(rq->deadline); + if (unlikely(deadline == 0)) + return false; if (time_after_eq(jiffies, deadline)) return true; -- 1.8.3.1