Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB8CC2D0A3 for ; Tue, 3 Nov 2020 21:41:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA99E20756 for ; Tue, 3 Nov 2020 21:41:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA99E20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 286FE6E8D5; Tue, 3 Nov 2020 21:41:28 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 489ED6E8D5 for ; Tue, 3 Nov 2020 21:41:26 +0000 (UTC) IronPort-SDR: CsoTENQugIXBCcU81fo8PFsXZSmGmxJ/XqypZCpeJpHs3Ub1Je9eSExHZ+WSBJJxQ7Pnp0zXMA 9sTIM5cZckyw== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="165624162" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="165624162" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 13:41:25 -0800 IronPort-SDR: y+1TSE/ob+sWh8OwbaqZRFrlfsUgQBvvtIilsYupHjYJpaX3ecOk6P2MV7u0xvbmzk+FzImVvq FN1YCc27wxbQ== X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="538643862" Received: from yuchechi-mobl.amr.corp.intel.com (HELO [10.254.64.186]) ([10.254.64.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 13:41:25 -0800 To: Swathi Dhanavanthri , intel-gfx@lists.freedesktop.org References: <20201103015935.3398-1-swathi.dhanavanthri@intel.com> From: Clint Taylor Message-ID: <16656777-a233-a92f-a438-b94ac17afc1a@intel.com> Date: Tue, 3 Nov 2020 13:41:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201103015935.3398-1-swathi.dhanavanthri@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl, dg1: Apply WA_1406941453 to TGL, RKL and DG1 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/2/20 5:59 PM, Swathi Dhanavanthri wrote: > This workaround is applicable only for tgl,rkl and dg1. > > Bspec: 52890, 53273, 53508. > > Signed-off-by: Swathi Dhanavanthri > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index fed9503a7c4e..45c082070bd9 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -1768,6 +1768,11 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) > */ > wa_write_or(wal, GEN7_FF_THREAD_MODE, > GEN12_FF_TESSELATION_DOP_GATE_DISABLE); > + > + /* Wa_1406941453:tgl,rkl,dg1 */ > + wa_masked_en(wal, > + GEN10_SAMPLER_MODE, > + ENABLE_SMALLPL); > } > > if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) || > @@ -1806,13 +1811,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) > FF_DOP_CLOCK_GATE_DISABLE); > } > > - if (IS_GEN(i915, 12)) { > - /* Wa_1406941453:gen12 */ > - wa_masked_en(wal, > - GEN10_SAMPLER_MODE, > - ENABLE_SMALLPL); > - } > - > if (IS_GEN(i915, 11)) { > /* This is not an Wa. Enable for better image quality */ > wa_masked_en(wal, Reviewed-by: Clint Taylor -Clint _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx