Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B40C46467 for ; Mon, 16 Jan 2023 02:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbjAPC3J (ORCPT ); Sun, 15 Jan 2023 21:29:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbjAPC3H (ORCPT ); Sun, 15 Jan 2023 21:29:07 -0500 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EB9272C for ; Sun, 15 Jan 2023 18:29:06 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VZbZNlw_1673836141; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VZbZNlw_1673836141) by smtp.aliyun-inc.com; Mon, 16 Jan 2023 10:29:02 +0800 Message-ID: <1673836131.7281802-2-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH net-next 2/2] virtio_net: Reuse buffer free function Date: Mon, 16 Jan 2023 10:28:51 +0800 From: Xuan Zhuo To: Parav Pandit Cc: , , , Parav Pandit , , , , , References: <20230113223619.162405-1-parav@nvidia.com> <20230113223619.162405-3-parav@nvidia.com> In-Reply-To: <20230113223619.162405-3-parav@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 14 Jan 2023 00:36:19 +0200, Parav Pandit wrote: > virtnet_rq_free_unused_buf() helper function to free the buffer > already exists. Avoid code duplication by reusing existing function. > > Signed-off-by: Parav Pandit Reviewed-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index d45e140b6852..c1faaf11fbcd 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1251,13 +1251,7 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq, > if (unlikely(len < vi->hdr_len + ETH_ZLEN)) { > pr_debug("%s: short packet %i\n", dev->name, len); > dev->stats.rx_length_errors++; > - if (vi->mergeable_rx_bufs) { > - put_page(virt_to_head_page(buf)); > - } else if (vi->big_packets) { > - give_pages(rq, buf); > - } else { > - put_page(virt_to_head_page(buf)); > - } > + virtnet_rq_free_unused_buf(rq->vq, buf); > return; > } > > -- > 2.26.2 >