Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81E07C636CD for ; Tue, 31 Jan 2023 08:46:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D5E5B859C5; Tue, 31 Jan 2023 09:45:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="MkXkOuSJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 52C3D859CF; Tue, 31 Jan 2023 09:44:20 +0100 (CET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2084.outbound.protection.outlook.com [40.107.247.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6D98859ED for ; Tue, 31 Jan 2023 09:43:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ye.li@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U2WHbhcEwmPio23bFWxhXWglfnmYSXGbErMyiMefO+taeIhJvZhgu9DVFyA/RcZ2RrgkAMJoSbP1GItkFdXMCMvf1M90hFev2JAnG+caY1wG7vG9amCt8U02qNEoUoe7uPZU5UyNPNmHjWyo1bGW3Dx7kNgm7VRMvIvXXcEWqZDzqv1Ki7PWa12RTaJeL0tbRo7zh7Vb9YLuSS49MexkX8BLsL2rDAef12p8dyEIQ2D16SU2noZ+H5Cdj1Ws4c5idP0QNfuQCHEnRSXd2jWtITRLCHO6e27XLsyL5YSJsThbbbIRTEYLHT/V/fFb86fgt8uEUA8kPIMMq1VSmEzVsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQu+MHcHkx2asMlNRFQfILb47Y+Hxv5Hzl8+qDMwEZQ=; b=fKgwZOM10N0e2Wfa3bFTiEzhteVcOUJCMX0VssBkRHN0OCH5UcfFq6bL/NauAVGu4sj0tp9zRCKXXJSSRSGrF6uh4qnsNv2+Ey6CA7xl5P/XjBeJbP3PPSCTFtIRsvv7ygd+LeqFT3XMzDDl0uU0NCcq/6U+K4ByMqrXBgXaZ2/Xv/4IueCKEO+jlwAjOrdaGcxEvg9rL6IlcUyPhSA/LcCqMXwbYNseifcPZP4tYwsGDXbN2GT36I9YbJmPwzOwOJ22WBs9traZBJ/CYW2ch5s91hIjm8DHe2II7KwM38u3hFJEneCrtfAQSMPZtabjWvpRp8WYcDdEfMQ6ELyVjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jQu+MHcHkx2asMlNRFQfILb47Y+Hxv5Hzl8+qDMwEZQ=; b=MkXkOuSJUdolY3i5ml1avPRGSFoTO81umHUZYU4Ojhkb6d4LsyMW9U6Zvn10ObKZONZhSnyIyTJp0gLr8gz88V3xkypgVqYssoPmAAjSSMzHRt3biH9b1JM57uuNwr/VVdZSdYPOO0GJ7PxywF2uk14gZ2jRffxyCSG/fniDFsc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) by AM0PR04MB7154.eurprd04.prod.outlook.com (2603:10a6:208:19f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 31 Jan 2023 08:43:20 +0000 Received: from AM6PR04MB5302.eurprd04.prod.outlook.com ([fe80::1582:1a4a:3dda:50c6]) by AM6PR04MB5302.eurprd04.prod.outlook.com ([fe80::1582:1a4a:3dda:50c6%5]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 08:43:20 +0000 From: Ye Li To: sbabic@denx.de, u-boot@lists.denx.de Cc: peng.fan@nxp.com, uboot-imx@nxp.com Subject: [PATCH 11/23] imx: imx8ulp: upower: replace magic number with macro Date: Tue, 31 Jan 2023 16:42:22 +0800 Message-Id: <1675154554-88217-12-git-send-email-ye.li@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1675154554-88217-1-git-send-email-ye.li@nxp.com> References: <1675154554-88217-1-git-send-email-ye.li@nxp.com> Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0065.apcprd02.prod.outlook.com (2603:1096:4:54::29) To AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5302:EE_|AM0PR04MB7154:EE_ X-MS-Office365-Filtering-Correlation-Id: 443fff69-0d99-43f1-707f-08db0367344f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dzsHLQ7sUYizt//oV2gd+2HHprFgGjZBZIWzVtvgr+PR8bYXr63q+IXZTN3WkZzQ7VPBxQdJJsnzg/NRzcqdiWHAiLyoFhNW9uRZZn25I8dzvr36ToIiL6ILmg37XrrHOG8kg1RUkkFlC/xyIadBJ3lDjZn0rYMHGYpoeVaoCLWEUjPOMpMsJtYuVCHccnlhu5kJL780CjTJrfzIA7BbEa5xURfzxU58cnuprnsAVg60J5LyuLCqlOk3PZy67ij/twQGRS45g7mNX2C83ea1+2aB8upr8+VZdY2yHl9ogMU8qftqsATYVBsJvbimjln/o9lFjSoDzEri1AmEtHPo85xIg9eEs+Flql9l3wYtNHfx0fMYF9hJrHCRIMJeZMGSuIh+fXSdHbZCc1wlP+M8Tbv7vBQBT5S7CyeRgXovWY9LzO+fi+7L9CkAwkJ+P8RsZC386DsITfJQr3AhbiFXzX0j5pYq0OuRs9wJ5Ii/bQA7M/usMKxuj8zPoZBAmolaHRDx7ixnYoTbwEGq/DLi7Zl7QwVu/5m+1HHh7iBiwSlMmczKSyv+FKQIHAt7v/LNtwu4RdSQN59iVWZRYKNITRlnBsDUDw+IiVkycxiXSBJmMdduAi02Ci5K+N4DvWG06szAljgxrQLSwwzZAaiDYnE3/1rNDuTjmYEXOPsXd7nyJZUStKG7trJBrkWrLL5HNbCKOgwMEE8xOTxR9lz9shcjcekd0J5h7pJp6T4jrJM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5302.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199018)(41300700001)(83380400001)(86362001)(2616005)(36756003)(38100700002)(38350700002)(316002)(8676002)(66476007)(66556008)(6506007)(4326008)(6486002)(26005)(478600001)(6512007)(52116002)(66946007)(2906002)(186003)(44832011)(5660300002)(8936002)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4lS4tRswATKexT+6HoaVoQcIJ3/JkEHO2UAptZPZZCsD0vaZf2sILJ0zdG95?= =?us-ascii?Q?9AgFnEnDNLREe9CTQCZY66JUACQW/3D/IU+Upgda75uOFOY1MAPTKbTIOqhP?= =?us-ascii?Q?31LWuLrBScUEI4T6PPiIVtpcUOPGTfJg/g+sTrYWQGGv/InLp5TBPP4dFVXY?= =?us-ascii?Q?xsk9+gV54DD+sZ0ZDewYhFdhjtIjB/or7wWZ/PK6PG8sKCIDQjSVqnV0X/uX?= =?us-ascii?Q?MK2KspQqkdjwV4DGydaEfIwxEaXLSEZI98iZNZsyB6I9WatUAiWRD7XETr2g?= =?us-ascii?Q?XlZItg6NYTqkA1V4QGSER6+s2R6V8Nc42tKQGzHCrGk1ONkHK6Tm1JSRO9/C?= =?us-ascii?Q?VoEKE84r1KcTV6oU/KPqSM3Bg9wY6nPoPbLO3DJYOoiOATGWF0PAdX1uxKKM?= =?us-ascii?Q?j33bsrj/JMIJFD22OmvA1Nruk031tGnG4dCDqR7O3myoIevG98JQm1ird9Fo?= =?us-ascii?Q?dWdUYbFpexXHEcpXRLa1q5U4keHQvdxuf9CX6h/fw3jkPG86NVM/TsoyRCmV?= =?us-ascii?Q?8y665MM2eLK0kFscRGRhR+0KcensCY7PDqDTkPU+DbHoY9JoA0BdtjBoRINw?= =?us-ascii?Q?XwE0gVSYU4XTiViPNypo164vzzYXvgYIF6CURmVmFcVSyppZdPnEFcrLkNgC?= =?us-ascii?Q?d1anKdZQGp3Gc2T5dB6bvGUp4W+tucO2yRB1fv2ubaXaZssCi+F4Om+I8hbA?= =?us-ascii?Q?9CKbLkOnus5vYzd6GP7DsrF1qNWMdedi2OjejJsArjQ3x1KmdZtIDxAXRb0I?= =?us-ascii?Q?i279IKwvqBwMZGXrAlQmXERmqXPj1YFVUitspQhHb+cHr53eB0Kt2cOybMM9?= =?us-ascii?Q?bSb/iyXIIqhjvReucWKif9ZiMu3Qyqt0/OZCnLsxpfH4SsCQQtFiFgvqyKTC?= =?us-ascii?Q?lsNasLRrdGN9VRc/o7oJoqYPJCs29x7oGYGceB/P5TCt34bXFQ5habsgsjSS?= =?us-ascii?Q?a9qI2/wgeqo1piahMFfktYNAgFL4iduCA6WX/c67ONFdppjek8Qp+gw50q+r?= =?us-ascii?Q?OHAa1msaFYIdr0KJoRS8OYRurWmSymzsE9S0hJivMAFc3hIrZ8pxPBfCuCO2?= =?us-ascii?Q?Min2+i7Tx5blj0VEzuy/yEthTrx9HSovK6KE4AbJ4WwD+0qMCNUfiwyHcv1T?= =?us-ascii?Q?6FL89jTGoTqiVeMlPdvlU0+IZKXOeL8QKohS1rVmphHxj/KiwjZQ9GA4AV/q?= =?us-ascii?Q?MGcoQOWwjEXwbr2HqOwEElgdFvGP8e626ZtSfouyXCYhb8UwQ+uxYsyS4DnD?= =?us-ascii?Q?BHEHxClUodrw7gCwi/poWQI8M1o+J1VNrqoVTudlEcUe50KOGjH+UQFH3VFp?= =?us-ascii?Q?MQOeusjGhXkqBRIy5gQbO4ZmItcvCusCOrd3gRDZfy5jzCUHHZ6saKykT1Pk?= =?us-ascii?Q?hTxG2m4fPE4Z1H/w1EGmaYytgQwlY3k9Xc0mILnASqgKM6pPcKFgdY9QPKSZ?= =?us-ascii?Q?dg6ZfgY652zdvalPmskalqxjL0b9oe0WiIS0+yvpe7XqEBtDG9uaKME7093f?= =?us-ascii?Q?7YuNUdGM3gzHzhfc2MdngdNFhfSf7qn7MPit1DlS7VSUYopQSvZF+ZT5fL/M?= =?us-ascii?Q?U57oi/x900GNK2Xfk36Lx7+KRl6LM3rICqqlFvrC?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 443fff69-0d99-43f1-707f-08db0367344f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5302.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 08:43:20.0161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /FFDAVOPUO9GGMOwDJAny7o/a03/cVVre9oUosZsDNkSiuDdVswd307y45CA1zdo X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7154 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Peng Fan The swton indicates the logic switch, magic number 0xfff80 is hard to understand, so use macro. Some board design may not have MIPI_CSI voltage input connected per data sheet. In that case, the upower power on API may dead loop mu to wait response, however there is no response. So remove MIPI_CSI here, let linux power domain driver to runtime enable the power domain. Reviewed-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8ulp/upower/upower_hal.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c b/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c index b6811d5..370685e 100644 --- a/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c +++ b/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c @@ -11,6 +11,25 @@ #include "upower_api.h" #define UPOWER_AP_MU1_ADDR 0x29280000 + +#define PS_RTD BIT(0) +#define PS_DSP BIT(1) +#define PS_A35_0 BIT(2) +#define PS_A35_1 BIT(3) +#define PS_L2 BIT(4) +#define PS_FAST_NIC BIT(5) +#define PS_APD_PERIPH BIT(6) +#define PS_GPU3D BIT(7) +#define PS_HIFI4 BIT(8) +#define PS_DDR GENMASK(12, 9) +#define PS_PXP_EPDC BIT(13) +#define PS_MIPI_DSI BIT(14) +#define PS_MIPI_CSI BIT(15) +#define PS_NIC_LPAV BIT(16) +#define PS_FUSION_AO BIT(17) +#define PS_FUSE BIT(18) +#define PS_UPOWER BIT(19) + static struct mu_type *muptr = (struct mu_type *)UPOWER_AP_MU1_ADDR; void upower_wait_resp(void) @@ -140,7 +159,8 @@ int upower_init(void) } } while (0); - swton = 0xfff80; + swton = PS_UPOWER | PS_FUSE | PS_FUSION_AO | PS_NIC_LPAV | PS_PXP_EPDC | PS_DDR | + PS_HIFI4 | PS_GPU3D | PS_MIPI_DSI; ret = upwr_pwm_power_on(&swton, NULL, NULL); if (ret) printf("Turn on switches fail %d\n", ret); -- 2.7.4