Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0787C636CC for ; Tue, 31 Jan 2023 08:46:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6E413859D8; Tue, 31 Jan 2023 09:45:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Z8i06UvM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60FDB859F6; Tue, 31 Jan 2023 09:44:28 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3CD6859BF for ; Tue, 31 Jan 2023 09:43:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ye.li@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1pkt7gXtYFmGgSX1JcdUqc2fl9FnsRRxb1QcpQ/qa8PgaLGEGk1NdeyUQCNbYhR+HsbfUfNfBT7GnboPBJc3pZG7GSc/8XId0P7WnLpAXv5h6IOll3MjCI5t/HS4DyKLMKvW8rbp/aBb9T8wXB28OTegDo9v/w7eAHymao/HFM8+YPLyq6K2LFx8sSqrXlyTIZjzaHURaLWbo3GaWZ8egiWriSWq9wiRuHebn1dKOZdWhqBmYsjEEWzW4mIC3g8qmgkTJldogdXYO1M4VgW5YhUHcHJzVfOp1PDCa4dpGKs3Gzt2oNohylgZ4Pdq36gamVhiaGEWbHRd4mbUhFGXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKcfsWPX8KbDJGeRrvG3BInoXJ7L2eJHLu7PDwKU5R0=; b=AWbbNVVVDqIInwhuc0wBcm236UbqAzvGcSn7pQ/K1brIQWvZ0gZs37TPxipFUuSwgAvUpo4y4y2ZE0fDkgfAJTEY1Uxal0S1WCjKeDkxdLIGpBvGSGFcZCDOjN3yQBGU2OMEIz/QEo7+J3lIAwVSMMDk2xo6a7AqrCn/O5yAqHTFENR5aUPWOiPPN4cWrFo2NQvvSKGCWXhGiHuyC+pv5lzFIi1/a2Xnjtw7SdopCJba7Usttmx3GtDM421r3dnWzhkJPWOdxxDLqE1Hbv39cDLQQxUpreuGowvNdc3/KiMyADbeq/fPNnrYrmosRykddQqn8+lvvDbOcVZtlxQ+1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XKcfsWPX8KbDJGeRrvG3BInoXJ7L2eJHLu7PDwKU5R0=; b=Z8i06UvMyejXAAHYDCFkT0BkryfTOz2SoO8fUgD0LWhyqtDAgByQ0CbG7WkCwdL0wXSomdbB90BPxKAOn8BzNBYPCV3rwOEy9djPtecBnSMxBxNpZyvV6lPTzBEfZRog70XF5E+oJKyG3WXrkMaoMA9dSXRKxiiopP0aYK/pz1c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) by GV1PR04MB9086.eurprd04.prod.outlook.com (2603:10a6:150:21::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.28; Tue, 31 Jan 2023 08:43:22 +0000 Received: from AM6PR04MB5302.eurprd04.prod.outlook.com ([fe80::1582:1a4a:3dda:50c6]) by AM6PR04MB5302.eurprd04.prod.outlook.com ([fe80::1582:1a4a:3dda:50c6%5]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 08:43:22 +0000 From: Ye Li To: sbabic@denx.de, u-boot@lists.denx.de Cc: peng.fan@nxp.com, uboot-imx@nxp.com Subject: [PATCH 12/23] imx: imx8ulp: upower: make code cleaner Date: Tue, 31 Jan 2023 16:42:23 +0800 Message-Id: <1675154554-88217-13-git-send-email-ye.li@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1675154554-88217-1-git-send-email-ye.li@nxp.com> References: <1675154554-88217-1-git-send-email-ye.li@nxp.com> Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0065.apcprd02.prod.outlook.com (2603:1096:4:54::29) To AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5302:EE_|GV1PR04MB9086:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fc43aaf-7a16-4dfb-a897-08db036735b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t0eyTRm9Sf/8WoOtDHsZepElXB32UHOZXqXJnYqBkEAtCoYpOxR/mNZpA5oEIuIe7evIU+k7sVfTe83OH0CFJDoi3YDEqBSc2O3H6JFoUBb0t7002rl5RDedN7VG9SCNT0u5o9GRiSzA/gRCeChA4Dy63TFjts9uDHkWqxcXhZEP9Q+7hjW0NCSl/xfAPoKGH3d2Ejt9eo8sy2/KcJTwS+ZjmM1Syoh7aadOtiihj3SptG+swTUrGzEFsfK/YxIhOY61xEiynEf79p3U0IA5eVNB4wWoRkwkK9WSseUBAVd+70VhcQ54vLpqbKD1aTyUTxo/z+GfuQaMiKuVq3mmfyQ4ykBrZGuH2D7+miRCwS5ic7xRt9KukClmMYNJ+n7He6qxuyfpDSv3aOPQ27yq2ikE/vjpYnTEjwxLfhQesd0CkdWwo/vh38JgESSDuLJXe+lKIBWOUCMwPIIGsbKRcH3EHffP9moUTLEsS6yoR5MCxqw+mV5+qA2BBcPbn48iHXh3rLSD9gJrqBP8KbsS2GUWcb4JcThI159YtwO0n5AD81KDeTlt6Z0jC502DxzZjXvDm4eRM5Oie5a2kxrdgQrhs0DmOOrP7JEDWl4dzPfzbjdtXqDFBMwfYJdBYiv2crAqDCi50KrG89p36zmLoLNwbqkYCnKS6JJ1aTshWK3L4PlqhXEKIGSlhh58Ie12dcV7+CRtupClj1mKj1Xz6AE2DLo9OwmH+qy49x4zQwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5302.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199018)(38100700002)(38350700002)(41300700001)(26005)(186003)(6506007)(6512007)(83380400001)(86362001)(66476007)(2616005)(66556008)(66946007)(4326008)(8676002)(52116002)(478600001)(6486002)(316002)(36756003)(44832011)(2906002)(8936002)(5660300002)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E8PCn7+sNu2Y0bDjzSMMlsdTlq7/Duhx2kCp6I6aH79b3suW77WkN91np5VZ?= =?us-ascii?Q?efkLR4thhDf0/SZvQZKjt8cpGIlcTprG54OCFy0IfEft+p2/NXd5ZCjmQ+Wi?= =?us-ascii?Q?0PEpMDSM18h+ViOu2JOBxxCsyaJvmBbYjqmkhcB4AKasGA1eF99spClCHdZe?= =?us-ascii?Q?ByWaA11Zh197/KnrUzimvybRFOPTdYNWYlHBXGNM9dwGV+qvYH7wPOGWhxMw?= =?us-ascii?Q?Ra9X9i81SQt/nNCnVcjqnMJmDxclfeny6gAypHSrL2OO4Ed5d13rmxPztat8?= =?us-ascii?Q?RVsgiZO/DiU/rFI7nGLQ5ldm0wsxt1+uFBcbGeyi3qYgj9HkDDZjRGMfXQRU?= =?us-ascii?Q?FtYizQJNSQYyq2nLT9ZEbIwP2acHMQzKzgr3N5pUl4rl4LFIe4BiddbtDGnM?= =?us-ascii?Q?8NFo2Ij9khiFy/bJg9IOSbYrbOiPxHYS8rxnKYC//BOxB+zbE6acR21WRg0A?= =?us-ascii?Q?KT0tAI6Mebea+Uo25c/fPERa3Jj5qc4ZzAQZFjdciDhh4S3bjzx4nX94Vy4Q?= =?us-ascii?Q?RzyvDHcWVIuC3FSpzA7JX4Y70000ZsfmCUzpewrej+pudWvZqkTQD95fCQq5?= =?us-ascii?Q?RifoIwCfHuaN+pd7cBy5JrI0eaq0/H9pwiSDTs8zwd/vbWaaTSZypuWxviZx?= =?us-ascii?Q?BGHrBO1rqvv/BbHTS2r01zc8I4Qp1vssJ42yU66E342v1vj0QybAXtFJMzNe?= =?us-ascii?Q?1nAQM8BihTsfqsJn5KnPeM8oIiH9V8e14DKPyOC9Sb/Fig3RMw2W7t9nDTtX?= =?us-ascii?Q?tdq16Gik3BE6/V3NwV/vGRnn0tCqD4+pTWqURC0kTcI5HbXloxm/HPOsDigC?= =?us-ascii?Q?pDyuPwZv6LJbnurMaoHQYQDBp1oKIGw956nQK2VwdRusM9G8UcvkDdeK06ev?= =?us-ascii?Q?d5MDsKdcDwlfrfl/VWJGvNPBJWLPVo9JS2zQqRmSUYds8pgxouoWK1qbiT59?= =?us-ascii?Q?AY2SVQD24tbK6WCL28CFoEcBK4pr8FYy6XWsgK78AQcju5Zs/px04H/2YgGz?= =?us-ascii?Q?fqsVXjseG0BdU6vm7uZ8Cf16J2K5Blgmsn4+R5k3UdYe/05MDj7LzrYnrj2l?= =?us-ascii?Q?LwyEakdcLHAKVIjeGTkc0PWxFNJoPkLMtOsdlt2Bwczs4U+WSzuDVMbnsVgc?= =?us-ascii?Q?PUX9kEGLYo1BZo6EvdFQXKMgxLEpudkhh5c/IJa1w5gmr3eP7SGiDBZ5IBng?= =?us-ascii?Q?7hufpp/jOWxkBQ2XttC3sl4b3QIvGweORFpBd2D5fZGcYriJjlO5nkyrYsnq?= =?us-ascii?Q?ugUvcIIoNalGgO8mqwXiBeLbF6AaS80/pDnl+Iv2swP1AxzpJoD6FtDvLy9j?= =?us-ascii?Q?FxhP5eG2vw/3w04Bji1mbaRJasg0+miMqPVCYATLMaD/XxyWvLHY/MWmcC5p?= =?us-ascii?Q?OjoAXyXB9uViwmn0OBHO8521efoTw/GFu+tCss17pxuLHX9LK4jKdLHt0NFc?= =?us-ascii?Q?KX2rLKeoV8RJNuOSEBSR+EpVUGiqOycX8J6WX+gbsvcjf5Q57YICAVL4kFOd?= =?us-ascii?Q?GqVU+AD6rvHZSnM9OgSc0z5+T6yaJ9q5m8ol1Uc6WyG121vkvdj5KAYXpcOz?= =?us-ascii?Q?2vhjsSO3D21iTBXDmdAZJSyvixRmlsGUDEFtpG7Z?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc43aaf-7a16-4dfb-a897-08db036735b2 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5302.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 08:43:22.3285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FLzQX9rhluKQ3QLo829Vuvwn+V9cgv3LpgHFhZKt+qgme5KLxg2KcjzAzHpRNy9O X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9086 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Peng Fan To clean the upower codes by aligning codes format, check err_code and add detail bits list for the memory magic number Reviewed-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8ulp/upower/upower_hal.c | 90 +++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c b/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c index 370685e..fcb02ed 100644 --- a/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c +++ b/arch/arm/mach-imx/imx8ulp/upower/upower_hal.c @@ -129,6 +129,7 @@ int upower_init(void) u32 fw_major, fw_minor, fw_vfixes; u32 soc_id; int status; + enum upwr_resp err_code; u32 swton; u64 memon; @@ -165,22 +166,86 @@ int upower_init(void) if (ret) printf("Turn on switches fail %d\n", ret); else - printf("Turn on switches ok\n"); + printf("Turning on switches...\n"); + upower_wait_resp(); - ret = upwr_poll_req_status(UPWR_SG_PWRMGMT, NULL, NULL, &ret_val, 1000); + ret = upwr_poll_req_status(UPWR_SG_PWRMGMT, NULL, &err_code, &ret_val, 1000); if (ret != UPWR_REQ_OK) - printf("Failure %d\n", ret); + printf("Turn on switches faliure %d, err_code %d, ret_val 0x%x\n", ret, err_code, ret_val); + else + printf("Turn on switches ok\n"); - memon = 0x3FFFFFFFFFFFFCUL; - ret = upwr_pwm_power_on(NULL, (const u32 *)&memon, NULL); + /* + * Ascending Order -> bit [0:54) + * CA35 Core 0 L1 cache + * CA35 Core 1 L1 cache + * L2 Cache 0 + * L2 Cache 1 + * L2 Cache victim/tag + * CAAM Secure RAM + * DMA1 RAM + * FlexSPI2 FIFO, Buffer + * SRAM0 + * AD ROM + * USB0 TX/RX RAM + * uSDHC0 FIFO RAM + * uSDHC1 FIFO RAM + * uSDHC2 FIFO and USB1 TX/RX RAM + * GIC RAM + * ENET TX FIXO + * Reserved(Brainshift) + * DCNano Tile2Linear and RGB Correction + * DCNano Cursor and FIFO + * EPDC LUT + * EPDC FIFO + * DMA2 RAM + * GPU2D RAM Group 1 + * GPU2D RAM Group 2 + * GPU3D RAM Group 1 + * GPU3D RAM Group 2 + * HIFI4 Caches, IRAM, DRAM + * ISI Buffers + * MIPI-CSI FIFO + * MIPI-DSI FIFO + * PXP Caches, Buffers + * SRAM1 + * Casper RAM + * DMA0 RAM + * FlexCAN RAM + * FlexSPI0 FIFO, Buffer + * FlexSPI1 FIFO, Buffer + * CM33 Cache + * PowerQuad RAM + * ETF RAM + * Sentinel PKC, Data RAM1, Inst RAM0/1 + * Sentinel ROM + * uPower IRAM/DRAM + * uPower ROM + * CM33 ROM + * SSRAM Partition 0 + * SSRAM Partition 1 + * SSRAM Partition 2,3,4 + * SSRAM Partition 5 + * SSRAM Partition 6 + * SSRAM Partition 7_a(128KB) + * SSRAM Partition 7_b(64KB) + * SSRAM Partition 7_c(64KB) + * Sentinel Data RAM0, Inst RAM2 + */ + /* MIPI-CSI FIFO BIT28 not set */ + memon = 0x3FFFFFEFFFFFFCUL; + ret = upwr_pwm_power_on(NULL, (const uint32_t *)&memon, NULL); if (ret) printf("Turn on memories fail %d\n", ret); else - printf("Turn on memories ok\n"); + printf("Turning on memories...\n"); + upower_wait_resp(); - ret = upwr_poll_req_status(UPWR_SG_PWRMGMT, NULL, NULL, &ret_val, 1000); + ret = upwr_poll_req_status(UPWR_SG_PWRMGMT, NULL, &err_code, &ret_val, 1000); if (ret != UPWR_REQ_OK) - printf("Failure %d\n", ret); + printf("Turn on memories faliure %d, err_code %d, ret_val 0x%x\n", ret, err_code, ret_val); + else + printf("Turn on memories ok\n"); mdelay(1); @@ -188,13 +253,14 @@ int upower_init(void) if (ret) printf("Clear DDR retention fail %d\n", ret); else - printf("Clear DDR retention ok\n"); + printf("Clearing DDR retention...\n"); upower_wait_resp(); - - ret = upwr_poll_req_status(UPWR_SG_EXCEPT, NULL, NULL, &ret_val, 1000); + ret = upwr_poll_req_status(UPWR_SG_EXCEPT, NULL, &err_code, &ret_val, 1000); if (ret != UPWR_REQ_OK) - printf("Failure %d\n", ret); + printf("Clear DDR retention fail %d, err_code %d, ret_val 0x%x\n", ret, err_code, ret_val); + else + printf("Clear DDR retention ok\n"); return 0; } -- 2.7.4