From: "flichtenheld (Code Review)" Date: Fri, 16 Feb 2024 16:35:10 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: <169a4d4f2db2c99fa0efc170ef875ab048ffa719-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Q74Gwmx1oqM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --Q74Gwmx1oqM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 1: Code-Review-1 (7 comments) Patchset: PS1: Functionality might be fine, but could use some polish File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/524/comment/22a0a3ac_de6d8584 : PS1, Line 407: default taken from ``--route-table`` if set, otherwise :cod= e:`0`. Please change tab to spaces http://gerrit.openvpn.net/c/openvpn/+/524/comment/f27813f8_b24586f4 : PS1, Line 408: Should document that table-id can't be pushed. http://gerrit.openvpn.net/c/openvpn/+/524/comment/a3b9a424_093b4876 : PS1, Line 464: might be a good opportunity to make the description of --route-ipv6 more co= nsistent with --route? Currently the descriptions are of a very different f= ormat and verbosity even though the options are very similar File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/524/comment/f5eb20b0_42a87049 : PS1, Line 745: #define OPT_P_ROUTE_TABLE (1<<31) it is not clear to my why you need a separate permission entry here? Should= maybe add a comment about this. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/524/comment/ca4f68fc_2a1a10c0 : PS1, Line 205: "--route-table [table_id] : Specify a custom routing tab= le for use with --route(-ipv6).\n" table_id is not optional, so don't use brackets here http://gerrit.openvpn.net/c/openvpn/+/524/comment/a60bb82d_c3d5db58 : PS1, Line 6992: msg(M_WARN, "NOTE: --route-table specified, but not= supported on this platform"); This warning would be confusing with a Linux build with --enable-iproute2. = Maybe those should be two separate warnings? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Fri, 16 Feb 2024 16:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Q74Gwmx1oqM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

7 comments:

  • Patchset:

    • Patch Set #1:

      Functionality might be fine, but could use so= me polish

  • File do= c/man-sections/vpn-network-options.rst:

    • Patch Set #1, Line 407: default taken from ``--route-table`` if set, otherwi= se :code:`0`.

      Please change tab to spaces

    • Patch Set #1, Line 408= :

      Should document that tab= le-id can't be pushed.

    • Patch Set #1, Line 464:

      might be a good opportunity to make= the description of --route-ipv6 more consistent with --route? Currently th= e descriptions are of a very different format and verbosity even though the= options are very similar

  • File src/openvpn/options.h:

    • Patch Set #1, Line 745: #define OPT_P_ROUTE_TABLE (1<<31)

      it is not clear to= my why you need a separate permission entry here? Should maybe add a comme= nt about this.

  • Fi= le src/openvpn/options.c:

      Patch Set #1, Line 205: "--route-table [table_id] : Specify a custom routing table= for use with --route(-ipv6).\n"

      table_id is not optional, so don't use = brackets here

    • Patch Set #1, Line 6992: msg(M_WARN, "NOTE: --route-ta= ble specified, but not supported on this platform");

      This warning would be c= onfusing with a Linux build with --enable-iproute2. Maybe those should be t= wo separate warnings?

To view, visit change 524. To un= subscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Fri, 16 Feb 2024 16:35:10= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--Q74Gwmx1oqM=--