From: "ordex (Code Review)" Date: Thu, 19 Mar 2026 14:33:17 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <16d6459ab670041b1a07ea1bbdd2c096ce591fc9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rRhs3ajW3TU="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Try to emphasise the transition from old ovpn-dco to new ovpn module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --rRhs3ajW3TU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change by plaisthos. ( http://gerrit.open= vpn.net/c/openvpn/+/1550?usp=3Demail ) Change subject: Try to emphasise the transition from old ovpn-dco to new ov= pn module ...................................................................... Patch Set 4: Code-Review-1 (3 comments) Patchset: PS4: just commented on the Changes.rst. The rest looks good, thanks! File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/1550/comment/55e085cb_b07dee76?usp=3D= email : PS4, Line 58: main Linux kernel in 6.16. For this process some API chan= ges were required. should we say "it was merged" rather than "is moving and being merged" ? http://gerrit.openvpn.net/c/openvpn/+/1550/comment/fcd45209_ef57bfe8?usp=3D= email : PS4, Line 59: OpenVPN 2.7 will only support the new API. The new module= is called and maybe here remove "will" and just say "only supports"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1550?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072d7bf90133d328 Gerrit-Change-Number: 1550 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 19 Mar 2026 14:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --rRhs3ajW3TU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 4:Code-Review -1=

V= iew Change

3 comments:

  • Patchset:

    • Patch Set #4:

      just comme= nted on the Changes.rst. The rest looks good, thanks!

  • File Changes.rst:

    • Patch Set #4, Line 58:= main Linux kernel in 6= .16. For this process some API changes were required.

      should we = say "it was merged" rather than "is moving and being merged&= quot; ?

    • Patch Set #4, Line 59: OpenVPN 2.7 will only support the= new API. The new module is called

      and maybe here remove "w= ill" and just say "only supports"?

To view, visit change 1550. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iff9f6811fdf553f59f2afee0072= d7bf90133d328
Gerrit-Change-Number: 1550
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 19 Mar 2026 14:33:17= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --rRhs3ajW3TU=--