Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07C8C433DB for ; Sat, 9 Jan 2021 02:12:19 +0000 (UTC) Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 2B51F238EC for ; Sat, 9 Jan 2021 02:12:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B51F238EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1F79140EB3; Sat, 9 Jan 2021 03:12:17 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id E9B10140E85; Sat, 9 Jan 2021 03:12:15 +0100 (CET) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DCNkD45kqzj38v; Sat, 9 Jan 2021 10:11:16 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Sat, 9 Jan 2021 10:12:06 +0800 To: Honnappa Nagarahalli , Ruifeng Wang , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Huisong Li , Chengchang Tang , Chengwen Feng CC: "dev@dpdk.org" , "vladimir.medvedkin@intel.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , nd , "stable@dpdk.org" References: <20201218101210.356836-1-ruifeng.wang@arm.com> <20210108082523.1062058-1-ruifeng.wang@arm.com> <20210108082523.1062058-3-ruifeng.wang@arm.com> From: oulijun Message-ID: <1713bbfb-d41e-8bf4-074a-c1a323d33ecb@huawei.com> Date: Sat, 9 Jan 2021 10:11:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: fix build with sve enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/1/9 8:06, Honnappa Nagarahalli 写道: > > >> >> Building with SVE extension enabled stopped with error: >> >> error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’ >> 18 | #define PG64_256BIT svwhilelt_b64(0, 4) >> >> This is caused by unintentional cflags reset. >> Fixed the issue by appending required flag to cflags instead of overriding it. >> >> Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx") >> Cc: xavier.huwei@huawei.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Ruifeng Wang >> --- >> drivers/net/hns3/meson.build | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build >> index 45cee34d9..798086357 100644 >> --- a/drivers/net/hns3/meson.build >> +++ b/drivers/net/hns3/meson.build >> @@ -32,7 +32,7 @@ deps += ['hash'] >> if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') >> sources += files('hns3_rxtx_vec.c') >> if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' >> - cflags = ['-DCC_SVE_SUPPORT'] >> + cflags += ['-DCC_SVE_SUPPORT'] > This comment is unrelated to this patch. We need to be consistent with the macro definitions. Is '__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'. > I think the __ARM_FEATURE_SVE is ok. if use the gcc version included SVE flag, it will be identified as __ARM_FEATURE_SVE. it is defined in the ARM SVE document. >> sources += files('hns3_rxtx_vec_sve.c') >> endif >> endif >> -- >> 2.25.1 >