Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A58AC004C9 for ; Tue, 7 May 2019 19:50:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D85FD20578 for ; Tue, 7 May 2019 19:50:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D85FD20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO66L-0005oF-4N for qemu-devel@archiver.kernel.org; Tue, 07 May 2019 15:50:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO60u-00022u-Q6 for qemu-devel@nongnu.org; Tue, 07 May 2019 15:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO5wO-0001P5-E6 for qemu-devel@nongnu.org; Tue, 07 May 2019 15:42:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3090) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hO5rW-0002WB-Bd; Tue, 07 May 2019 15:34:52 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7486D66988; Tue, 7 May 2019 19:34:49 +0000 (UTC) Received: from [10.3.116.15] (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 553321001DDD; Tue, 7 May 2019 19:34:48 +0000 (UTC) To: Max Reitz , qemu-block@nongnu.org References: <20190507183610.9848-1-mreitz@redhat.com> <20190507183610.9848-3-mreitz@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <1720ca81-321b-6074-167e-cd561992aa29@redhat.com> Date: Tue, 7 May 2019 14:34:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190507183610.9848-3-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="trxC3ApcRE284TL8xvQ4mRc8fg3RDPD8R" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 07 May 2019 19:34:49 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH 2/5] iotests.py: Add qemu_nbd_early_pipe() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --trxC3ApcRE284TL8xvQ4mRc8fg3RDPD8R From: Eric Blake To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= Message-ID: <1720ca81-321b-6074-167e-cd561992aa29@redhat.com> Subject: Re: [PATCH 2/5] iotests.py: Add qemu_nbd_early_pipe() References: <20190507183610.9848-1-mreitz@redhat.com> <20190507183610.9848-3-mreitz@redhat.com> In-Reply-To: <20190507183610.9848-3-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/7/19 1:36 PM, Max Reitz wrote: > qemu_nbd_pipe() currently unconditionally reads qemu-nbd's output. Tha= t > is not ideal because qemu-nbd may keep stderr open after the parent > process has exited. >=20 > Currently, the only user of qemu_nbd_pipe() is 147, which discards the > whole output if the parent process returned success and only evaluates > it on error. Therefore, we can replace qemu_nbd_pipe() by > qemu_nbd_early_pipe() that does the same: Discard the output on success= , > and return it on error. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/147 | 4 ++-- > tests/qemu-iotests/iotests.py | 9 ++++++--- > 2 files changed, 8 insertions(+), 5 deletions(-) >=20 > @@ -216,7 +216,10 @@ def qemu_nbd_pipe(*args): > sys.stderr.write('qemu-nbd received signal %i: %s\n' % > (-exitcode, > ' '.join(qemu_nbd_args + ['--fork'] + list(a= rgs)))) > - return exitcode, subp.communicate()[0] > + if exitcode =3D=3D 0: > + return exitcode, '' > + else: > + return exitcode, subp.communicate()[0] > =20 Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --trxC3ApcRE284TL8xvQ4mRc8fg3RDPD8R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlzR3dcACgkQp6FrSiUn Q2ravgf/X90QClwaFE3dkHO6X1hiD8on4qCGSDP2Zvpz3ZZuZT5Mfp4vYjnwsIdv NzOYDWax/B3LxnbhQp1LME5aw+xjqunsfA2UQVwYKX+VJD3JxxFngGz5k7IYrOrc s24fBBmDine/MLsXrmarkS41Qf/UIqX5PvBI/J/6BMaB9Yy6FeYSVQH49088n1Re F9G9O6WKzCdCQ/RvwwCNvtgGSqayAC3WaJ/8LfPv2KtMuWKyx6JfU04deMHlPJHG hVGBLqdMSyQZOIWEVt4GhQF8VxdGnAh5gEXGmvNdBYLabIHq3iM7Pwj/0aZldcUf SrZ/FDIrAkeibwdvjWg4b4Rbg4W33w== =c3K+ -----END PGP SIGNATURE----- --trxC3ApcRE284TL8xvQ4mRc8fg3RDPD8R--