Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N4Hlx-0003G0-Ov for qemu-devel@nongnu.org; Sat, 31 Oct 2009 13:29:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N4Hlt-0003Cf-2C for qemu-devel@nongnu.org; Sat, 31 Oct 2009 13:29:53 -0400 Received: from [199.232.76.173] (port=60873 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4Hls-0003CQ-Nb for qemu-devel@nongnu.org; Sat, 31 Oct 2009 13:29:48 -0400 Received: from mail.uni-ulm.de ([134.60.1.11]:44835) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N4Hls-0000HT-6Y for qemu-devel@nongnu.org; Sat, 31 Oct 2009 13:29:48 -0400 Received: from SHERIDAN (p549D4812.dip.t-dialin.net [84.157.72.18]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id n9VHTg1A016102 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 31 Oct 2009 18:29:43 +0100 (MET) Date: Sat, 31 Oct 2009 18:29:43 +0100 From: Kay Ackermann Message-ID: <172731552.20091031182943@uni-ulm.de> Subject: [Qemu-devel] [PATCH] e1000 fix: read access to some registers is missing. MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----------97F39A3A2AAA9F" Reply-To: Kay Ackermann List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------------97F39A3A2AAA9F Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable While writing working on an e1000 driver for my university's OS I noticed that some registers aren't readable in QEMU, but they should be readable as stated in Intels Driver Developer Manual (and also verified on real hardware). diff --git a/hw/e1000.c b/hw/e1000.c index 028afd1..3987e70 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, int) = =3D { getreg(MANC),=09getreg(MDIC),=09getreg(SWSM),=09getreg(STATUS), getreg(TORL),=09getreg(TOTL),=09getreg(IMS),=09getreg(TCTL), getreg(RDH),=09getreg(RDT),=09getreg(VET),=09getreg(ICS), + getreg(TDBAL),=09getreg(TDBAH),=09getreg(RDBAH),=09getreg(RDBAL), + getreg(TDLEN),=09getreg(RDLEN), =20 [TOTH] =3D mac_read_clr8,=09[TORH] =3D mac_read_clr8,=09[GPRC] =3D mac= _read_clr4, [GPTC] =3D mac_read_clr4,=09[TPR] =3D mac_read_clr4,=09[TPT] =3D mac_r= ead_clr4, Oh and is there any specific reason why Jumbo-Frames are limited to 4k inst= ead of i.e. Alteon 9014 bytes? Regards, Kay Ackermann ------------97F39A3A2AAA9F Content-Type: text/html; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable [Qemu-devel] [PATCH] e1000 fix: read access to some regi= sters is missing.

While writing working on an e1000 driver for my university's OS I

noticed that some registers aren't readable in QEMU, but they should

be readable as stated in Intels Driver Developer Manual (and also

verified on real hardware).



diff --git a/hw/e1000.c b/hw/e1000.c

index 028afd1..3987e70 100644

--- a/hw/e1000.c

+++ b/hw/e1000.c

@@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, in= t) =3D {

     getreg(MANC),        getreg(MDIC= ),        getreg(SWSM),        getr= eg(STATUS),

     getreg(TORL),        getreg(TOTL= ),        getreg(IMS),        getre= g(TCTL),

     getreg(RDH),        getreg(RDT),=        getreg(VET),        getreg(= ICS),

+    getreg(TDBAL),        getreg(TDBAH), =        getreg(RDBAH),        getreg= (RDBAL),

+    getreg(TDLEN),        getreg(RDLEN),<= /p>

 

     [TOTH] =3D mac_read_clr8,        = ;[TORH] =3D mac_read_clr8,        [GPRC] =3D mac_read_c= lr4,

     [GPTC] =3D mac_read_clr4,        = ;[TPR] =3D mac_read_clr4,        [TPT] =3D mac_read_clr= 4,




Oh and is there any specific reason why Jumbo-Frames are limited to 4k i= nstead of i.e. Alteon 9014 bytes?


Regards,

Kay Ackermann

------------97F39A3A2AAA9F--