Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DCC6C001DC for ; Sun, 23 Jul 2023 22:05:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F20A86607; Mon, 24 Jul 2023 00:05:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="BASYSXcV"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="lZt95iFF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6AB3B863E7; Mon, 24 Jul 2023 00:05:08 +0200 (CEST) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E799986687 for ; Mon, 24 Jul 2023 00:05:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4R8HQm4TKcz9sTR; Mon, 24 Jul 2023 00:05:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1690149904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36iBamRSVE7YRMYwHT8B2TxnR1+H9YHBcQAvfATM4EE=; b=BASYSXcV/n6LXqt0OQrLxJkl6Tr+i/207+xeozp5PDma8wIWxJlm5+fF3wy2FYfmM49mix 5WYBPy+lUoOgXpVwxbSSPTIuE3DsWYUqq3+WWWFNO2nh9j+5kvgU1ozfvJJqyY0XOY+Xu5 NAt3imaDhI12x2E+2V6CO3rSORf/kBjgBeQtOMHYCLjJDe8NVwZDQxANErWZ/23nd4RPaD rb4EMYk9pRdrtnc3lpIcjFUVDVt1cNX2J87nvW6CrCYfpUOJ54TwIBVpDT1lvHNUiKqFWX tgeQFb6SyMTY4p3kh3fMosumOZ92XBPLwJQu2SX6I3lwqabvrxUwUzkMZt5FGQ== Message-ID: <175d268d-510b-62dc-c56f-fd44aba0b820@mailbox.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1690149902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36iBamRSVE7YRMYwHT8B2TxnR1+H9YHBcQAvfATM4EE=; b=lZt95iFF6iAfaVybHeYiTeq6i/tYgrd9JKXqSjmjz+Nev2Yr+GaYcxDgRO7x5N5eM0V9S4 0Hu5urflL0vQ8bQB+cK2BYOILTpkaxM0RlNaFLC7PS4hlQUZz7VXASc0+dHrMfd+ION6wR zYGH23T1HBR3IGHdBEje2rxUAlT/N2BcOIkngtUKYcL3jpXbhnbzzHm4xHdoJOMMzrabb7 FXocq+drKzAUXvCqd7uowyk+Mt66+Ma8uzlyf86fM10N4bP8NyDVRrb/jNmoq7j3m+Y8Co qhbZFtDHmYMheJkAzMV2IAFkWnGt/oClSKEpXqEtb1OI9HVebj1Nf/ZxMU4cqg== Date: Mon, 24 Jul 2023 00:05:00 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v3 4/6] sysinfo: Add documentation Content-Language: en-US To: Detlev Casanova , u-boot@lists.denx.de Cc: Marek Vasut , Hai Pham , Tam Nguyen , Simon Glass References: <20230714164424.838842-1-detlev.casanova@collabora.com> <20230714164424.838842-5-detlev.casanova@collabora.com> <0f6036d7-0d7c-0434-ad34-4aefdaac89a3@mailbox.org> <3816228.mvXUDI8C0e@arisu> From: Marek Vasut In-Reply-To: <3816228.mvXUDI8C0e@arisu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-META: sd8fqjxj4p99pek7f3wu5nm4dro6fubg X-MBO-RS-ID: c772ebb87b5d872539f X-Rspamd-Queue-Id: 4R8HQm4TKcz9sTR X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/17/23 14:27, Detlev Casanova wrote: > On Friday, July 14, 2023 1:31:00 P.M. EDT Marek Vasut wrote: >> On 7/14/23 18:43, Detlev Casanova wrote: >> >> [...] >> >>> +Return value >>> +------------ >>> + >>> +The return value $? is set to 0 (true) if the command succededd >> >> succeeded -- typo >> >> . If an >> >>> +error occurs, the return value $? is set to 1 (false). >> >> With that fixed: >> >> Reviewed-by: Marek Vasut > > Do you need me to make a patch v4 to fix this ? Yes please, although I see a v4 already, thanks !