From: "ordex (Code Review)"
Date: Mon, 28 Jul 2025 11:37:49 +0000
In-Reply-To:
References:
Reply-To: antonio@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296...
Message-ID: <177cd211a8e905cf84909fcea8138184eedea826-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="NxFmrS2m9CA="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client
prefix after DCO PEER_FLOAT notification
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--NxFmrS2m9CA=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1116?usp=3Demail )
Change subject: dco: drop client prefix after DCO PEER_FLOAT notification
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Actually it is just fixing one particular symptom, but we can get there i=
n other paths as well - her [=E2=80=A6]
These are 2 different problems:
1) when we float we set an unexpected prefix and we stick to it.
2) when we parse notifications we may use the prefix coming from another in=
stance.
This patch is trying to fix problem 1, which is similar but different from =
problem 2.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1116?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24
Gerrit-Change-Number: 1116
Gerrit-PatchSet: 2
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Mon, 28 Jul 2025 11:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--NxFmrS2m9CA=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos. <=
/p>
Actually it is just =
fixing one particular symptom, but we can get there in other paths as well =
- her [=E2=80=A6]
These are 2 different problems: 1) when we float we se=
t an unexpected prefix and we stick to it. 2) when we parse notification=
s we may use the prefix coming from another instance.
This patch is trying to fix proble=
m 1, which is similar but different from problem 2.
=
To view, visit change 1116. To unsubscribe, or for help writing mail filters=
, visit settings.