From: Arne Schwabe References: <20191117181243.28919-1-arne@...1227...> <20191117181243.28919-2-arne@...1227...> Message-ID: <1791ea6f-68da-43f5-e261-0d3b8cf63972@...1227...> Date: Thu, 13 Feb 2020 15:14:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: de-DE Subject: Re: [Openvpn-devel] [PATCH 2/4] Implement dynamic NCP negotiation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lev Stipakov , "openvpn-devel@lists.sourceforge.net" Am 13.02.20 um 12:45 schrieb Lev Stipakov: > Hi, > > su 17. marrask. 2019 klo 20.13 Arne Schwabe (arne@...1227... > ) kirjoitti: > >> +#include "ssl_ncp.h" > > this file is missing from this patch. > >> +    const char *token = strsep(&tmp_ciphers, ":"); > > This breaks on Windows. > > Could you send v2 with strsep-compat and removed header (which is > introduced in v3) ? > Patch 6 takes cares of fixing Windows compatibility. Arne