From: "cron2 (Code Review)" Date: Tue, 16 Jan 2024 11:41:29 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <17a705cc1f91fd9c9e263e057abed546bb4073ef-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="4kA4JuAinwU="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --4kA4JuAinwU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/471?usp=3Demail ) Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: Something is weird here. The unit test passes on "unixy" platforms, and ms= build in GHA has no complaints (but might not build it either). mingw+cmake fails with an error related to pulling in wfp ``` [115/296] Linking C executable Debug/test_pkt.exe 364 [116/296] Building C object CMakeFiles/test_ssl.dir/Debug/src/openvpn/blo= ck_dns.c.obj 365 FAILED: CMakeFiles/test_ssl.dir/Debug/src/openvpn/block_dns.c.obj ``` while building autoconf-based mingw compiles the bits fine, and fails linki= ng ``` CC ../../../src/openvpn/ssl_testdriver-xkey_helper.o CC ../../../src/openvpn/ssl_testdriver-ssl_util.o CC ../../../src/openvpn/ssl_testdriver-base64.o CC ../../../src/openvpn/ssl_testdriver-cryptoapi.o CCLD ssl_testdriver.exe /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi= .o:cryptoapi.c:(.text+0x27c): undefined reference to `NCryptFreeObject@...1386...= 477...' /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi= .o:cryptoapi.c:(.text+0x2b2): undefined reference to `_imp__CertFreeCertifi= cateContext@...1477...' ... /usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi= .o:cryptoapi.c:(.text+0xf9a): undefined reference to `tls_libctx' ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 16 Jan 2024 11:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --4kA4JuAinwU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 5:Code-Review -1=

Vi= ew Change

1 comment: