From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/2] drm/amdgpu/uvd: UVD entity initialization relys on ring initialization Date: Mon, 13 Aug 2018 08:39:24 +0200 Message-ID: <17db959d-57c1-e0f8-8f3d-d1d76de658e6@gmail.com> References: <1534129843-14571-1-git-send-email-Emily.Deng@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1534129843-14571-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Emily Deng , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTMuMDguMjAxOCB1bSAwNToxMCBzY2hyaWViIEVtaWx5IERlbmc6Cj4gRW50aXR5IGluaXQg c2hvdWxkIGFmdGVyIHJpbmcgaW5pdCwgYXMgdGhlIGVudGl0eSdzIHNjaGVkX3JxJ3MgaW5pdGlh bGl6YXRpb24KPiBpcyBpbiByaW5nIGluaXQuCj4KPiBTV0RFVi0xNjE0OTUKPgo+IFNpZ25lZC1v ZmYtYnk6IEVtaWx5IERlbmcgPEVtaWx5LkRlbmdAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBDaHJp c3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+IGZvciB0aGUgd2hvbGUgCnNl cmllcy4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdXZkLmMg fCAzMiArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3V2ZC5oIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvdXZkX3Y0XzIuYyAgIHwgIDQgKysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvdXZkX3Y1XzAuYyAgIHwgIDQgKysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv dXZkX3Y2XzAuYyAgIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3V2ZF92 N18wLmMgICB8ICA1ICsrKysrCj4gICA2IGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3V2ZC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3V2ZC5j Cj4gaW5kZXggNjMyZmE1OS4uNDMzYTc0MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdXZkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfdXZkLmMKPiBAQCAtMTIyLDggKzEyMiw2IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV91 dmRfaWRsZV93b3JrX2hhbmRsZXIoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKTsKPiAgIAo+ICAg aW50IGFtZGdwdV91dmRfc3dfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIHsK PiAtCXN0cnVjdCBhbWRncHVfcmluZyAqcmluZzsKPiAtCXN0cnVjdCBkcm1fc2NoZWRfcnEgKnJx Owo+ICAgCXVuc2lnbmVkIGxvbmcgYm9fc2l6ZTsKPiAgIAljb25zdCBjaGFyICpmd19uYW1lOwo+ ICAgCWNvbnN0IHN0cnVjdCBjb21tb25fZmlybXdhcmVfaGVhZGVyICpoZHI7Cj4gQEAgLTI2Niwx MyArMjY0LDYgQEAgaW50IGFtZGdwdV91dmRfc3dfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldikKPiAgIAkJfQo+ICAgCX0KPiAgIAo+IC0JcmluZyA9ICZhZGV2LT51dmQuaW5zdFswXS5y aW5nOwo+IC0JcnEgPSAmcmluZy0+c2NoZWQuc2NoZWRfcnFbRFJNX1NDSEVEX1BSSU9SSVRZX05P Uk1BTF07Cj4gLQlyID0gZHJtX3NjaGVkX2VudGl0eV9pbml0KCZhZGV2LT51dmQuZW50aXR5LCAm cnEsIDEsIE5VTEwpOwo+IC0JaWYgKHIpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCBzZXR0aW5n IHVwIFVWRCBrZXJuZWwgZW50aXR5LlxuIik7Cj4gLQkJcmV0dXJuIHI7Cj4gLQl9Cj4gICAJZm9y IChpID0gMDsgaSA8IGFkZXYtPnV2ZC5tYXhfaGFuZGxlczsgKytpKSB7Cj4gICAJCWF0b21pY19z ZXQoJmFkZXYtPnV2ZC5oYW5kbGVzW2ldLCAwKTsKPiAgIAkJYWRldi0+dXZkLmZpbHBbaV0gPSBO VUxMOwo+IEBAIC0zMjcsNiArMzE4LDI5IEBAIGludCBhbWRncHVfdXZkX3N3X2Zpbmkoc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiArLyoqCj4g KyAqIGFtZGdwdV91dmRfZW50aXR5X2luaXQgLSBpbml0IGVudGl0eQo+ICsgKgo+ICsgKiBAYWRl djogYW1kZ3B1X2RldmljZSBwb2ludGVyCj4gKyAqCj4gKyAqLwo+ICtpbnQgYW1kZ3B1X3V2ZF9l bnRpdHlfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiArewo+ICsJc3RydWN0IGFt ZGdwdV9yaW5nICpyaW5nOwo+ICsJc3RydWN0IGRybV9zY2hlZF9ycSAqcnE7Cj4gKwlpbnQgcjsK PiArCj4gKwlyaW5nID0gJmFkZXYtPnV2ZC5pbnN0WzBdLnJpbmc7Cj4gKwlycSA9ICZyaW5nLT5z Y2hlZC5zY2hlZF9ycVtEUk1fU0NIRURfUFJJT1JJVFlfTk9STUFMXTsKPiArCXIgPSBkcm1fc2No ZWRfZW50aXR5X2luaXQoJmFkZXYtPnV2ZC5lbnRpdHksICZycSwgMSwgTlVMTCk7Cj4gKwlpZiAo cikgewo+ICsJCURSTV9FUlJPUigiRmFpbGVkIHNldHRpbmcgdXAgVVZEIGtlcm5lbCBlbnRpdHku XG4iKTsKPiArCQlyZXR1cm4gcjsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAg IGludCBhbWRncHVfdXZkX3N1c3BlbmQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICB7 Cj4gICAJdW5zaWduZWQgc2l6ZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3V2ZC5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3V2 ZC5oCj4gaW5kZXggMzNjNWY4MC4uYTNhYjFhNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfdXZkLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdXZkLmgKPiBAQCAtNjksNiArNjksNyBAQCBzdHJ1Y3QgYW1kZ3B1X3V2ZCB7 Cj4gICAKPiAgIGludCBhbWRncHVfdXZkX3N3X2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYpOwo+ICAgaW50IGFtZGdwdV91dmRfc3dfZmluaShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl dik7Cj4gK2ludCBhbWRncHVfdXZkX2VudGl0eV9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICph ZGV2KTsKPiAgIGludCBhbWRncHVfdXZkX3N1c3BlbmQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYpOwo+ICAgaW50IGFtZGdwdV91dmRfcmVzdW1lKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 KTsKPiAgIGludCBhbWRncHVfdXZkX2dldF9jcmVhdGVfbXNnKHN0cnVjdCBhbWRncHVfcmluZyAq cmluZywgdWludDMyX3QgaGFuZGxlLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS91dmRfdjRfMi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdXZkX3Y0XzIu Ywo+IGluZGV4IDZmZWQzZDcuLjhhOTI2ZDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvdXZkX3Y0XzIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L3V2ZF92NF8yLmMKPiBAQCAtMTIzLDYgKzEyMywxMCBAQCBzdGF0aWMgaW50IHV2ZF92NF8yX3N3 X2luaXQodm9pZCAqaGFuZGxlKQo+ICAgCXJpbmcgPSAmYWRldi0+dXZkLmluc3QtPnJpbmc7Cj4g ICAJc3ByaW50ZihyaW5nLT5uYW1lLCAidXZkIik7Cj4gICAJciA9IGFtZGdwdV9yaW5nX2luaXQo YWRldiwgcmluZywgNTEyLCAmYWRldi0+dXZkLmluc3QtPmlycSwgMCk7Cj4gKwlpZiAocikKPiAr CQlyZXR1cm4gcjsKPiArCj4gKwlyID0gYW1kZ3B1X3V2ZF9lbnRpdHlfaW5pdChhZGV2KTsKPiAg IAo+ICAgCXJldHVybiByOwo+ICAgfQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS91dmRfdjVfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdXZkX3Y1XzAu Ywo+IGluZGV4IGFlYWExY2EuLjUwMjQ4MDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvdXZkX3Y1XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L3V2ZF92NV8wLmMKPiBAQCAtMTIwLDYgKzEyMCwxMCBAQCBzdGF0aWMgaW50IHV2ZF92NV8wX3N3 X2luaXQodm9pZCAqaGFuZGxlKQo+ICAgCXJpbmcgPSAmYWRldi0+dXZkLmluc3QtPnJpbmc7Cj4g ICAJc3ByaW50ZihyaW5nLT5uYW1lLCAidXZkIik7Cj4gICAJciA9IGFtZGdwdV9yaW5nX2luaXQo YWRldiwgcmluZywgNTEyLCAmYWRldi0+dXZkLmluc3QtPmlycSwgMCk7Cj4gKwlpZiAocikKPiAr CQlyZXR1cm4gcjsKPiArCj4gKwlyID0gYW1kZ3B1X3V2ZF9lbnRpdHlfaW5pdChhZGV2KTsKPiAg IAo+ICAgCXJldHVybiByOwo+ICAgfQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS91dmRfdjZfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdXZkX3Y2XzAu Ywo+IGluZGV4IDU5OGRiZWEuLjZhZTgyY2MgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvdXZkX3Y2XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L3V2ZF92Nl8wLmMKPiBAQCAtNDQwLDYgKzQ0MCw4IEBAIHN0YXRpYyBpbnQgdXZkX3Y2XzBfc3df aW5pdCh2b2lkICpoYW5kbGUpCj4gICAJCX0KPiAgIAl9Cj4gICAKPiArCXIgPSBhbWRncHVfdXZk X2VudGl0eV9pbml0KGFkZXYpOwo+ICsKPiAgIAlyZXR1cm4gcjsKPiAgIH0KPiAgIAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS91dmRfdjdfMC5jIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvdXZkX3Y3XzAuYwo+IGluZGV4IDVmYWIzNTYuLjliN2Y4NDYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdXZkX3Y3XzAuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3V2ZF92N18wLmMKPiBAQCAtNDEwLDYgKzQxMCw3 IEBAIHN0YXRpYyBpbnQgdXZkX3Y3XzBfZWFybHlfaW5pdCh2b2lkICpoYW5kbGUpCj4gICBzdGF0 aWMgaW50IHV2ZF92N18wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+ICAgewo+ICAgCXN0cnVjdCBh bWRncHVfcmluZyAqcmluZzsKPiArCj4gICAJaW50IGksIGosIHI7Cj4gICAJc3RydWN0IGFtZGdw dV9kZXZpY2UgKmFkZXYgPSAoc3RydWN0IGFtZGdwdV9kZXZpY2UgKiloYW5kbGU7Cj4gICAKPiBA QCAtNDc4LDYgKzQ3OSwxMCBAQCBzdGF0aWMgaW50IHV2ZF92N18wX3N3X2luaXQodm9pZCAqaGFu ZGxlKQo+ICAgCQl9Cj4gICAJfQo+ICAgCj4gKwlyID0gYW1kZ3B1X3V2ZF9lbnRpdHlfaW5pdChh ZGV2KTsKPiArCWlmIChyKQo+ICsJCXJldHVybiByOwo+ICsKPiAgIAlyID0gYW1kZ3B1X3ZpcnRf YWxsb2NfbW1fdGFibGUoYWRldik7Cj4gICAJaWYgKHIpCj4gICAJCXJldHVybiByOwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==