From: "cron2 (Code Review)" Date: Mon, 28 Apr 2025 19:20:56 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <17eb7e26bed2242a36e1c709945d67900e5a5d25-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="/nA+3vXmxDc="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[release/2.6]: Fix MBEDTLS_DEPRECATED_REMOVED build errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , comododragon Cc: openvpn-devel , plaisthos --/nA+3vXmxDc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/946?usp=3Demail ) Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: This looks like a straightforward cherrypick, but then fails on some builde= rs with ``` essl_mbedtls.c: In function ???tls_version_to_ssl_version???: essl_mbedtls.c:1069:14: error: ???major??? undeclared (first use in this +function) e 1069 | *major =3D MBEDTLS_SSL_MAJOR_VERSION_3; e | ^~~~~ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/946?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9 Gerrit-Change-Number: 946 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: comododragon Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 28 Apr 2025 19:20:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --/nA+3vXmxDc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      This looks like a straightforward cherrypick, = but then fails on some builders with

      ```
      essl_mbedtls.c: In function ???tls_version_t= o_ssl_version???:
      essl_mbedtls.c:1069:14: error: ???major??? undeclared = (first use in this
      +function)
      e 1069 | *major =3D MBEDTLS= _SSL_MAJOR_VERSION_3;
      e | ^~~~~
      ```

To view, visit change 946. To unsubscribe, or for help writing mail f= ilters, visit settings.<= /p>

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: If96c2ebd2af16b18ed34820e8c0= 531547e2076d9
Gerrit-Change-Number: 946
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: comododragon <rein.vanbaaren@...493...= 1435...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 28 Apr 2025 19:20:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--/nA+3vXmxDc=--