Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E307AC77B61 for ; Mon, 24 Apr 2023 16:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjDXQje (ORCPT ); Mon, 24 Apr 2023 12:39:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbjDXQjd (ORCPT ); Mon, 24 Apr 2023 12:39:33 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A133A8C for ; Mon, 24 Apr 2023 09:39:32 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-763740a7f31so14293339f.0 for ; Mon, 24 Apr 2023 09:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1682354372; x=1684946372; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y4EQyKul/PdMUukH7r+B8jj3xQ5gjwr3+n4cMj9T93M=; b=29hXv3LfoLDsyNLiV0sfsQ2fn8nNm+A8pxirwf0CJw6BzcQlwfzRksV2KCNtPYnjo/ 1BT1zoykFbJcHgasIxZHCh8X+sDWp3bV5/ZiYWkNNAj8XQ0JF8yw6y2YVBhM2P6/Ng/9 Ey4+LPNv1vD1kBOiaOhQUktdJMX5L7iCZaWGNhMly4NdzLpuSyqaEutLzhiAkwwpG8sY 3wTfCAASktnW6QPnwPifGp59NTq0/xw0GmNzFCkvxgkRkg9DeC79NJou/QpDVikoPsSI 4Vz8StPE7ZoPp6a9+y8axPIWdvbe8sg7PZwGFlXWzk6rXEVS5zXVc6+m+ea2fVHFPHAA Z/Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682354372; x=1684946372; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y4EQyKul/PdMUukH7r+B8jj3xQ5gjwr3+n4cMj9T93M=; b=g4dMGfXu10V2rWOjbpZFyMVa+kYtXn58jtPg1GHqpXNCW9RGRUuSGOFf0TKKx+aavK pBK46i5b90TC8Nc/gvNVhSY+gltGbEpzgK0UJdw8LYB3Vt444+SAD0NFSlw6p+z9NSGw htKOsoUBeohJAGwe4zE7bJc/673Lt2logZLwTRnb6MdawmQ1L8W8/LoNmOnp2dDvYC/M YnuSiFpG8umYDHRNm+4pXVySehQVJWIK5BiNqK+iMIfgCl/OB7HfC0/dCcwkTzE0gdnb 14bZQOo3UuYm4caJs/xo/ViDsQmOi+r+OlV7ALuL9fs6MTXFc2t2XdGDU2q5Ml7pDsbg xO8w== X-Gm-Message-State: AAQBX9cLuesDXa8RmwY5QG6PbP5BhQDYyYS7X9+Y4McAtBcI1pYM+CQg q0/oMOkY6VdC7jMQOAStL9gWTh+bsZuMj5llwEc= X-Google-Smtp-Source: AKy350ajXxXeVsLsPGCPIDs2KWsbK3IbqXDcwyhmCVO7RwKx5h+Hj/ArBKuJkx40ZgROUWHvnlluAw== X-Received: by 2002:a5d:9d90:0:b0:760:dfd3:208d with SMTP id ay16-20020a5d9d90000000b00760dfd3208dmr10585566iob.0.1682354371932; Mon, 24 Apr 2023 09:39:31 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id cp14-20020a056638480e00b00411c415b4acsm495470jab.19.2023.04.24.09.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 09:39:31 -0700 (PDT) Message-ID: <17f55b16-cc5f-a585-baa3-2a39cb5e9cf3@kernel.dk> Date: Mon, 24 Apr 2023 10:39:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set Content-Language: en-US To: Chaitanya Kulkarni , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org Cc: josef@toxicpanda.com, minchan@kernel.org, senozhatsky@chromium.org, colyli@suse.de, kent.overstreet@gmail.com, dlemoal@kernel.org, johannes.thumshirn@wdc.com, bvanassche@acm.org, vincent.fu@samsung.com, akinobu.mita@gmail.com, shinichiro.kawasaki@wdc.com, nbd@other.debian.org References: <20230424073023.38935-1-kch@nvidia.com> From: Jens Axboe In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 4/24/23 1:30?AM, Chaitanya Kulkarni wrote: > Hi, > > The drivers in this patch-series tries to clear the > QUEUE_FLAG_ADD_RANDOM that is not set at all in the queue allocation > and initialization path in :- Just roll this into one, as it should be a non-functional change since we don't default to ADD_RANDOM with MQ ops. And then change the title to something meaningful, ala: block/drivers: remove dead clear of QUEUE_FLAG_ADD_RANDOM or something like that, as your title currently makes very little sense (eg it's hard to parse and it doesn't really say what is being done). -- Jens Axboe