From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Subject: Re: [PATCH] drm/bridge: dw-hdmi: Use automatic CTS generation mode when using non-AHB audio Date: Sat, 15 Jun 2019 11:17:10 +0200 Message-ID: <1804909.ykhh25WWxx@jernej-laptop> References: <20190612085147.26971-1-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190612085147.26971-1-narmstrong@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong Cc: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Jonas Karlman , Heiko Stuebner , Jerome Brunet List-Id: dri-devel@lists.freedesktop.org Dne sreda, 12. junij 2019 ob 10:51:47 CEST je Neil Armstrong napisal(a): > When using an I2S source using a different clock source (usually the I2S > audio HW uses dedicated PLLs, different from the HDMI PHY PLL), fixed > CTS values will cause some frequent audio drop-out and glitches as > reported on Amlogic, Allwinner and Rockchip SoCs setups. > > Setting the CTS in automatic mode will let the HDMI controller generate > automatically the CTS value to match the input audio clock. > > The DesignWare DW-HDMI User Guide explains: > For Automatic CTS generation > Write "0" on the bit field "CTS_manual", Register 0x3205: AUD_CTS3 > > The DesignWare DW-HDMI Databook explains : > If "CTS_manual" bit equals 0b this registers contains "audCTS[19:0]" > generated by the Cycle time counter according to specified timing. > > Cc: Jernej Skrabec > Cc: Maxime Ripard > Cc: Jonas Karlman > Cc: Heiko Stuebner > Cc: Jerome Brunet > Signed-off-by: Neil Armstrong Tested-by: Jernej Skrabec Reviewed-by: Jernej Skrabec Best regards, Jernej