Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5772FC433E6 for ; Tue, 2 Feb 2021 10:13:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7840B64F55 for ; Tue, 2 Feb 2021 10:13:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7840B64F55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 88C8C172F; Tue, 2 Feb 2021 11:12:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 88C8C172F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612260789; bh=Y/RKiwNQo48NK4PZ1WWsHZJ1QXV5p+6m5nIdWeiTZ3Q=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RlqWm03Lclz3HyjWySXqME9Hwl8W89xE53XFVyS174siyKo4JCawogSfqT957IwO4 xHkcQUxDE1I20X963fEGxwNjabnxKd8kuWafsDueZ8WczhbZQXzhkG4AqdO3niA8Kq r4+hoC0B+4W3t0oIp3xEy0Q5sLLeOdjFZQHfMYMk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09784F8013C; Tue, 2 Feb 2021 11:12:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0AB2FF80171; Tue, 2 Feb 2021 11:12:18 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70988F8013C for ; Tue, 2 Feb 2021 11:12:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70988F8013C IronPort-SDR: xq/7IPAJbNC7nYCdCsXAbB7pQROO3v79YTVCSt7mT/0UYo0yBCXM5x5OqMYvNBgItqIa0IgVkQ wFanlnVhs/PA== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="242346889" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="242346889" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 02:12:06 -0800 IronPort-SDR: wNVxb+v9Tw7LH4gjIHc4mkj2dCtCFPTcW4taHLwIwmE6vFeHU0H/fh8/01kt+hA7WnAk0zMPZI k1bFYsnfQSqw== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="370455124" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.25.151]) ([10.213.25.151]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 02:12:04 -0800 Subject: Re: [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected To: Kai-Heng Feng References: <20210125115441.10383-1-cezary.rojewski@intel.com> <324dc8a5-c4d3-6ebf-c8e9-6321d6c93dab@intel.com> From: Cezary Rojewski Message-ID: <181c989f-7a4d-3cdd-11be-7378dbc9502c@intel.com> Date: Tue, 2 Feb 2021 11:12:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Pierre-Louis Bossart , "moderated list:SOUND" , Liam Girdwood , Takashi Iwai , Hans de Goede , Mark Brown , =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2021-02-02 6:52 AM, Kai-Heng Feng wrote: > On Wed, Jan 27, 2021 at 11:22 PM Cezary Rojewski > wrote: >> ... >> >> From the logs you've provided one can see that snd_soc_skl did attempt >> to probe() so the code compiled just fine. Again, compilation issue is >> the one I've addressed here. While we're here, I'd appreciate kconfig >> being provided along dmesg file. Logs alone do not show the entire >> picture, unfortunately. > > Config file here: > https://pastebin.ubuntu.com/p/kGBv6XgHms/ Thank you for the config, Yang. >> >> In regard to missing sound, (looks like we're talking about HDA dsp + >> DMIC configuration) kconfig mentioned above will be required. Pretty >> sure HDAudio support for skylake-driver is not enabled on your machine >> and thus driver exists probe() early without registering any sound card. > > Do you mean CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC needs to be enabled? Indeed. Below are the options required to enable HDA-dsp + DMIC configuration: (first navigate to:) -> Device Drivers -> Sound card support -> ALSA -> HD-Audio --> HD Audio PCI --> Build Realtek HD-audio codec support --> Build HDMI/DisplayPort HD-audio codec support -> ASoC --> Intel ASoC SST drivers --> Skylake Platforms --> Kabylake Platforms --> Broxton/ApolloLake Platforms --> HDAudio codec support --> Intel Machine drivers ---> DMIC machine board driver ---> SKL/KBL/BXT/APL with HDA codecs Let me know how the situation looks with these set. Regards, Czarek