Return-Path: DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 0C541294999 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1588179034; bh=vyWDvwVbcDDJNCijHxI61ev73d6/hWLkPzpKBE9qThU=; h=Date:From:To:Message-ID:MIME-Version; b=kpX7y2oZS+AL55A22zokUrtcbjLNAstqb5fpi3QRDjDoBlIsGZtiJgsA3gWPybhxH m03/odK2Bm9IN24GPwPa4Mwh7puFTjq/vM2ArDMbXOwo4pNEp1mB6ZhxiUlU596fft oGR6sHLCWT7Vo/v470VHR8DKtP4N0xub+XyGBvS077G/qVPIxp9R+PPmoJVUQqzhni TCyYU159V05N/u4JYvsH+YRyA6Hg0MYJtUVd8SdT+M/aHiZ4lmRTGQtkjFBh9kGAa6 f9uixmCi6hjzCiIbcShGYuzov2I05lKJpvMRxkQNNc7AoAl50GKVrd6ubxGjVf3eN8 6kVdZw0pidquA== Date: Wed, 29 Apr 2020 12:50:33 -0400 (EDT) From: Philippe Proulx Message-ID: <1854624569.76059.1588179033966.JavaMail.zimbra@efficios.com> In-Reply-To: <104691146.75724.1588162084473.JavaMail.zimbra@efficios.com> References: <20200423205226.496-1-mathieu.desnoyers@efficios.com> <20200423205226.496-2-mathieu.desnoyers@efficios.com> <1031751564.72894.1588099218629.JavaMail.zimbra@efficios.com> <1859708486.72922.1588099890391.JavaMail.zimbra@efficios.com> <104691146.75724.1588162084473.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [diamon-discuss] [RFC PATCH CTF 1/3] Clarify that unlisted enum values are implementation-defined List-Id: DiaMon diagnostic and monitoring workgroup general discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mathieu Desnoyers Cc: diamon-discuss , lttng-dev , Jeremie Galarneau , gbastien+lttng ----- Original Message ----- > From: "Mathieu Desnoyers" > To: "Philippe Proulx" > Cc: "gbastien+lttng" , "Matthew Khouzam" , "Jeremie > Galarneau" , "lttng-dev" = , "diamon-discuss" > > Sent: Wednesday, 29 April, 2020 08:08:04 > Subject: Re: [RFC PATCH CTF 1/3] Clarify that unlisted enum values are im= plementation-defined > ----- On Apr 28, 2020, at 2:51 PM, Mathieu Desnoyers > mathieu.desnoyers@efficios.com wrote: >=20 >> ----- On Apr 28, 2020, at 2:40 PM, Philippe Proulx pproulx@efficios.com = wrote: >>=20 >>> ----- Original Message ----- >>>> From: "Mathieu Desnoyers" >>>> To: "gbastien+lttng" , "Matthew Khouzam" >>>> , >>>> diamon-discuss@linuxfoundation.org, pproulx@efficios.com, "Jeremie Gal= arneau" >>>> >>>> Cc: "lttng-dev" , "Mathieu Desnoyers" >>>> >>>> Sent: Thursday, 23 April, 2020 16:52:24 >>>> Subject: [RFC PATCH CTF 1/3] Clarify that unlisted enum values are >>>> implementation-defined >>>=20 >>>> From: Genevi=C3=A8ve Bastien >>>>=20 >>>> Signed-off-by: Genevi=C3=A8ve Bastien >>>> Signed-off-by: Mathieu Desnoyers >>>> --- >>>> common-trace-format-specification.md | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>>=20 >>>> diff --git a/common-trace-format-specification.md >>>> b/common-trace-format-specification.md >>>> index fd49e59..f5fea51 100644 >>>> --- a/common-trace-format-specification.md >>>> +++ b/common-trace-format-specification.md >>>> @@ -464,6 +464,9 @@ enum { >>>> } >>>> ~~~ >>>>=20 >>>> +The mappings in the enumeration type do not have to be exhaustive. >>>> +Unlisted values are implementation defined. >>>> + >>>=20 >>> Why not just: >>>=20 >>> An enumeration field can have an integral value which its type does = not >>> map to a string. >>>=20 >>> ? >>=20 >> Good point, I will use that wording. >=20 > Genevi=C3=A8ve pointed out on IRC that the sentence above is weird. Would= the > following convey the right meaning ? >=20 > "An enumeration field can have an integral value for which the associated > enumeration > type does not map to a string." Sure. Phil >=20 > Thanks, >=20 > Mathieu >=20 >>=20 >> Thanks, >>=20 >> Mathieu >>=20 >>>=20 >>> Phil >>>=20 >>>> ### 4.2 Compound types >>>>=20 >>>> Compound are aggregation of type declarations. Compound types include >>>> -- >>> > 2.11.0 >>=20 >> -- >> Mathieu Desnoyers >> EfficiOS Inc. >> http://www.efficios.com >=20 > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com