From: Keerthy Date: Mon, 27 Jan 2020 23:02:28 +0530 Subject: [PATCH v4 06/10] arm: dts: k3-j721e-r5: Add fs_loader node In-Reply-To: <20200127141432.GG9259@bill-the-cat> References: <20200122040005.7573-1-j-keerthy@ti.com> <20200122040005.7573-7-j-keerthy@ti.com> <20200124145534.GP26536@bill-the-cat> <26b6a688-c1d0-eae9-beb5-028495f530ad@ti.com> <20200127141432.GG9259@bill-the-cat> Message-ID: <1857380d-dc9d-3054-dfe0-eaca1e8aa4dc@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27/01/20 7:44 pm, Tom Rini wrote: > On Mon, Jan 27, 2020 at 10:07:31AM +0530, Keerthy wrote: >> >> >> On 24/01/20 8:25 pm, Tom Rini wrote: >>> On Wed, Jan 22, 2020 at 09:30:01AM +0530, Keerthy wrote: >>>> Add fs_loader node which will be needed for loading firmwares >>>> from the boot media/filesystem. >>>> >>>> Signed-off-by: Keerthy >>>> Signed-off-by: Lokesh Vutla >>>> --- >>>> arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts >>>> index 28a355d49c..caeee8defe 100644 >>>> --- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts >>>> +++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts >>>> @@ -18,6 +18,12 @@ >>>> chosen { >>>> stdout-path = "serial2:115200n8"; >>>> tick-timer = &timer1; >>>> + firmware-loader = &fs_loader0; >>>> + }; >>>> + >>>> + fs_loader0: fs_loader at 0 { >>>> + u-boot,dm-pre-reloc; >>>> + compatible = "u-boot,fs-loader"; >>>> }; >>>> a72_0: a72 at 0 { >>> >>> All u-boot, properties need to be in a -u-boot.dtsi file so it's very >>> clear what things we are adding and what files can be replaced directly >>> from Linux. Please fixup anything else in this area that wasn't already >>> doing this and then add what you need here, thanks! >> >> Tom, >> >> I believe we are safe here as the k3-j721e-r5-common-proc-board.dts entire >> file is u-boot specific. k3-j721e-r5-common-proc-board.dts is not present in >> Linux DT. > > Perhaps something is out of sync as we have both > k3-j721e-common-proc-board.dts and > k3-j721e-common-proc-board-u-boot.dtsi which leads me to believe that > the former just hasn't made its way upstream yet. Thanks! Tom, k3-j721e-common-proc-board.dts is for A72 which is linux & that has corresponding k3-j721e-common-proc-board-u-boot.dtsi. Where as k3-j721e-r5-common-proc-board.dts is only for R5 SPL that is only for u-boot repo. Am i clear now. Regards, Keerthy >