References: <1520817479-17203-1-git-send-email-selva.nair@...277...> <2a4823ad-f915-610e-d3e6-5fc04abea366@...1856...> From: Steffan Karger Message-ID: <18b889b2-6c9e-b8ad-d86f-f51441e5b731@...1856...> Date: Mon, 2 Apr 2018 18:04:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH 1/2] Skip expired certificates in Windows certificate store List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Selva Nair Cc: openvpn-devel Hi, On 02-04-18 16:58, Selva Nair wrote: > On Mon, Apr 2, 2018 at 8:37 AM, Steffan Karger wrote: >> Also, this looks like a somewhat unrelated fix. I would have personally >> preferred it in a separate patch (so we can e.g. backport it easily even >> if we decide not not backport the functional change). > > The original did the search based on subject and hash separately, > which is now combined into a loop below this parsing chunk. So a > return, in place of break, is required here. The warning on parse error > is new (instead of silently returning NULL). But the end result of that > is still a FATAL error later in the code, as before. > > I'm ok to leave out the warning from this patch, though.. Ah, ok. If it's not independent, let's just keep it in this patch. -Steffan