Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id D2C5EE00CCE; Fri, 22 Feb 2019 05:39:58 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from mail.inango-sw.com (mail.inango-systems.com [213.136.71.184]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6C9D7E00994 for ; Fri, 22 Feb 2019 05:39:57 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.inango-sw.com (Postfix) with ESMTP id 5D11D7A249E; Fri, 22 Feb 2019 15:39:56 +0200 (IST) Received: from mail.inango-sw.com ([127.0.0.1]) by localhost (mail.inango-sw.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qY9C4mJsgV9H; Fri, 22 Feb 2019 15:39:52 +0200 (IST) Received: from localhost (localhost [127.0.0.1]) by mail.inango-sw.com (Postfix) with ESMTP id 0F6817A2499; Fri, 22 Feb 2019 15:39:52 +0200 (IST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.inango-sw.com 0F6817A2499 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inango-systems.com; s=45A440E0-D841-11E8-B985-5FCC721607E0; t=1550842792; bh=y/6aPwBrgRFlvQZeoVFut9xGuatvpSt5XDVldM/1EYI=; h=Date:From:To:Message-ID:MIME-Version; b=WMPkJ/ue/b9tCfTQEdhYbONJ2D6xX3nGzmlt7MfAGZyeNAG42quznJQwi5YGZ4e3k w1dP3ZqNKlVEoGQuTKhE0jO3iNNnm/PmtjK3eA4QO9vsWyxxuOTyOssS29VTRQiN/E N/BAUrBd7rQ+jKddFBzjU0jx+c2q88aq8/vBqsSBo2w21MMWt3jOhbZ+6f3eYU4Jdq +/DdddjLPGYLIPvH7t2Cdf9QuR+Hs5MHmDrAtwvVpuz4XpV4m8z6gBwcVjIOobYzgt oqE4fmt6CrpbWf0YMWcIhi0L7QAN4Sh/5WPiFV8XhXe6SIv2G+An3vihyUYkrtBs4q n91MG35QXYlMQ== X-Virus-Scanned: amavisd-new at inango-sw.com Received: from mail.inango-sw.com ([127.0.0.1]) by localhost (mail.inango-sw.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VcLYNoFL7ylw; Fri, 22 Feb 2019 15:39:51 +0200 (IST) Received: from mail.inango-sw.com (mail.inango-sw.com [172.17.220.3]) by mail.inango-sw.com (Postfix) with ESMTP id DC31D7A2427; Fri, 22 Feb 2019 15:39:51 +0200 (IST) Date: Fri, 22 Feb 2019 15:39:51 +0200 (IST) From: Ivan Efimov To: "Burton, Ross" Message-ID: <1900051135.1108421.1550842791845.JavaMail.zimbra@inango-systems.com> In-Reply-To: References: <1780990602.1036136.1550651634177.JavaMail.zimbra@inango-systems.com> MIME-Version: 1.0 X-Originating-IP: [172.17.220.3] X-Mailer: Zimbra 8.8.9_GA_3006 (ZimbraWebClient - FF65 (Linux)/8.8.9_GA_3006) Thread-Topic: btrfs-tools Makefile: 1) remove duplicate of '-o $@' option from CC cmdline; 2) disable "bttfs-fragments" tool compilation Thread-Index: lfcLXt9jdN493ADmk6HNL/+2ty9blw== Cc: Architecture group , poky Subject: Re: [PATCH 1/1] btrfs-tools Makefile: 1) remove duplicate of '-o $@' option from CC cmdline; 2) disable "bttfs-fragments" tool compilation X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion & patch submission for meta-yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 13:39:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, Ross, Thanks, i'll find the answer for your question and send my patch to openembedded-core@lists.openembedded.org. Best regards, Ivan ----- Original Message ----- From: "Burton, Ross" To: "Ivan Efimov" Cc: "poky" , "Architecture group" Sent: Thursday, February 21, 2019 5:37:52 PM Subject: Re: [poky] [PATCH 1/1] btrfs-tools Makefile: 1) remove duplicate of '-o $@' option from CC cmdline; 2) disable "bttfs-fragments" tool compilation oe-core patches to go the openembedded-core@lists.openembedded.org mailing list. You'll need to rebase onto the btrfs-tools 4.20.1 that is now in master. The patches you're applying are missing Upstream-Status and Signed-off-by tags. Also if gd isn't in oe-core and btrfs-fragments depends on it, how does the current recipe build? Ross On Wed, 20 Feb 2019 at 08:41, Ivan Efimov wrote: > > 1) Command line for target "libbtrfsutil/%.o" contained double usage of '-o $@' option and causes error: > > cc1: error: too many filenames given > > 2) "btrfs-fragments" tool depends on library "gd", but there is no "gd" recipe in Yocto Poky. > "btrfs-fragments" has been excluded from list of tools for compilation ("progs" Makefile variable) > > Signed-off-by: Ivan Efimov > --- > ...1-Makefile-disable-btrfs-fragments-compilation.patch | 15 +++++++++++++++ > ...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++ > meta/recipes-devtools/btrfs-tools/btrfs-tools_4.19.1.bb | 2 ++ > 3 files changed, 34 insertions(+) > create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-disable-btrfs-fragments-compilation.patch > create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch > > diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-disable-btrfs-fragments-compilation.patch b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-disable-btrfs-fragments-compilation.patch > new file mode 100644 > index 0000000000..c20bde967d > --- /dev/null > +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-disable-btrfs-fragments-compilation.patch > @@ -0,0 +1,15 @@ > +"btrfs-fragments" tool requires library "gd" for compilation, but > + there is no "gd" recipe in Yocto Poky > +Index: git/Makefile > +=================================================================== > +--- git.orig/Makefile > ++++ git/Makefile > +@@ -217,7 +217,7 @@ progs_build = $(progs_install) btrfsck b > + > + # All programs. Use := instead of = so that this is expanded before we reassign > + # progs_build below. > +-progs := $(progs_build) btrfs-convert btrfs-fragments > ++progs := $(progs_build) btrfs-convert > + > + ifneq ($(DISABLE_BTRFSCONVERT),1) > + progs_install += btrfs-convert > diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch > new file mode 100644 > index 0000000000..335067bc1f > --- /dev/null > +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch > @@ -0,0 +1,17 @@ > +Command line for target "libbtrfsutil/%.o" contained double usage > + of '-o $@' option and caused error: > + cc1: error: too many filenames given > + > +Index: git/Makefile > +=================================================================== > +--- git.orig/Makefile > ++++ git/Makefile > +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0 > + > + libbtrfsutil/%.o: libbtrfsutil/%.c > + @echo " [CC] $@" > +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@ > ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@ > + > + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects) > + @echo " [LD] $@" > diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.19.1.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.19.1.bb > index 2f59a0c13e..6b77ee796f 100644 > --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.19.1.bb > +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.19.1.bb > @@ -19,6 +19,8 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \ > file://0001-Makefile-build-mktables-using-native-gcc.patch \ > file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \ > file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \ > + file://0001-Makefile-disable-btrfs-fragments-compilation.patch \ > + file://0001-Makefile-fix-double-o-compiler-option-using.patch \ > " > > inherit autotools-brokensep pkgconfig manpages distutils3-base > -- > 2.14.1 > > [ https://inango.com/ | ] > Ivan Efimov > Architect, Arch Group > i.efimov@inango-systems.com > T +7 343 298 0147 C +7 904 9 888 350 > [ https://inango.com/ | inango.com ] [ https://www.linkedin.com/company/inango ] > -- > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky -- [ https://inango.com/ | ] Ivan Efimov Architect, Arch Group i.efimov@inango-systems.com T +7 343 298 0147 C +7 904 9 888 350 [ https://inango.com/ | inango.com ] [ https://www.linkedin.com/company/inango ]