From: Ian Jackson Subject: Re: [PATCH] tools: use C99 __VA_ARGS__ Date: Tue, 21 Jul 2009 14:50:56 +0100 Message-ID: <19045.51136.22397.373381@mariner.uk.xensource.com> References: <200907211501.15045.Christoph.Egger@amd.com> <19045.49654.819861.134478@mariner.uk.xensource.com> <200907211547.20773.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200907211547.20773.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Christoph Egger writes ("Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"): > On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote: > > Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"): > > > Attached patch switches tools to consistently use C99 __VA_ARGS__. > > > > What is the benefit of this ? > > Consistency in the whole tree in combination with two other patches > (xen-kernel and minios) which I have not yet submitted. Umm, so what's the benefit of the whole patchset ? > > Xen requires GCC and the GCC variable > > argument list extension has been around forever, > > That's not a reason to stick on old things. Neither is there apparently any reason to change. > > so it doesn't seem to aid portability. > > No, not in this case. > > But the other patch for the xen-kernel touches > the public headers. > AFAIK the public headers should follow the standard. Do the public headers currently work with other compilers ? There is an argument for using the standard syntax there to make it easier for kernels compiled with non-GCC compilers to provide Xen guest support. > > The GCC syntax is considerably prettier than the C99 one. > > This is subjective. Nevertheless it is true. Ian.