Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41508C77B7C for ; Wed, 10 May 2023 09:42:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A8F41847D2; Wed, 10 May 2023 11:42:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="P+5hAC+2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AED2186037; Wed, 10 May 2023 11:42:51 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8D66984780 for ; Wed, 10 May 2023 11:42:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D9C0464853; Wed, 10 May 2023 09:42:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1170BC433D2; Wed, 10 May 2023 09:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683711767; bh=v5TZAVl5vdiiYkIb+58E4MotwzngXir7IdQVmamPXAE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P+5hAC+2LiwcgHeqTT0ksO7avpkYwEs7WccZyK3Vdm1snhmv5De0XjDMMwEB979I0 W3Um0kru1nlM0F7HAd0dXn/kibgR/RnPr2g0F0a+CawkcETiYmHVtzdOzlEoGFZlmp iKlc81aNubMhpocGgzEML9/w5yZcI2Om0GUIYIYj65dkWvxscq/r0K1wecSx/PCyOW GTXtYlmcU09OUUYLEP7EBhofauHM2ixvfxNFzoBudCpJWLrsAr3JYYDgUmZ//7K8sH VFv/hne5lHDJP5S4oS3//JQxk+Q1hTOwgAxycDMi8DCzYg0SDyBvELG6gH7CywP4CG MRZhIEi2sMEXA== Message-ID: <1944d1d1-399d-dfde-16ae-21a00ff7fbe3@kernel.org> Date: Wed, 10 May 2023 12:42:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: U-Boot OMAP GPMC ECC change Content-Language: en-US To: Colin Foster Cc: Michael Trimarchi , Dario Binacchi , u-boot@lists.denx.de References: From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Colin, On 09/05/2023 18:31, Colin Foster wrote: > Hi Roger, > > I was looking to test my system against U-Boot 2023.04. I'm running an > OMAP 4460 SOM (I've been waiting to get kernel acceptance before U-Boot, > but that has slipped) and it boots from NAND. > > When I jumped from 2023.01 to 2023.04, I noticed I get spammed in the > SPL by "omap-elm: uncorrectable ECC errors". I bisected, and this seems > to be the result of commit 04fcd25873 ("mtd: rawnand: omap_gpmc: Fix > BCH6/16 HW based correction"). oops. Sorry about that. > > Is the multi-sector ECC generation something that should work in a > backward-compatible way? Do you know of anything that might be going > wrong here? The patch wasn't supposed to break anything. I do not yet know what could be wrong. Most likely a wrong ECC configuration is being used. Could you please share what ECC configuration you are using on your board? Can you please point me to the Linux device tree file if it exists? > > Any advice would be greatly appreciated, as I find it is usually > something simple I'm doing wrong that is causing most of my issues. > > > Thanks, > > Colin Foster. -- cheers, -roger