Date: Wed, 11 May 2022 12:17:33 +0200 (CEST) From: Frank Lichtenheld Message-ID: <1957647252.642516.1652264253337@...2642...> In-Reply-To: <20220422142953.3805364-18-arne@...1227...> References: <20220422134038.3801239-1-arne@...1227...> <20220422142953.3805364-1-arne@...1227...> <20220422142953.3805364-18-arne@...1227...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 27/28] Add unit test for reliable_get_num_output_sequenced_available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Acked-By: Frank Lichtenheld Not sure whether it should be concerning that reliable_get_num_output_sequenced_available is happy to give results given the complete garbage we put into the test buffer. But anyway, an UT is better than no UT and the test code looks correct to me. Obviously depends on previous patches. Regards, Frank > Arne Schwabe hat am 22.04.2022 16:29 geschrieben: > > > --- > tests/unit_tests/openvpn/Makefile.am | 5 +- > tests/unit_tests/openvpn/mock_get_random.c | 10 ++++ > tests/unit_tests/openvpn/test_packet_id.c | 55 ++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 1 deletion(-) > -- Frank Lichtenheld