From: Ian Jackson Subject: Re: [PATCH,v2]: xl: don't free string literals Date: Thu, 9 Sep 2010 18:00:07 +0100 Message-ID: <19593.4759.595408.807331@mariner.uk.xensource.com> References: <1283963489.20276.180.camel@qabil.uk.xensource.com> <1283964409.14311.1970.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1283964409.14311.1970.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Xen Devel , Gianni Tedesco List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [Xen-devel] [PATCH,v2]: xl: don't free string literals"): > About to bail for the day, but I guess this (untested) patch makes sense > on top of this? ... > Subject: xl: use xlu_cfg_replace_string in a few more places. Yes, I have applied it. > Avoids c_info->name being a string literal as well. Although I wonder if > maybe domain configurations with no name could just be rejected as > invalid? Having a whole bunch of domains called "test" doesn't seem > likely to be what anyone wants... Yes. Really we should be rejecting duplicate names. Ian.