From: David Howells Subject: [PATCH 6/5] 9p: Fix error handling on superblock alloc failure Date: Fri, 03 Mar 2006 10:49:49 +0000 Message-ID: <19741.1141382989@warthog.cambridge.redhat.com> References: <20060302213356.7282.26463.stgit@warthog.cambridge.redhat.com> Cc: linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <20060302213356.7282.26463.stgit@warthog.cambridge.redhat.com> To: torvalds@osdl.org, akpm@osdl.org, steved@redhat.com, trond.myklebust@fys.uio.no, aviro@redhat.com List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org The attached patch adds error handling and cleanup in the case that sget() fails, lest a memory leak occur. Signed-Off-By: David Howells --- fs/9p/vfs_super.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c index aedc97b..17dee27 100644 --- a/fs/9p/vfs_super.c +++ b/fs/9p/vfs_super.c @@ -135,7 +135,8 @@ static int v9fs_get_sb(struct file_syste sb = sget(fs_type, NULL, v9fs_set_super, v9ses); if (IS_ERR(sb)) { -#error this should have error handling in case sget() fails + v9fs_session_close(v9ses); + kfree(v9ses); return PTR_ERR(sb); }