From: Ian Jackson Subject: Re: [PATCH 1 of 2] tools/libxc: Remus Checkpoint Compression Date: Fri, 17 Jun 2011 19:22:14 +0100 Message-ID: <19963.39766.568781.550883@mariner.uk.xensource.com> References: <5dbafaf24c7036f3e24e.1308239406@athos.nss.cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5dbafaf24c7036f3e24e.1308239406@athos.nss.cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Shriram Rajagopalan Cc: xen-devel@lists.xensource.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Shriram Rajagopalan writes ("[Xen-devel] [PATCH 1 of 2] tools/libxc: Remus Checkpoint Compression"): > tools/libxc: Remus Checkpoint Compression > > Instead of sending dirty pages of guest memory as-is, use a simple > compression algorithm that sends a RLE-encoded XOR of the page > against its last sent copy. A small LRU cache is used to hold > recently dirtied pages. Pagetable pages are sent as-is, as they are > canonicalized at sender side and uncanonicalized at receiver. Thanks for this but it's very hard to review due to wrap damage on my terminal: - if ( wruncached(io_fd, live, page, PAGE_SIZE) != PAGE_SIZE ) + if (compression) + { + /* Add the pagetable page, raw into the page buffer */ + if (xc_remus_add_page(xch, remus_ctx, page, pfn, 1) < 0) + { + /* We are out of buffer space to hold dirty pages. + * Compress and flush the current buffer to make space. + * --This is a corner case, that slows down Please keep your lines down to 75 characters or so. Ian.