Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F01C4360F for ; Thu, 4 Apr 2019 03:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C8672133D for ; Thu, 4 Apr 2019 03:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbfDDDlk convert rfc822-to-8bit (ORCPT ); Wed, 3 Apr 2019 23:41:40 -0400 Received: from mga05.intel.com ([192.55.52.43]:9814 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfDDDlj (ORCPT ); Wed, 3 Apr 2019 23:41:39 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 20:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; d="scan'208";a="158588034" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga004.fm.intel.com with ESMTP; 03 Apr 2019 20:41:39 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.233]) by ORSMSX105.amr.corp.intel.com ([169.254.2.119]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 20:41:39 -0700 From: "Kirsher, Jeffrey T" To: Daniel Borkmann CC: William Tu , "netdev@vger.kernel.org" , "Topel, Bjorn" , "ast@kernel.org" , "Karlsson, Magnus" Subject: Re: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Thread-Topic: [PATCH bpf 1/2] ixgbe: fix AF_XDP tx byte count Thread-Index: AQHU6ns6B0l8x+xzgka7qw4Rx2Kfc6YrW6e+ Date: Thu, 4 Apr 2019 03:41:38 +0000 Message-ID: <1B10FCEE-F67C-406B-9620-33769F856469@intel.com> References: <1554328676-10715-1-git-send-email-u9012063@gmail.com>,<45aa47d7-dea3-e554-2623-bcabf64f8a87@iogearbox.net> In-Reply-To: <45aa47d7-dea3-e554-2623-bcabf64f8a87@iogearbox.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On Apr 3, 2019, at 17:13, Daniel Borkmann wrote: > > [ +Jeff ] > > Given these two are contained to ixgbe, I presume Jeff wants to pick > these up instead via his tree? Yes, I will be picking them up. > >> On 04/03/2019 11:57 PM, William Tu wrote: >> The tx bytecount is done twice. When running >> './xdpsock -t -N -i eth3' and 'ip -s link show dev eth3' >> The avg packet size is 120 instead of 60. So remove the >> extra one. >> >> Signed-off-by: William Tu >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> index bfe95ce0bd7f..71b8474a9b4c 100644 >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c >> @@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector, >> xsk_frames++; >> >> tx_bi->xdpf = NULL; >> - total_bytes += tx_bi->bytecount; >> >> tx_bi++; >> tx_desc++; >> >