From: "cron2 (Code Review)" Date: Wed, 3 Jul 2024 14:13:57 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1a1875dfd16848ca46a76980dbf713398b98fcc6-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9IAosoQEaow="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: t_server_null: multiple improvements and fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: flichtenheld , plaisthos , openvpn-devel --9IAosoQEaow= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/669?usp=3Demail ) Change subject: t_server_null: multiple improvements and fixes ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: So this works on FreeBSD and OpenBSD (great), while on NetBSD it works *som= etimes*, and then it fails to start servers again because the old servers a= re still running. When it does not work, the error message could use some improvement ``` make check-TESTS ./t_server_null.sh: sudo /bin/kill -0 succeeded, good. OpenVPN test servers up: 0/ 2 OpenVPN test servers up: 0/ 2 OpenVPN test servers up: 0/ 2 OpenVPN test servers up: 0/ 2 OpenVPN test servers up: 0/ 2 OpenVPN test servers up: 0/ 2 All clients have disconnected from all servers Waiting for servers to exit cat: ./t_server_null_server-1194_udp.pid: No such file or directory Terminated [1] Terminated ("${@}" 2>&1; es... | tee -a "${log_fi... ``` (like, showing a "tail -f" of the server logs? - which are root-owned and m= ode 0600, so not trivial. Why are they 0600 anyway, is there an explicit u= mask call?) Not sure why the processes got stuck. When running from the CLI the server= s are properly terminated... need to re-test from buildbot. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/669?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff673d8590b6b3a Gerrit-Change-Number: 669 Gerrit-PatchSet: 4 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Wed, 03 Jul 2024 14:13:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --9IAosoQEaow= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #4:

      So this works on FreeBSD and OpenBSD (great), whil= e on NetBSD it works *sometimes*, and then it fails to start servers again = because the old servers are still running.

      When it does not work, the error message coul= d use some improvement

      ```
      make check-TESTS
      ./t_server_null.sh: sudo /bin/kill -0= succeeded, good.
      OpenVPN test servers up: 0/ 2
      OpenVPN test se= rvers up: 0/ 2
      OpenVPN test servers up: 0/ 2
      OpenVPN test= servers up: 0/ 2
      OpenVPN test servers up: 0/ 2
      OpenVPN t= est servers up: 0/ 2
      All clients have disconnected from all server= s
      Waiting for servers to exit
      cat: ./t_server_null_server-1194_udp.pi= d: No such file or directory
      Terminated
      [1] Terminated = ("${@}" 2>&1; es... | tee -a "${log_fi...
      ```

      (like, showing = a "tail -f" of the server logs? - which are root-owned and mode 0= 600, so not trivial. Why are they 0600 anyway, is there an explicit umask = call?)

      Not su= re why the processes got stuck. When running from the CLI the servers are = properly terminated... need to re-test from buildbot.

    To view, visit change 669. To unsubscribe, or for help writing mail filter= s, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff= 673d8590b6b3a
    Gerrit-Change-Number: 669
    Gerrit-PatchSet: 4
    Gerrit-Owner: mattock <samuli@...515...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: cron2 <gert@...1296...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: mattock <samuli@...515...= >
    Gerrit-Comment-Date: Wed, 03 Jul 2024 14:13:57= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    --9IAosoQEaow=--