From: "cron2 (Code Review)" Date: Thu, 31 Jul 2025 09:29:55 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <1a7d6a0d2b8707d9c8ee7678554c814ae66cb9cb-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="U5iNdcvTje4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix --dns options for TAP adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --U5iNdcvTje4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1120?usp=3Demail ) Change subject: Fix --dns options for TAP adapter ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1120/comment/d02b145c_6d172850 : PS1, Line 3582: #if defined(_WIN32) As this is inside an `#if defined(_WIN32) || defined(TARGET_ANDROID)` block= and `dhcp_options` is part of the tuntap_options for both platforms, I thi= nk we can avoid that `#ifdef` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1120?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id95cd14095a03afb3140a03ae96e9f5679e4fe89 Gerrit-Change-Number: 1120 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Thu, 31 Jul 2025 09:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --U5iNdcvTje4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

Patch set 1:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/options.c:

    =
    • Patch Set #1, Line 35= 82: #if defined(_WIN32)=

      As th= is is inside an `#if defined(_WIN32) || defined(TARGET_ANDROID)` block and = `dhcp_options` is part of the tuntap_options for both platforms, I think we= can avoid that `#ifdef`

To view, visit change 1120= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id95cd14095a03afb3140a03ae96= e9f5679e4fe89
Gerrit-Change-Number: 1120
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Thu, 31 Jul 2025 09:29:55= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--U5iNdcvTje4=--