From: "cron2 (Code Review)" Date: Sat, 18 May 2024 16:08:30 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <1aecf0843ff77721b92164dc606fb1cb57ee43ea-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="acB2g/sXn4k="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: stipa , flichtenheld , plaisthos , openvpn-devel --acB2g/sXn4k= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 5: Code-Review-1 (2 comments) Patchset: PS5: Overall the patch does what it says, but it is not -Werror clean. Please fix, rebase (copyright dates have changed for the files renamed and = commit 989b22cb6e0 moved around "pipe_message_t" + changed indentation). T= hanks. File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/a60e11c6_446166ef : PS5, Line 2058: unsigned long adapter_index; This is not `-Werror` clean. GH builds complain ``` init.c:2115:26: error: variable 'adapter_index' is uninitialized when used = here [-Werror,-Wuninitialized] 68 del_wfp_block(c, adapter_index); 69 ^~~~~~~~~~~~~ 70 init.c:2047:32: note: initialize the variable 'adapter_index' to silence th= is warning 71 unsigned long adapter_index; 72 ^ 73 =3D 0 74 1 error generated. ``` This is trivially adjusted (`=3D0`) but according to project rules I can't = do that. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Sat, 18 May 2024 16:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --acB2g/sXn4k= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 5:Code-Review -1=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #5:

      Overall the patch does what it says, but it i= s not -Werror clean.

      Please fix, rebase (copyright dates have changed for the files rena= med and commit 989b22cb6e0 moved around "pipe_message_t" + change= d indentation). Thanks.

  • File src/openvpn/init.c:

    • Patch Set #5, Line 2058: unsigned long adapter_index;

      This is not `-Werror` clean. GH= builds complain

      ```
      init.c:2115:26: error: variable 'adapter_index&= #39; is uninitialized when used here [-Werror,-Wuninitialized]
      68
      = del_wfp_block(c, adapter_index);
      69
      ^~~= ~~~~~~~~~~
      70
      init.c:2047:32: note: initialize the variable 'adap= ter_index' to silence this warning
      71
      unsigned long adapter_i= ndex;
      72
      ^
      73
      = =3D 0
      74
      1 error generated.
      ```

      This is trivially adjusted (`= =3D0`) but according to project rules I can't do that.

To view, visit change 489. To unsubscribe, or for help writing mail fi= lters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f= 071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 5
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Sat, 18 May 2024 16:08:30= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--acB2g/sXn4k=--