From: "cron2 (Code Review)" Date: Sun, 22 Jun 2025 11:02:51 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <1afd09fb58c62477ff4fd7a6d931471c2a47df02-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7P0juNoYiiw="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --7P0juNoYiiw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Tested this on gentoo, with ```... --client --route-table 77 --route 10.195.0.0 255.255.0.0 --route-tab= le 78``` which does what I expected - 10.195.0.0/16 shows up in table 77, and all pu= shed routes show up in table 78 ``` 2025-06-22 13:00:15 net_route_v4_del: 10.195.0.0/16 via 10.194.2.169 dev [N= ULL] table 77 metric -1 2025-06-22 13:00:15 net_route_v4_del: 10.194.0.0/16 via 10.194.2.169 dev [N= ULL] table 78 metric -1 2025-06-22 13:00:15 net_route_v4_del: 10.194.2.1/32 via 10.194.2.169 dev [N= ULL] table 78 metric -1 ``` (and "ip route list table 77 / 78" confirms that). It claims to do the right thing for IPv6 ``` 2025-06-22 13:00:15 net_route_v6_del: fd00:abcd:194::/48 via :: dev tun8 ta= ble 78 metric -1 ``` but `ip route -6 list` shows no table (but the same holds for ipv6 routes a= dded via `ip route add -6 ... table 78` so this looks more like a linux wei= rdness than an OpenVPN/SITNL issue to me). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 9 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sun, 22 Jun 2025 11:02:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --7P0juNoYiiw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #9:

      Tested this on gentoo, with

      ```... --client --route-table 77 --= route 10.195.0.0 255.255.0.0 --route-table 78```

      which does what I expected - 10.195.0.0= /16 shows up in table 77, and all pushed routes show up in table 78

      ```
      2025-06-22 13= :00:15 net_route_v4_del: 10.195.0.0/16 via 10.194.2.169 dev [NULL] table 77= metric -1
      2025-06-22 13:00:15 net_route_v4_del: 10.194.0.0/16 via 10.19= 4.2.169 dev [NULL] table 78 metric -1
      2025-06-22 13:00:15 net_route_v4_d= el: 10.194.2.1/32 via 10.194.2.169 dev [NULL] table 78 metric -1
      ```

      =

      (and "ip ro= ute list table 77 / 78" confirms that).

      It claims to do the right thing for IPv6

      ```
      2025-06-= 22 13:00:15 net_route_v6_del: fd00:abcd:194::/48 via :: dev tun8 table 78 m= etric -1
      ```

      but `ip route -6 list` shows no table (but the same holds for ipv6 route= s added via `ip route add -6 ... table 78` so this looks more like a linux = weirdness than an OpenVPN/SITNL issue to me).

To = view, visit change 524. To unsubscribe, or for help writing mail filters, visit = settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 9
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sun, 22 Jun 2025 11:02:51= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--7P0juNoYiiw=--