Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFA4FC433EF for ; Thu, 20 Jan 2022 13:56:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A596B8389A; Thu, 20 Jan 2022 14:56:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="qd8h4+BE"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="VIyBQPwR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 58E3583892; Thu, 20 Jan 2022 14:56:26 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7ABA883892 for ; Thu, 20 Jan 2022 14:56:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 997204E200C; Thu, 20 Jan 2022 13:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642686981; bh=/TBrPrnu8erY36HtnbDtFz4s2VWoXneb2wBOecUwCQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=qd8h4+BEpLhQDttIG+pHyhFyC2UItdjlTg4ukQyUWs7BTlT+qRTblAgiJr1fbCMMP FYypABVuSty4Wq7DqvmIYgyiMl9ABOkQKEZzIZuADsjBTUp8L8wDpmWVokVeFogynm pzKo4A0jxbuY2UWU81DkD1FwQrnov7BbVuVu+AbU= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31yA0Axlvehj; Thu, 20 Jan 2022 13:56:20 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 1825A4E2003; Thu, 20 Jan 2022 13:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642686980; bh=/TBrPrnu8erY36HtnbDtFz4s2VWoXneb2wBOecUwCQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=VIyBQPwRXCdQvGgTzWP8MZ6ZoDtWLfiCteXu+bnAVCv0Nu/Lpoy5ar1G+7kH6GVb9 W9ZpglqxOG6/Zv3k+V7g53nnH0bIRiIgF349sAp6b1VkTKvKIAPnlJf+nYt06uGRsX +VKiLYQlLVfedSOL4XA822Wz0CohaKMgh23P6eYE= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 20 Jan 2022 05:56:20 -0800 From: Angus Ainslie To: Fabio Estevam Cc: Angus Ainslie , U-Boot-Denx , Simon Glass , kernel@puri.sm, Harm Berntsen Subject: Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR In-Reply-To: References: <20211128145143.1433262-1-angus@akkea.ca> Message-ID: <1afd8a7be9961df3944cdb889fd9a9b2@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, On 2022-01-18 08:59, Fabio Estevam wrote: > Hi Angus, > > On Sun, Nov 28, 2021 at 12:42 PM Angus Ainslie wrote: > >> [1] >> diff --git a/arch/arm/dts/imx8mq-librem5.dts >> b/arch/arm/dts/imx8mq-librem5.dts >> index b28420654f..b60a8538af 100644 >> --- a/arch/arm/dts/imx8mq-librem5.dts >> +++ b/arch/arm/dts/imx8mq-librem5.dts >> @@ -56,29 +56,29 @@ >> &iomuxc { >> pinctrl_hog1: hoggrp1 { > > I suspect the hog groups are not getting initialized. > > Please try: > > &iomuxc { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_hog>; > > pinctrl_hog: hoggrp { > fsl,pins = < > ...... > >; > }; > > and then group all the hog pins under the same group. > > Then check IOMUXC_SW_MUX_CTL_PAD to make sure the SION bit is set. I decided to bypass the devicetree to test it on the imx8mq static const iomux_v3_cfg_t configure_pads[] = { IMX8MQ_PAD_GPIO1_IO03__GPIO1_IO3 | MUX_PAD_CTRL(PAD_CTL_DSE6) | MUX_MODE_SION, IMX8MQ_PAD_GPIO1_IO14__GPIO1_IO14 | MUX_PAD_CTRL(PAD_CTL_DSE6) | MUX_MODE_SION, IMX8MQ_PAD_ENET_MDC__GPIO1_IO16 | MUX_PAD_CTRL(PAD_CTL_PUE) | MUX_MODE_SION, IMX8MQ_PAD_ENET_MDIO__GPIO1_IO17 | MUX_PAD_CTRL(PAD_CTL_PUE) | MUX_MODE_SION, }; static inline void init_pinmux(void) { imx_iomux_v3_setup_multiple_pads(configure_pads, ARRAY_SIZE(configure_pads)); } And this works so I need to figure out what is wrong with my devicetree configuration. Thanks Angus