From: Michel Thierry Subject: Re: [PATCH 8/8] drm/i915/icl: Use hw engine class, instance to find irq handler Date: Fri, 16 Mar 2018 11:28:57 -0700 Message-ID: <1b262dba-84ae-0af5-4e2b-827e32afb7a2@intel.com> References: <20180316121456.11577-1-mika.kuoppala@linux.intel.com> <20180316121456.11577-8-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FA1B6EBD7 for ; Fri, 16 Mar 2018 18:28:58 +0000 (UTC) In-Reply-To: <20180316121456.11577-8-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMy8xNi8yMDE4IDU6MTQgQU0sIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gSW50ZXJydXB0IGlk ZW50aXR5IHJlZ2lzdGVyIHdlIGFscmVhZHkgcmVhZCBmcm9tIGhhcmR3YXJlCj4gY29udGFpbnMg ZW5naW5lIGNsYXNzIGFuZCBpbnN0YW5jZSBmaWVsZHMuIExldmVyYWdlCj4gdGhlc2UgZmllbGRz IHRvIGZpbmQgY29ycmVjdCBlbmdpbmUgdG8gaGFuZGxlIHRoZSBpbnRlcnJ1cHQuCj4gCj4gdjM6 IHJlYmFzZSBvbiB0b3Agb2YgcnBzIGludHIKPiAgICAgIHVzZSBjb3JyZWN0IGNsYXNzIC8gaW5z dGFuY2UgbGltaXRzIChNaWNoZWwpCj4gCj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWxlIENlcmFvbG8g U3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENl cmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50 aGllcnJ5QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1 b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMgfCA4MCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCB8ICA0ICsrLQo+ICAgMiBmaWxlcyBj aGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCA1MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMKPiBpbmRleCA4YzQ1MTBmZmU2MjUuLmRkMmZiMmQwNDU3ZiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9pcnEuYwo+IEBAIC00MTMsOCArNDEzLDggQEAgc3RhdGljIHZvaWQgZ2Vu Nl9kaXNhYmxlX3BtX2lycShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBk aXNhYmxlX20KPiAgIH0KPiAgIAo+ICAgc3RhdGljIHUzMgo+IC1nZW4xMV9ndF9lbmdpbmVfaW50 cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4gLQkJICAgICBjb25zdCB1 bnNpZ25lZCBpbnQgYmFuaywgY29uc3QgdW5zaWduZWQgaW50IGJpdCk7Cj4gK2dlbjExX2d0X2Vu Z2luZV9pZGVudGl0eShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4gKwkJ CSBjb25zdCB1bnNpZ25lZCBpbnQgYmFuaywgY29uc3QgdW5zaWduZWQgaW50IGJpdCk7Cj4gICAK PiAgIHZvaWQgZ2VuMTFfcmVzZXRfcnBzX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAgewo+IEBAIC00MjgsNyArNDI4LDcgQEAgdm9pZCBnZW4xMV9yZXNl dF9ycHNfaW50ZXJydXB0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJ ICovCj4gICAJZHcgPSBJOTE1X1JFQURfRlcoR0VOMTFfR1RfSU5UUl9EVzApOwo+ICAgCXdoaWxl IChkdyAmIEJJVChHRU4xMV9HVFBNKSkgewo+IC0JCWdlbjExX2d0X2VuZ2luZV9pbnRyKGRldl9w cml2LCAwLCBHRU4xMV9HVFBNKTsKPiArCQlnZW4xMV9ndF9lbmdpbmVfaWRlbnRpdHkoZGV2X3By aXYsIDAsIEdFTjExX0dUUE0pOwo+ICAgCQlJOTE1X1dSSVRFX0ZXKEdFTjExX0dUX0lOVFJfRFcw LCBCSVQoR0VOMTFfR1RQTSkpOwo+ICAgCQlkdyA9IEk5MTVfUkVBRF9GVyhHRU4xMV9HVF9JTlRS X0RXMCk7Cj4gICAJfQo+IEBAIC0yNzcxLDUwICsyNzcxLDkgQEAgc3RhdGljIHZvaWQgX19maW5p X3dlZGdlKHN0cnVjdCB3ZWRnZV9tZSAqdykKPiAgIAkgICAgIChXKS0+aTkxNTsJCQkJCQkJXAo+ ICAgCSAgICAgX19maW5pX3dlZGdlKChXKSkpCj4gICAKPiAtc3RhdGljIHZvaWQKPiAtZ2VuMTFf Z3RfZW5naW5lX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICogY29uc3QgaTkx NSwKPiAtCQkJICAgIGNvbnN0IHVuc2lnbmVkIGludCBiYW5rLAo+IC0JCQkgICAgY29uc3QgdW5z aWduZWQgaW50IGVuZ2luZV9uLAo+IC0JCQkgICAgY29uc3QgdTE2IGlpcikKPiAtewo+IC0Jc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqKiBjb25zdCBlbmdpbmUgPSBpOTE1LT5lbmdpbmU7Cj4gLQo+ IC0Jc3dpdGNoIChiYW5rKSB7Cj4gLQljYXNlIDA6Cj4gLQkJc3dpdGNoIChlbmdpbmVfbikgewo+ IC0KPiAtCQljYXNlIEdFTjExX1JDUzA6Cj4gLQkJCXJldHVybiBnZW44X2NzX2lycV9oYW5kbGVy KGVuZ2luZVtSQ1NdLCBpaXIpOwo+IC0KPiAtCQljYXNlIEdFTjExX0JDUzoKPiAtCQkJcmV0dXJu IGdlbjhfY3NfaXJxX2hhbmRsZXIoZW5naW5lW0JDU10sIGlpcik7Cj4gLQo+IC0JCWNhc2UgR0VO MTFfR1RQTToKPiAtCQkJcmV0dXJuIGdlbjZfcnBzX2lycV9oYW5kbGVyKGk5MTUsIGlpcik7Cj4g LQkJfQo+IC0JY2FzZSAxOgo+IC0JCXN3aXRjaCAoZW5naW5lX24pIHsKPiAtCj4gLQkJY2FzZSBH RU4xMV9WQ1MoMCk6Cj4gLQkJCXJldHVybiBnZW44X2NzX2lycV9oYW5kbGVyKGVuZ2luZVtfVkNT KDApXSwgaWlyKTsKPiAtCQljYXNlIEdFTjExX1ZDUygxKToKPiAtCQkJcmV0dXJuIGdlbjhfY3Nf aXJxX2hhbmRsZXIoZW5naW5lW19WQ1MoMSldLCBpaXIpOwo+IC0JCWNhc2UgR0VOMTFfVkNTKDIp Ogo+IC0JCQlyZXR1cm4gZ2VuOF9jc19pcnFfaGFuZGxlcihlbmdpbmVbX1ZDUygyKV0sIGlpcik7 Cj4gLQkJY2FzZSBHRU4xMV9WQ1MoMyk6Cj4gLQkJCXJldHVybiBnZW44X2NzX2lycV9oYW5kbGVy KGVuZ2luZVtfVkNTKDMpXSwgaWlyKTsKPiAtCj4gLQkJY2FzZSBHRU4xMV9WRUNTKDApOgo+IC0J CQlyZXR1cm4gZ2VuOF9jc19pcnFfaGFuZGxlcihlbmdpbmVbX1ZFQ1MoMCldLCBpaXIpOwo+IC0J CWNhc2UgR0VOMTFfVkVDUygxKToKPiAtCQkJcmV0dXJuIGdlbjhfY3NfaXJxX2hhbmRsZXIoZW5n aW5lW19WRUNTKDEpXSwgaWlyKTsKPiAtCQl9Cj4gLQl9Cj4gLX0KPiAtCj4gICBzdGF0aWMgdTMy Cj4gLWdlbjExX2d0X2VuZ2luZV9pbnRyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICogY29uc3Qg aTkxNSwKPiAtCQkgICAgIGNvbnN0IHVuc2lnbmVkIGludCBiYW5rLCBjb25zdCB1bnNpZ25lZCBp bnQgYml0KQo+ICtnZW4xMV9ndF9lbmdpbmVfaWRlbnRpdHkoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKiBjb25zdCBpOTE1LAo+ICsJCQkgY29uc3QgdW5zaWduZWQgaW50IGJhbmssIGNvbnN0IHVu c2lnbmVkIGludCBiaXQpCj4gICB7Cj4gICAJdm9pZCBfX2lvbWVtICogY29uc3QgcmVncyA9IGk5 MTUtPnJlZ3M7Cj4gICAJdTMyIHRpbWVvdXRfdHM7Cj4gQEAgLTI4NDEsNyArMjgwMCwyNiBAQCBn ZW4xMV9ndF9lbmdpbmVfaW50cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNvbnN0IGk5MTUs Cj4gICAJcmF3X3JlZ193cml0ZShyZWdzLCBHRU4xMV9JTlRSX0lERU5USVRZX1JFRyhiYW5rKSwK PiAgIAkJICAgICAgR0VOMTFfSU5UUl9EQVRBX1ZBTElEKTsKPiAgIAo+IC0JcmV0dXJuIGlkZW50 ICYgR0VOMTFfSU5UUl9FTkdJTkVfTUFTSzsKPiArCXJldHVybiBpZGVudDsKPiArfQo+ICsKPiAr c3RhdGljIHZvaWQKPiArZ2VuMTFfZ3RfaWRlbnRpdHlfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqIGNvbnN0IGk5MTUsCj4gKwkJCSAgY29uc3QgdTMyIGlkZW50aXR5KQo+ICt7Cj4g Kwljb25zdCB1OCBjbGFzcyA9IEdFTjExX0lOVFJfRU5HSU5FX0NMQVNTKGlkZW50aXR5KTsKPiAr CWNvbnN0IHU4IGluc3RhbmNlID0gR0VOMTFfSU5UUl9FTkdJTkVfSU5TVEFOQ0UoaWRlbnRpdHkp Owo+ICsJY29uc3QgdTE2IGlpciA9IEdFTjExX0lOVFJfRU5HSU5FX01BU0soaWRlbnRpdHkpOwo+ ICsKPiArCWlmICh1bmxpa2VseSghaWlyKSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWYgKGNsYXNz IDw9IE1BWF9FTkdJTkVfQ0xBU1MgJiYgaW5zdGFuY2UgPD0gTUFYX0VOR0lORV9JTlNUQU5DRSkK PiArCQlyZXR1cm4gZ2VuOF9jc19pcnFfaGFuZGxlcihpOTE1LT5lbmdpbmVfY2xhc3NbY2xhc3Nd W2luc3RhbmNlXSwKPiArCQkJCQkgICBpaXIpOwo+ICsKPiArCWlmIChjbGFzcyA9PSBHRU4xMV9H VFBNKQo+ICsJCXJldHVybiBnZW42X3Jwc19pcnFfaGFuZGxlcihpOTE1LCBpaXIpOwoKSGksCgpH RU4xMV9HVFBNIHNob3VsZCBiZQoJW0NsYXNzIElEXSA9PSAnT1RIRVJfQ0xBU1MgKDQpJywgYW5k CglbRW5naW5lIElkXSA9PSAxLgooSSdtIGxvb2tpbmcgYXQgYnNwZWMgMjA5NDQpCgpTbyBub3Qg b25seSB0aGUgR1BUTSBjaGVjayBuZWVkcyB0byBiZSBiZWZvcmUgdGhlCiAgIGlmIChjbGFzcyA8 PSBNQVhfRU5HSU5FX0NMQVNTKSwKCmJ1dCBpdCBjYW4ndCB1c2UgR0VOMTFfR1RQTSBlaXRoZXIu CgotTWljaGVsCgoKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQKPiBAQCAtMjg2NiwxMiArMjg0 NCwxMCBAQCBnZW4xMV9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqIGNv bnN0IGk5MTUsCj4gICAJCX0KPiAgIAo+ICAgCQlmb3JfZWFjaF9zZXRfYml0KGJpdCwgJmludHJf ZHcsIDMyKSB7Cj4gLQkJCWNvbnN0IHUxNiBpaXIgPSBnZW4xMV9ndF9lbmdpbmVfaW50cihpOTE1 LCBiYW5rLCBiaXQpOwo+IC0KPiAtCQkJaWYgKHVubGlrZWx5KCFpaXIpKQo+IC0JCQkJY29udGlu dWU7Cj4gKwkJCWNvbnN0IHUzMiBpZGVudCA9IGdlbjExX2d0X2VuZ2luZV9pZGVudGl0eShpOTE1 LAo+ICsJCQkJCQkJCSAgIGJhbmssIGJpdCk7Cj4gICAKPiAtCQkJZ2VuMTFfZ3RfZW5naW5lX2ly cV9oYW5kbGVyKGk5MTUsIGJhbmssIGJpdCwgaWlyKTsKPiArCQkJZ2VuMTFfZ3RfaWRlbnRpdHlf aGFuZGxlcihpOTE1LCBpZGVudCk7Cj4gICAJCX0KPiAgIAo+ICAgCQkvKiBDbGVhciBtdXN0IGJl IGFmdGVyIHNoYXJlZCBoYXMgYmVlbiBzZXJ2ZWQgZm9yIGVuZ2luZSAqLwo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9yZWcuaAo+IGluZGV4IGYzY2M3NzY5MDEyNC4uNzRhOGY0NTRlOGEwIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTY4MjYsNyArNjgyNiw5IEBAIGVudW0gewo+ICAgI2Rl ZmluZSBHRU4xMV9JTlRSX0lERU5USVRZX1JFRzAJX01NSU8oMHgxOTAwNjApCj4gICAjZGVmaW5l IEdFTjExX0lOVFJfSURFTlRJVFlfUkVHMQlfTU1JTygweDE5MDA2NCkKPiAgICNkZWZpbmUgIEdF TjExX0lOVFJfREFUQV9WQUxJRAkJKDEgPDwgMzEpCj4gLSNkZWZpbmUgIEdFTjExX0lOVFJfRU5H SU5FX01BU0sJCSgweGZmZmYpCj4gKyNkZWZpbmUgIEdFTjExX0lOVFJfRU5HSU5FX01BU0soeCkJ KCh4KSAmIDB4ZmZmZikKPiArI2RlZmluZSAgR0VOMTFfSU5UUl9FTkdJTkVfQ0xBU1MoeCkJKCgo eCkgJiBHRU5NQVNLKDE4LCAxNikpID4+IDE2KQo+ICsjZGVmaW5lICBHRU4xMV9JTlRSX0VOR0lO RV9JTlNUQU5DRSh4KQkoKCh4KSAmIEdFTk1BU0soMjUsIDIwKSkgPj4gMjApCj4gICAKPiAgICNk ZWZpbmUgR0VOMTFfSU5UUl9JREVOVElUWV9SRUcoeCkJX01NSU8oMHgxOTAwNjAgKyAoeCAqIDQp KQo+ICAgCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=